Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1456)

Issue 326870043: Change all instances of \partcombine to \partCombine in the documentation

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by pkx166h
Modified:
2 years, 1 month ago
Reviewers:
dak, phileholmes, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change all instances of \partcombine to \partCombine in the documentation Issue 4603 (2 of 3) All instances of \partcombine in ../Documentation (including translated and snippets) have been changed to \partCombine.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -396 lines) Patch
M Documentation/ca/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ca/notation/simultaneous.itely View 9 chunks +39 lines, -39 lines 0 comments Download
M Documentation/ca/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/cs/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/notation/fretted-strings.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/notation/simultaneous.itely View 9 chunks +32 lines, -32 lines 0 comments Download
M Documentation/de/texidocs/combining-two-parts-on-the-same-staff.texidoc View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/de/texidocs/partcombine-and-autobeamoff.texidoc View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/de/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/notation/fretted-strings.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/notation/simultaneous.itely View 10 chunks +39 lines, -39 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 5 chunks +6 lines, -6 lines 0 comments Download
M Documentation/es/texidocs/changing-partcombine-texts.texidoc View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/texidocs/combining-two-parts-on-the-same-staff.texidoc View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/texidocs/partcombine-and-autobeamoff.texidoc View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/notation/fretted-strings.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/notation/simultaneous.itely View 7 chunks +39 lines, -39 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 5 chunks +6 lines, -6 lines 0 comments Download
M Documentation/fr/texidocs/combining-two-parts-on-the-same-staff.texidoc View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/texidocs/partcombine-and-autobeamoff.texidoc View 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/it/notation/simultaneous.itely View 8 chunks +39 lines, -39 lines 0 comments Download
M Documentation/it/notation/vocal.itely View 5 chunks +6 lines, -6 lines 0 comments Download
M Documentation/it/texidocs/changing-partcombine-texts.texidoc View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/texidocs/combining-two-parts-on-the-same-staff.texidoc View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/it/texidocs/partcombine-and-autobeamoff.texidoc View 2 chunks +4 lines, -4 lines 0 comments Download
M Documentation/it/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/notation/fretted-strings.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/ja/notation/simultaneous.itely View 7 chunks +33 lines, -33 lines 0 comments Download
M Documentation/ja/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ly-examples/sesto-piano.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/notation/input.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/notation/rhythms.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 8 chunks +39 lines, -39 lines 0 comments Download
M Documentation/notation/vocal.itely View 5 chunks +6 lines, -6 lines 0 comments Download
M Documentation/snippets/changing-partcombine-texts.ly View 1 chunk +2 lines, -2 lines 2 comments Download
M Documentation/snippets/combining-two-parts-on-the-same-staff.ly View 3 chunks +5 lines, -5 lines 0 comments Download
M Documentation/snippets/new/combining-two-parts-on-the-same-staff.ly View 3 chunks +5 lines, -5 lines 0 comments Download
M Documentation/snippets/partcombine-and-autobeamoff.ly View 3 chunks +5 lines, -5 lines 0 comments Download
M Documentation/snippets/two--partcombine-pairs-on-one-staff.ly View 6 chunks +12 lines, -12 lines 0 comments Download
M Documentation/snippets/vocal-ensemble-template-with-automatic-piano-reduction.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/usage/updating.itely View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
PhilEHolmes
A note on snippets. https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly File Documentation/snippets/changing-partcombine-texts.ly (right): https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24 Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine If files in the ...
2 years, 1 month ago (2017-07-10 12:50:12 UTC) #1
dak
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly File Documentation/snippets/changing-partcombine-texts.ly (right): https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24 Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine On 2017/07/10 12:50:12, PhilEHolmes wrote: > If files ...
2 years, 1 month ago (2017-07-10 14:09:53 UTC) #2
Carl
On 2017/07/10 14:09:53, dak wrote: > https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly > File Documentation/snippets/changing-partcombine-texts.ly (right): > > https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24 > ...
2 years, 1 month ago (2017-07-10 15:38:52 UTC) #3
dak
On 2017/07/10 15:38:52, Carl wrote: > On 2017/07/10 14:09:53, dak wrote: > > > https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly ...
2 years, 1 month ago (2017-07-10 16:00:36 UTC) #4
pkx166h
2 years, 1 month ago (2017-07-11 09:35:31 UTC) #5
On 2017/07/10 16:00:36, dak wrote:
> On 2017/07/10 15:38:52, Carl wrote:
> > On 2017/07/10 14:09:53, dak wrote:
> > >
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > > File Documentation/snippets/changing-partcombine-texts.ly (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > > Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> > > On 2017/07/10 12:50:12, PhilEHolmes wrote:
> 
> > > > The best way to change snippets is to edit the LSR and then
> > > > follow the CG instructions for transferring those changes over
> > > > to the docs.  HTH.
> 
> > > This is not an option since snippets in the LSR are supposed to be
> > > valid for an older version of LilyPond.
> 
> > > Instead you have to rely on the convert-ly run that makelsr.py
> > > does.
> 
> > I understood that the CG also says you can place an edited version
> > of the snippet in Documentation/snippets/new with a lilypond version
> > of the current development version.  Is this incorrect?
> 
> This is correct but causes significant followup maintenance work as it
> creates snippet versions maintained separately from the LSR.  For
> things that are successfully covered by convert-ly rules it does not
> make sense to engage this mechanism.
> 
> This particularly concerns _bulks_ of snippets.

Maybe I am being over-optimistic, but I thought that with makelsr.py running the
convert script and so updating the version number that snippets without any
convert rules needed would stay at a version compatible with the LSR and so
while we would have a number fo additional snippets in the LP repo compared to
LSR, the version number would facilitate all this working correctly.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b