Change all instances of \partcombine to \partCombine in the documentation

Change all instances of \partcombine to \partCombine in the documentation

Issue 4603 (2 of 3)

All instances of \partcombine in
../Documentation (including translated
and snippets) have been changed to
\partCombine.

[PhilEHolmes, 2017-07-10 12:50:12]

A note on snippets.

https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
File Documentation/snippets/changing-partcombine-texts.ly (right):

https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
If files in the snippets directory are changed, the changes will be reverted as
soon as anyone runs makelsr.  The best way to change snippets is to edit the LSR
and then follow the CG instructions for transferring those changes over to the
docs.  HTH.

[dak, 2017-07-10 14:09:53]

https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
File Documentation/snippets/changing-partcombine-texts.ly (right):

https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
On 2017/07/10 12:50:12, PhilEHolmes wrote:
> If files in the snippets directory are changed, the changes will be reverted
as
> soon as anyone runs makelsr.  The best way to change snippets is to edit the
LSR
> and then follow the CG instructions for transferring those changes over to the
> docs.  HTH.

This is not an option since snippets in the LSR are supposed to be valid for an
older version of LilyPond.

Instead you have to rely on the convert-ly run that makelsr.py does.

[Carl, 2017-07-10 15:38:52]

On 2017/07/10 14:09:53, dak wrote:
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> File Documentation/snippets/changing-partcombine-texts.ly (right):
> 
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> On 2017/07/10 12:50:12, PhilEHolmes wrote:
> > If files in the snippets directory are changed, the changes will be reverted
> as
> > soon as anyone runs makelsr.  The best way to change snippets is to edit the
> LSR
> > and then follow the CG instructions for transferring those changes over to
the
> > docs.  HTH.
> 
> This is not an option since snippets in the LSR are supposed to be valid for
an
> older version of LilyPond.
> 
> Instead you have to rely on the convert-ly run that makelsr.py does.

I understood that the CG also says you can place an edited version of the
snippet in Documentation/snippets/new  with a lilypond version of the current
development version.  Is this incorrect?

[dak, 2017-07-10 16:00:36]

On 2017/07/10 15:38:52, Carl wrote:
> On 2017/07/10 14:09:53, dak wrote:
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > File Documentation/snippets/changing-partcombine-texts.ly (right):
> > 
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> > On 2017/07/10 12:50:12, PhilEHolmes wrote:

> > > The best way to change snippets is to edit the LSR and then
> > > follow the CG instructions for transferring those changes over
> > > to the docs.  HTH.

> > This is not an option since snippets in the LSR are supposed to be
> > valid for an older version of LilyPond.

> > Instead you have to rely on the convert-ly run that makelsr.py
> > does.

> I understood that the CG also says you can place an edited version
> of the snippet in Documentation/snippets/new with a lilypond version
> of the current development version.  Is this incorrect?

This is correct but causes significant followup maintenance work as it
creates snippet versions maintained separately from the LSR.  For
things that are successfully covered by convert-ly rules it does not
make sense to engage this mechanism.

This particularly concerns _bulks_ of snippets.

[pkx166h, 2017-07-11 09:35:31]

On 2017/07/10 16:00:36, dak wrote:
> On 2017/07/10 15:38:52, Carl wrote:
> > On 2017/07/10 14:09:53, dak wrote:
> > >
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > > File Documentation/snippets/changing-partcombine-texts.ly (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changi...
> > > Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> > > On 2017/07/10 12:50:12, PhilEHolmes wrote:
> 
> > > > The best way to change snippets is to edit the LSR and then
> > > > follow the CG instructions for transferring those changes over
> > > > to the docs.  HTH.
> 
> > > This is not an option since snippets in the LSR are supposed to be
> > > valid for an older version of LilyPond.
> 
> > > Instead you have to rely on the convert-ly run that makelsr.py
> > > does.
> 
> > I understood that the CG also says you can place an edited version
> > of the snippet in Documentation/snippets/new with a lilypond version
> > of the current development version.  Is this incorrect?
> 
> This is correct but causes significant followup maintenance work as it
> creates snippet versions maintained separately from the LSR.  For
> things that are successfully covered by convert-ly rules it does not
> make sense to engage this mechanism.
> 
> This particularly concerns _bulks_ of snippets.

Maybe I am being over-optimistic, but I thought that with makelsr.py running the
convert script and so updating the version number that snippets without any
convert rules needed would stay at a version compatible with the LSR and so
while we would have a number fo additional snippets in the LP repo compared to
LSR, the version number would facilitate all this working correctly.

James