Code review - Issue 326870043: Change all instances of \partcombine to \partCombine in the documentationhttps://codereview.appspot.com/2017-07-11T09:35:31+00:00rietveld
Message from unknown
2017-07-10T10:18:43+00:00pkx166hurn:md5:53b5beba7559d349ce7d56df5382206d
Message from PhilEHolmes@googlemail.com
2017-07-10T12:50:12+00:00PhilEHolmesurn:md5:f2660a59b750e924a7a0782a2fb63df5
A note on snippets.
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly
File Documentation/snippets/changing-partcombine-texts.ly (right):
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24
Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
If files in the snippets directory are changed, the changes will be reverted as soon as anyone runs makelsr. The best way to change snippets is to edit the LSR and then follow the CG instructions for transferring those changes over to the docs. HTH.
Message from dak@gnu.org
2017-07-10T14:09:53+00:00dakurn:md5:ada2530df803f5c42f0a4cb7bfd8761b
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly
File Documentation/snippets/changing-partcombine-texts.ly (right):
https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24
Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
On 2017/07/10 12:50:12, PhilEHolmes wrote:
> If files in the snippets directory are changed, the changes will be reverted as
> soon as anyone runs makelsr. The best way to change snippets is to edit the LSR
> and then follow the CG instructions for transferring those changes over to the
> docs. HTH.
This is not an option since snippets in the LSR are supposed to be valid for an older version of LilyPond.
Instead you have to rely on the convert-ly run that makelsr.py does.
Message from Carl.D.Sorensen@gmail.com
2017-07-10T15:38:52+00:00Carlurn:md5:7f812f9caef5e492274e5a8a49a8928d
On 2017/07/10 14:09:53, dak wrote:
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly
> File Documentation/snippets/changing-partcombine-texts.ly (right):
>
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24
> Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> On 2017/07/10 12:50:12, PhilEHolmes wrote:
> > If files in the snippets directory are changed, the changes will be reverted
> as
> > soon as anyone runs makelsr. The best way to change snippets is to edit the
> LSR
> > and then follow the CG instructions for transferring those changes over to the
> > docs. HTH.
>
> This is not an option since snippets in the LSR are supposed to be valid for an
> older version of LilyPond.
>
> Instead you have to rely on the convert-ly run that makelsr.py does.
I understood that the CG also says you can place an edited version of the snippet in Documentation/snippets/new with a lilypond version of the current development version. Is this incorrect?
Message from dak@gnu.org
2017-07-10T16:00:36+00:00dakurn:md5:f8089de2b3f06e16990a243537470c06
On 2017/07/10 15:38:52, Carl wrote:
> On 2017/07/10 14:09:53, dak wrote:
> >
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly
> > File Documentation/snippets/changing-partcombine-texts.ly (right):
> >
> >
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24
> > Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> > On 2017/07/10 12:50:12, PhilEHolmes wrote:
> > > The best way to change snippets is to edit the LSR and then
> > > follow the CG instructions for transferring those changes over
> > > to the docs. HTH.
> > This is not an option since snippets in the LSR are supposed to be
> > valid for an older version of LilyPond.
> > Instead you have to rely on the convert-ly run that makelsr.py
> > does.
> I understood that the CG also says you can place an edited version
> of the snippet in Documentation/snippets/new with a lilypond version
> of the current development version. Is this incorrect?
This is correct but causes significant followup maintenance work as it
creates snippet versions maintained separately from the LSR. For
things that are successfully covered by convert-ly rules it does not
make sense to engage this mechanism.
This particularly concerns _bulks_ of snippets.
Message from pkx166h@gmail.com
2017-07-11T09:35:31+00:00pkx166hurn:md5:4d7bbafba4ab6c5d8fcb3e42bd21eeb1
On 2017/07/10 16:00:36, dak wrote:
> On 2017/07/10 15:38:52, Carl wrote:
> > On 2017/07/10 14:09:53, dak wrote:
> > >
> >
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly
> > > File Documentation/snippets/changing-partcombine-texts.ly (right):
> > >
> > >
> >
> https://codereview.appspot.com/326870043/diff/1/Documentation/snippets/changing-partcombine-texts.ly#newcode24
> > > Documentation/snippets/changing-partcombine-texts.ly:24: \partCombine
> > > On 2017/07/10 12:50:12, PhilEHolmes wrote:
>
> > > > The best way to change snippets is to edit the LSR and then
> > > > follow the CG instructions for transferring those changes over
> > > > to the docs. HTH.
>
> > > This is not an option since snippets in the LSR are supposed to be
> > > valid for an older version of LilyPond.
>
> > > Instead you have to rely on the convert-ly run that makelsr.py
> > > does.
>
> > I understood that the CG also says you can place an edited version
> > of the snippet in Documentation/snippets/new with a lilypond version
> > of the current development version. Is this incorrect?
>
> This is correct but causes significant followup maintenance work as it
> creates snippet versions maintained separately from the LSR. For
> things that are successfully covered by convert-ly rules it does not
> make sense to engage this mechanism.
>
> This particularly concerns _bulks_ of snippets.
Maybe I am being over-optimistic, but I thought that with makelsr.py running the convert script and so updating the version number that snippets without any convert rules needed would stay at a version compatible with the LSR and so while we would have a number fo additional snippets in the LP repo compared to LSR, the version number would facilitate all this working correctly.
James