Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
5307080	code review 5307080: builtin: document built-in error type (Closed)	adg	rsc, r, r2, illia1991nabatov, bradfitz, rog	3	1 week, 1 day
2025041	code review 2025041: build: update, streamline documentation for new $GOBIN (Closed)	rsc	ambernopalduvall, r, adg, 周	7	1 week, 2 days
561790043	Remove define causing a warning (Closed)	hahnjo	Dan Eble, lemzwerg		2 weeks
548030043	Add option to use Ghostscript API instead of forking (Closed)	hahnjo	Valentin Villenave, dak, lemzwerg, hanwenn	7	2 weeks
567610043	flask-tryton: Set _request in default context (Closed)	ced			1 month, 3 weeks
5476044	upload.py -m --message option refactoring (Closed)	techtonik	Andi Albrecht, GvR, M-A	1	3 months, 3 weeks
842043	PEP 3147 implementation (Closed)	barry	Benjamin, pjenvey, Antoine Pitrou, Georg, brett.cannon	172	4 months, 3 weeks
557680044	Remove reimplementation of linear_interpolate() from stencil-integral (Closed)	hanwenn			6 months, 3 weeks
551690046	Shortcut Rational addition if either operand is zero (Closed)	hanwenn	Dan Eble, lemzwerg, hahnjo	5	6 months, 3 weeks
559870043	Fix comment for Box::unite (Closed)	hanwenn	Dan Eble, lemzwerg	2	6 months, 3 weeks
573730043	Use binary search in Axis_group_interface::combine_pure_heights. (Closed)	hanwenn	lemzwerg, hahnjo	1	6 months, 3 weeks
557780044	output-distance: print summary as final step (Closed)	hanwenn			6 months, 3 weeks
577820043	Build slur skyline out of segments rather than boxes. (Closed)	hanwenn	hahnjo	2	6 months, 3 weeks
581960043	Thread skyline construction through stencil interpretation (Closed)	hanwenn	dak, hahnjo	15	6 months, 3 weeks
549920043	Use a hash table for the lexer keywords (Closed)	hanwenn	dak, lemzwerg, hahnjo	3	6 months, 3 weeks
553980043	Calculate skylines only once. (Closed)	hanwenn	lemzwerg	2	6 months, 3 weeks
573770043	Use axis indexing to clarify different behaviors for X/Y skylines (Closed)	hanwenn	hahnjo	2	6 months, 3 weeks
545970043	Compute SVG skyline based on original data (Closed)	hanwenn			6 months, 3 weeks
555760043	Convert stencil to skyline directly (Closed)	hanwenn	hahnjo	6	6 months, 3 weeks
567530052	output-distance: create PNG files in batch (Closed)	hanwenn	hahnjo	2	6 months, 3 weeks

1 - 20 Older ›