Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
359720043	[plaso] Moved IsText from utils to text parser #1958 (Closed)	Joachim Metz	onager		12 hours, 17 minutes
346080043	Issue 5344: Avoid repeated calculation of accepted contexts (Closed)	Dan Eble	dak	7	19 hours, 49 minutes
344030043	ticket:13766: Make UnicodeMapTest#TestUnicodeMapGeneralCategory smaller. (Closed)	roubert (google)	markdavis, mark.edward.davis	4	1 day, 21 hours
347890043	[plaso] Migrated PLSRecall construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		1 day, 22 hours
343850043	[plaso] Added utility scripts to plot tasks profiling data (Closed)	Joachim Metz	onager		1 day, 22 hours
347900043	[plaso] Migrated ASL construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	romaing, onager		1 day, 22 hours
346100043	Use more const Grobs in the Paper_column interface (Closed)	Dan Eble	dak	3	3 days, 11 hours
349720043	ticket:13840 Fixing memory overflow issue in number_decimalquantity.cpp (Closed)	sffc	andy.heninger	1	3 days, 20 hours
348840043	[plaso] Migrated Safari cookies construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		5 days
348940043	[plaso] Migrated Windows Recycler and Recycle.Bin construct-based parsers to use dtfabric #1893 (Closed)	Joachim Metz	onager		5 days
347800043	[plaso] Migrated cups_ipp construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		5 days, 10 hours
346090043	[plaso] Migrated Java Idx construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		5 days, 10 hours
348940044	Issue 5340: Simplify Spacing_spanner::get_columns (Closed)	Dan Eble			6 days, 23 hours
339710043	Issue 5337: Create Bottom contexts in a more general way (Closed)	Dan Eble	carl.d.sorensen, Carl		1 week, 1 day
341360044	[plaso] Migrated NTFS USN change journal construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		1 week, 2 days
343950043	[plaso] Migrated utmp construct-based parser to use dtfabric #1893 (Closed)	Joachim Metz	onager		1 week, 2 days
341340043	[plaso] Replaced CopyToDatetime in output modules by dfdatetime (Closed)	Joachim Metz	onager		1 week, 3 days
343260043	[plaso] Updated Windows release build script to include YAML files #1917 (Closed)	Joachim Metz	onager	2	1 week, 3 days
344010043	Issue 5336: Remove downcasting methods from Grob_array and Grob_info (Closed)	Dan Eble	dak, dan, carl.d.sorensen, Carl		1 week, 3 days
348950043	[l2tdevtools] Changed review-pr to support multiple github organizations (Closed)	Joachim Metz	onager		1 week, 4 days

1 - 20 Older ›