Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
343780043	[dfvfs] Work-around for TSK behavior of DECOMP HFS data fork (Closed)	Joachim Metz	jberggren, seikosta		1 day, 8 hours
341110043	[plaso] Added missing GetEventDataByIdentifier to storage writer #1821 (Closed)	Joachim Metz	romaing		1 day, 19 hours
345810043	[plaso] Changes to Travis configurations to run end-to-end tests (Closed)	Joachim Metz	romaing		2 days, 8 hours
344810043	Updates the job run details page to add the transfer counters information. (Closed)	alanmorales	thobrla	9	2 days, 15 hours
341070043	[l2tdevtools] Changes to Travis configuration and setup.py (Closed)	Joachim Metz	romaing		3 days, 2 hours
336650043	http://codereview.appspot.com/340840043 (Closed)	ammo6818-vandals.uidaho.edu	Stefano Avallone		4 days, 22 hours
343790043	[dfvfs] Changed recursive hasher to use SHA-256 and print partitions #291 (Closed)	Joachim Metz	romaing	2	5 days, 7 hours
341970043	[dfvfs] Added recursive hasher end-to-end test (Closed)	Joachim Metz	romaing	2	1 week
341050043	makelsr.py: don't delete the output directory (Closed)	Dan Eble			1 week, 2 days
334690043	[plaso] Updated dependency scripts and configurations (Closed)	Joachim Metz	jberggren, onager		1 week, 4 days
338680043	ticket:13684 Making DecimalMatcher no longer consume trailing grouping separators, which is consist… (Closed)	sffc	andy.heninger		1 week, 5 days
345770043	[plaso] Improved engine test coverage and clean up (Closed)	Joachim Metz	jberggren		1 week, 6 days
340600043	[plaso] Improved profiling support in psort (Closed)	Joachim Metz	jberggren	2	1 week, 6 days
340990043	ticket:13672 Enabling double_conversion StringToDoubleConverter and using it in DecimalQuantity's t… (Closed)	sffc	andy.heninger	8	1 week, 6 days
342790043	Adding signed integer arithmetic logic to C++ number formatting/parsing (Closed)	sffc	andy.heninger	2	1 week, 6 days
340640043	[dfdatetime] Updated dependency information (Closed)	Joachim Metz	jberggren	2	1 week, 6 days
341020043	[l2tdevtools] Refactored TravisInstallScriptWriter to use template file (Closed)	Joachim Metz	jberggren		1 week, 6 days
345780043	[l2tdevtools] Added initial verion of setup.py dependency writer #157 (Closed)	Joachim Metz	jberggren	2	1 week, 6 days
341030043	[l2tdevtools] Added dependency writers for macOS scripts #321 (Closed)	Joachim Metz	jberggren	2	1 week, 6 days
340630043	[l2tdevtools] Merged Travis-CI script writers and clean up (Closed)	Joachim Metz	jberggren		2 weeks

1 - 20 Older ›