Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Recent Closed Issues

1 - 20 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
4907041	code review 4907041: builtin: add documentation for builtins (Closed)	r	gri, dsymonds, rsc, niemeyer	23	1 week, 3 days
4661051	code review 4661051: strings.Split: make the default to split all. (Closed)	r	brainman, dsymonds, rsc, adg	8	1 week, 4 days
3103042	code review 3103042: LICENSE: separate, change PATENTS text (Closed)	rsc	savemotherearth21, iant		1 month, 1 week
5307080	code review 5307080: builtin: document built-in error type (Closed)	adg	rsc, hackercombodia855, r, r2, illia1991nabatov, bradfitz, rog	3	3 months
554070043	flask-tryton: Ensure to store a list in _RecordsProxy (Closed)	ced	pokoli		4 months, 1 week
550010043	flask-tryton: Restore transaction as staticmethod (Closed)	ced			6 months, 3 weeks
6310062	URLFetcher has moved from content to net, update references. (Closed)	thakis	Afsar, wilkinsonjkevin, akalin	2	8 months, 2 weeks
97113	Rename genxml to bundle, and copy in required jars. (Closed)	do_not_use	woodie	15	8 months, 2 weeks
156082	recent changes to tools (Closed)	woodie	do_not_use	2	8 months, 2 weeks
129078	add support for precompilation-enabled (Closed)	woodie	do_not_use	13	8 months, 2 weeks
553980044	Further cleanup/regularisation of Callback_wrapper classes and trampolines (Closed)	dak			9 months, 2 weeks
294680043	Display \time beat structure as list (Closed)	dak			9 months, 2 weeks
301880043	Change type_p_name_ generally to char pointer (Closed)	dak			9 months, 2 weeks
296330044	Make define-session{,-public} private (Closed)	dak			9 months, 2 weeks
296310043	Give add_acknowledger SCM &, not Protected_scm & (Closed)	dak			9 months, 2 weeks
295430043	Remove Protected_scm destructor (Closed)	dak			9 months, 2 weeks
294650043	Move translator initializations to X::boot () (Closed)	dak			9 months, 2 weeks
300290043	Remove delegating listener stubs (Closed)	dak			9 months, 2 weeks
295480044	Remove ack_finder/ack_find_base (Closed)	dak			9 months, 2 weeks
301890043	Remove DECLARE_* translator callback macros (Closed)	dak			9 months, 2 weeks

1 - 20 Older ›