Issue 240043: code review 240043: Adds the SHA512 Hash functions as specified in FIPS 180-2.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 240043: code review 240043: Adds the SHA512 Hash functions as specified in FIPS 180-2. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by cemeyer

Modified:
1 week, 1 day ago

Reviewers:
RSMM, rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

Adds the SHA512 Hash functions as specified in FIPS 180-2.

Patch Set 1 #

Patch Set 2 : code review 240043: Adds the SHA512 Hash functions as specified in FIPS 180-2. #

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+357 lines, -0 lines)			Patch
M	src/pkg/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/crypto/sha512/Makefile	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/sha512/sha512.go	View	1 chunk	+127 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/sha512/sha512_test.go	View	1 chunk	+73 lines, -0 lines	0 comments	Download
A	src/pkg/crypto/sha512/sha512block.go	View	1 chunk	+144 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

16 years, 6 months ago (2010-03-07 01:22:07 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=4e0b5c27a563 *** crypto/sha512: new package R=rsc CC=golang-dev http://codereview.appspot.com/240043 Committer: Russ Cox <rsc@golang.org>

16 years, 6 months ago (2010-03-09 01:00:06 UTC) #3

RSMM

1 week, 1 day ago (2026-09-09 00:30:16 UTC) #4

Message was sent while issue was closed.

On 2010/03/09 00:51:06, rsc wrote:
> <font dir="auto" style="vertical-align: inherit;"><font dir="auto"
style="vertical-align: inherit;">LGTM</font></font><font></font>
> <font></font><font dir="auto" style="vertical-align: inherit;"><font
dir="auto" style="vertical-align: inherit;">
> Esos hashes sí que son grandes.</font></font>

>Si son grandes esos hashes.</font></font>

Expand All Messages | Collapse All Messages