Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1136)

Issue 131330044: Fix cacert.pem extraction from zip. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by vadimsh
Modified:
3 days, 1 hour ago
Reviewers:
M-A
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org
Base URL:
https://code.google.com/p/swarming.client/@master
Visibility:
Public.

Description

Fix cacert.pem extraction from zip. Two issues addressed here: * Looks like something is nuking /tmp/* on bots, and extracted cacert.pem with it, which causes https requests to fail. Extract cert bundle to ./ instead. * utils/oauth.py is broken when used from inside zip archive. R=maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=e7d8b98

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M utils/net.py View 4 chunks +1 line, -16 lines 0 comments Download
M utils/oauth.py View 2 chunks +3 lines, -2 lines 0 comments Download
M utils/tools.py View 1 2 chunks +27 lines, -0 lines 0 comments Download
M utils/zip_package.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
vadimsh
ptal https://codereview.appspot.com/131330044/diff/1/utils/net.py File utils/net.py (left): https://codereview.appspot.com/131330044/diff/1/utils/net.py#oldcode288 utils/net.py:288: def get_cacerts_bundle(): This function is now used from ...
11 years, 10 months ago (2014-08-26 23:05:30 UTC) #1
M-A
lgtm https://codereview.appspot.com/131330044/diff/1/utils/tools.py File utils/tools.py (right): https://codereview.appspot.com/131330044/diff/1/utils/tools.py#newcode196 utils/tools.py:196: Python SSL needs a real file on disk, ...
11 years, 10 months ago (2014-08-26 23:13:51 UTC) #2
vadimsh
https://codereview.appspot.com/131330044/diff/1/utils/tools.py File utils/tools.py (right): https://codereview.appspot.com/131330044/diff/1/utils/tools.py#newcode196 utils/tools.py:196: Python SSL needs a real file on disk, so ...
11 years, 10 months ago (2014-08-26 23:25:40 UTC) #3
vadimsh
11 years, 10 months ago (2014-08-26 23:26:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as e7d8b98 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b