Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(334)

Issue 4907041: code review 4907041: builtin: add documentation for builtins (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by r
Modified:
1 month, 1 week ago
Reviewers:
gri, dsymonds, rsc, niemeyer
Visibility:
Public.

Description

builtin: add documentation for builtins Do this by adding a fake package called builtin. At the moment, godoc will not present this documentation because the function names are all lower case, but there are plans to address this. The print and println functions are undocumented here. I could be talked into doing them but I'd rather not promote their use.

Patch Set 1 #

Total comments: 14

Patch Set 2 : diff -r af3bbd9ae031 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r af3bbd9ae031 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : code review 4907041: builtin: add documentation for builtins #

Patch Set 5 : diff -r 27f839c9fae4 https://go.googlecode.com/hg/ #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
A src/pkg/builtin/builtin.go View 1 2 3 4 1 chunk +133 lines, -0 lines 8 comments Download

Messages

Total messages: 26
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 3 months ago (2011-08-15 03:04:19 UTC) #1
dsymonds
http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go#newcode13 src/pkg/builtin/builtin.go:13: // AnyType is here for the purposes of documentation ...
10 years, 3 months ago (2011-08-15 03:19:35 UTC) #2
r
http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go#newcode16 src/pkg/builtin/builtin.go:16: type AnyType int The unsafe package uses "ArbitraryType", which ...
10 years, 3 months ago (2011-08-15 03:31:43 UTC) #3
r
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2011-08-15 03:31:57 UTC) #4
dsymonds
LGTM
10 years, 3 months ago (2011-08-15 03:33:42 UTC) #5
niemeyer
Very nice documentation, thanks! Some minors: http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go#newcode16 src/pkg/builtin/builtin.go:16: type AnyType int ...
10 years, 3 months ago (2011-08-15 03:38:24 UTC) #6
r2
waiting for gri, since he needs to agree to the file location, name, and structure. ...
10 years, 3 months ago (2011-08-15 03:39:06 UTC) #7
r
Hello golang-dev@googlegroups.com, dsymonds@golang.org, n13m3y3r@gmail.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2011-08-15 03:40:53 UTC) #8
niemeyer
Thanks, LGTM
10 years, 3 months ago (2011-08-15 03:44:16 UTC) #9
gri
LGTM I think this is fine for now. I don't care much about the location ...
10 years, 3 months ago (2011-08-15 21:16:48 UTC) #10
rsc
LGTM http://codereview.appspot.com/4907041/diff/9003/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/9003/src/pkg/builtin/builtin.go#newcode19 src/pkg/builtin/builtin.go:19: // for any integer type: int, uint int8 ...
10 years, 3 months ago (2011-08-15 21:23:09 UTC) #11
r
*** Submitted as http://code.google.com/p/go/source/detail?r=27c59a10a156 *** builtin: add documentation for builtins Do this by adding a ...
10 years, 3 months ago (2011-08-15 21:51:52 UTC) #12
dvyukov
http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go#newcode108 src/pkg/builtin/builtin.go:108: // clauses involving c will never execute. Humm... don't ...
10 years, 3 months ago (2011-08-16 04:43:51 UTC) #13
dvyukov
http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go#newcode126 src/pkg/builtin/builtin.go:126: // function (but not any function called by it) ...
10 years, 3 months ago (2011-08-16 04:47:08 UTC) #14
r2
On Aug 16, 2011, at 2:43 PM, dvyukov@google.com wrote: > > http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go > File src/pkg/builtin/builtin.go ...
10 years, 3 months ago (2011-08-16 04:50:07 UTC) #15
r2
On Aug 16, 2011, at 2:47 PM, dvyukov@google.com wrote: > > http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go > File src/pkg/builtin/builtin.go ...
10 years, 3 months ago (2011-08-16 04:56:26 UTC) #16
dvyukov
http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go#newcode49 src/pkg/builtin/builtin.go:49: // Slice, or map: the number of elements in ...
10 years, 3 months ago (2011-08-16 04:57:33 UTC) #17
dvyukov
On 2011/08/16 04:56:26, r2 wrote: > On Aug 16, 2011, at 2:47 PM, mailto:dvyukov@google.com wrote: ...
10 years, 3 months ago (2011-08-16 04:58:36 UTC) #18
dvyukov
On 2011/08/16 04:50:07, r2 wrote: > On Aug 16, 2011, at 2:43 PM, mailto:dvyukov@google.com wrote: ...
10 years, 3 months ago (2011-08-16 05:02:13 UTC) #19
r2
On Aug 16, 2011, at 2:57 PM, dvyukov@google.com wrote: > > http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go > File src/pkg/builtin/builtin.go ...
10 years, 3 months ago (2011-08-16 05:03:02 UTC) #20
dvyukov
On 2011/08/16 05:03:02, r2 wrote: > http://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go#newcode59 > > src/pkg/builtin/builtin.go:59: // Channel: the maximum channel ...
10 years, 3 months ago (2011-08-16 05:11:17 UTC) #21
quinterogq78
https://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): https://codereview.appspot.com/4907041/diff/15001/src/pkg/builtin/builtin.go#newcode49 src/pkg/builtin/builtin.go:49: // Slice, or map: the number of elements in ...
3 months, 1 week ago (2021-08-20 05:59:42 UTC) #22
quinterogq78
3 months, 1 week ago (2021-08-20 05:59:43 UTC) #23
epaz1733
https://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): https://codereview.appspot.com/4907041/diff/1/src/pkg/builtin/builtin.go#newcode16 src/pkg/builtin/builtin.go:16: type AnyType int On 2011/08/15 03:38:24, niemeyer wrote: > ...
1 month, 1 week ago (2021-10-20 08:03:05 UTC) #24
epaz1733
1 month, 1 week ago (2021-10-20 08:03:07 UTC) #25
epaz1733
1 month, 1 week ago (2021-10-20 08:03:08 UTC) #26
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b