Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(955)

Issue 5476044: upload.py -m --message option refactoring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by techtonik
Modified:
1 month, 2 weeks ago
Reviewers:
Andi Albrecht, GvR, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

The proposal to change options of upload.py from: 1. on first submission -m, --message gives an issue a title -d, adds description to an issue 2. on issue update -m, --message gives title to a patchset -d ??? updates description ??? To: 1. on first submission -t, --title issue subject -m, --message issue description -F, --file <file> read description from file 2. on issue update -t, --title new patchset title -m, --message message to reviewers -F, --file <file> read message from file As per discussion at https://groups.google.com/d/topic/codereview-discuss/bPyZSIfVHDY/discussion

Patch Set 1 #

Patch Set 2 : Add -m --message option to describe new issue #

Patch Set 3 : -F --file option to read message from file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M upload.py View 1 2 5 chunks +27 lines, -28 lines 1 comment Download

Messages

Total messages: 9
techtonik
The issue is ready for review, except for the part that should attach a reply ...
8 years, 9 months ago (2011-12-08 23:37:26 UTC) #1
Andi Albrecht
LGTM - and sorry for the delay, this year's final is very busy :) We ...
8 years, 9 months ago (2011-12-15 04:59:41 UTC) #2
techtonik
On 2011/12/15 04:59:41, Andi Albrecht wrote: > LGTM - and sorry for the delay, this ...
8 years, 9 months ago (2011-12-16 09:49:44 UTC) #3
techtonik
Forgot to mention - committed as http://code.google.com/p/rietveld/source/detail?r=1aa64f9a92082f11ea69feb348d268ab3265c1a8
8 years, 9 months ago (2011-12-16 09:51:47 UTC) #4
Andi Albrecht
On Fri, Dec 16, 2011 at 10:49 AM, <techtonik@gmail.com> wrote: > On 2011/12/15 04:59:41, Andi ...
8 years, 9 months ago (2011-12-16 09:53:41 UTC) #5
techtonik
On Fri, Dec 16, 2011 at 12:53 PM, Andi Albrecht < albrecht.andi@googlemail.com> wrote: > On ...
8 years, 9 months ago (2011-12-16 12:31:03 UTC) #6
Andi Albrecht
On Fri, Dec 16, 2011 at 1:30 PM, anatoly techtonik <techtonik@gmail.com> wrote: > On Fri, ...
8 years, 7 months ago (2012-02-21 05:00:22 UTC) #7
techtonik
On Tue, Feb 21, 2012 at 8:00 AM, Andi Albrecht <albrecht.andi@googlemail.com> wrote: >> >> 2. ...
8 years, 7 months ago (2012-02-21 05:15:49 UTC) #8
Andi Albrecht
8 years, 7 months ago (2012-02-21 07:22:33 UTC) #9
On Tue, Feb 21, 2012 at 6:15 AM, anatoly techtonik <techtonik@gmail.com> wrote:
> On Tue, Feb 21, 2012 at 8:00 AM, Andi Albrecht
> <albrecht.andi@googlemail.com> wrote:
>>>
>>> 2. on issue update
>>>    -t, --title new patchset title
>>>    -m, --message message to reviewers
>>>    -F, --file <file> read message from file
>>
>> It seems like my message when updating an issue got lost somewhere.
>> I've called upload.py like this to update an issue:
>>
>> $ ./upload.py -t "Changed keys to arrow keys." -m "Please have another look.
>>> This version is now live at http://rvtests.appspot.com" -i 5685057
--send_mail --rev qparent
>>
>> But the message given by the "-m" option is neither on the issue page
>> nor sent by mail (using upload.py from tip). Or did I miss something?
>
> You're right. Options changed, but I run out of time to see how the
> hook for sending message can be implemented. The pointer about this is
> written in commit message:
>
>
http://code.google.com/p/rietveld/source/detail?r=1aa64f9a92082f11ea69feb348d...
> which leads to
> http://code.google.com/p/rietveld/issues/detail?id=351
>
> And TODO is still here
> http://code.google.com/p/rietveld/source/browse/upload.py#2262

Here's an attempt to fix issue351: http://codereview.appspot.com/5687062

--
Andi

>
> --
> anatoly t.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b