Issue 92360043: code review 92360043: cmd/objdump: import x86 disassembler

Issue 92360043: code review 92360043: cmd/objdump: import x86 disassembler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:
gobot, dave, crawshaw

CC:
crawshaw, jacek.masiulaniec_gmail.com, golang-codereviews

Visibility:
Public.

Description

cmd/objdump: import x86 disassembler The x86 disassembler lives in rsc.io/x86/x86asm for now. We need to figure out what should live where in the long term, but not before the 1.3 release. The completed code reviews for the disassembler are at: https://codereview.appspot.com/95350044 https://codereview.appspot.com/95300044 https://codereview.appspot.com/97100047 https://codereview.appspot.com/93110044 https://codereview.appspot.com/99000043 https://codereview.appspot.com/98990043

Patch Set 1 #

Patch Set 2 : diff -r 391d6d71c738 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 391d6d71c738 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 6ff6e005e7a6 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 6ff6e005e7a6 https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13805 lines, -0 lines)			Patch
	A	src/cmd/objdump/Makefile	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	A	src/cmd/objdump/x86.go	View	1 2 3 4	1 chunk	+13800 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rsc

Hello crawshaw (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-05-14 18:33:24 UTC) #1

jacekm

https://codereview.appspot.com/92360043/diff/20002/src/cmd/objdump/x86.go File src/cmd/objdump/x86.go (right): https://codereview.appspot.com/92360043/diff/20002/src/cmd/objdump/x86.go#newcode2665 src/cmd/objdump/x86.go:2665: // If an instruction does has fewer than 4 ...

11 years, 1 month ago (2014-05-14 19:40:32 UTC) #3

rsc

11 years, 1 month ago (2014-05-14 23:46:12 UTC) #4

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=ab46827fd5f7 *** cmd/objdump: import x86 disassembler The x86 disassembler lives in rsc.io/x86/x86asm ...

11 years, 1 month ago (2014-05-14 23:46:47 UTC) #5

gobot

This CL appears to have broken the linux-arm-arm5 builder. See http://build.golang.org/log/6a98c6b5bdc02e738ae9075c517fbc74c9679cf2

11 years, 1 month ago (2014-05-15 03:30:11 UTC) #6

dave_cheney.net

11 years, 1 month ago (2014-05-15 03:31:45 UTC) #7

Sorry, the builder crashed. It has been more stable now the weather is
cooler, but it is still not 100% reliable.

On Thu, May 15, 2014 at 1:30 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-arm5 builder.
> See http://build.golang.org/log/6a98c6b5bdc02e738ae9075c517fbc74c9679cf2
>
>
> https://codereview.appspot.com/92360043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Expand All Messages | Collapse All Messages