Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 95350044: code review 95350044: x86asm: add Plan 9 output for objdump (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by rsc
Modified:
8 years, 3 months ago
Reviewers:
crawshaw
CC:
crawshaw
Visibility:
Public.

Description

x86asm: add Plan 9 output for objdump Not heavily tested but basically looks right. It's certainly more reliable than the libmach version.

Patch Set 1 #

Patch Set 2 : diff -r 776945181ffa https://code.google.com/p/rsc.x86/ #

Patch Set 3 : diff -r 776945181ffa https://code.google.com/p/rsc.x86/ #

Patch Set 4 : diff -r 776945181ffa https://code.google.com/p/rsc.x86/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9371 lines, -2523 lines) Patch
M x86asm/decode.go View 1 2 8 chunks +14 lines, -14 lines 0 comments Download
M x86asm/decode_test.go View 1 2 3 4 chunks +13 lines, -5 lines 0 comments Download
M x86asm/ext_test.go View 1 2 3 6 chunks +9 lines, -7 lines 0 comments Download
M x86asm/inst.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A x86asm/plan9ext_test.go View 1 2 1 chunk +119 lines, -0 lines 0 comments Download
A x86asm/plan9x.go View 1 2 1 chunk +346 lines, -0 lines 0 comments Download
A x86asm/plan9x_test.go View 1 1 chunk +54 lines, -0 lines 0 comments Download
M x86asm/testdata/Makefile View 1 2 3 1 chunk +7 lines, -3 lines 0 comments Download
M x86asm/testdata/decode.txt View 1 2 3 1 chunk +6731 lines, -2493 lines 0 comments Download
A x86asm/testdata/libmach8db.c View 1 2 1 chunk +2075 lines, -0 lines 0 comments Download
M x86asm/xed_test.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M x86map/map.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/
8 years, 3 months ago (2014-05-13 19:25:58 UTC) #1
rsc
Last x86asm chunk for 1.3 excluding bug fixes.
8 years, 3 months ago (2014-05-13 19:26:46 UTC) #2
crawshaw
LGTM
8 years, 3 months ago (2014-05-13 21:59:39 UTC) #3
rsc
8 years, 3 months ago (2014-05-14 18:30:26 UTC) #4
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=5cb3bdbcaa11&repo=x86 ***

x86asm: add Plan 9 output for objdump

Not heavily tested but basically looks right.
It's certainly more reliable than the libmach version.

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/95350044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b