Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 95300044: code review 95300044: x86asm: basic 64-bit mode decoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by rsc
Modified:
8 years, 3 months ago
Reviewers:
crawshaw
CC:
crawshaw
Visibility:
Public.

Description

x86asm: basic 64-bit mode decoding It's not a perfect match for objdump or xed yet, but it's close enough for now.

Patch Set 1 #

Patch Set 2 : diff -r 27604273fc7c https://code.google.com/p/rsc.x86/ #

Patch Set 3 : diff -r 27604273fc7c https://code.google.com/p/rsc.x86/ #

Patch Set 4 : diff -r 27604273fc7c https://code.google.com/p/rsc.x86/ #

Patch Set 5 : diff -r 27604273fc7c https://code.google.com/p/rsc.x86/ #

Total comments: 10

Patch Set 6 : diff -r 27604273fc7c https://code.google.com/p/rsc.x86/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8648 lines, -8218 lines) Patch
M x86.csv View 1 29 chunks +80 lines, -58 lines 0 comments Download
M x86asm/Makefile View 1 1 chunk +2 lines, -1 line 0 comments Download
M x86asm/decode.go View 1 2 3 4 5 22 chunks +150 lines, -27 lines 0 comments Download
M x86asm/ext_test.go View 1 2 11 chunks +111 lines, -9 lines 0 comments Download
M x86asm/gnu.go View 1 13 chunks +59 lines, -26 lines 0 comments Download
M x86asm/inst.go View 1 4 chunks +18 lines, -2 lines 0 comments Download
M x86asm/intel.go View 1 15 chunks +86 lines, -18 lines 0 comments Download
M x86asm/objdump_test.go View 1 2 1 chunk +30 lines, -10 lines 0 comments Download
M x86asm/objdumpext_test.go View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M x86asm/tables.go View 1 16 chunks +8032 lines, -8038 lines 0 comments Download
M x86asm/testdata/Makefile View 1 1 chunk +4 lines, -0 lines 0 comments Download
M x86asm/xed_test.go View 1 2 3 chunks +14 lines, -13 lines 0 comments Download
M x86map/map.go View 1 2 3 4 5 5 chunks +49 lines, -14 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/
8 years, 3 months ago (2014-05-12 15:24:31 UTC) #1
crawshaw
LGTM, one tiny (I hope) question in decode.go. https://codereview.appspot.com/95300044/diff/70001/x86asm/decode.go File x86asm/decode.go (right): https://codereview.appspot.com/95300044/diff/70001/x86asm/decode.go#newcode562 x86asm/decode.go:562: // ...
8 years, 3 months ago (2014-05-12 17:17:57 UTC) #2
rsc
Thanks. https://codereview.appspot.com/95300044/diff/70001/x86asm/decode.go File x86asm/decode.go (right): https://codereview.appspot.com/95300044/diff/70001/x86asm/decode.go#newcode562 x86asm/decode.go:562: // In 64-bit, mod=0 rm=5 is PC-relative instead ...
8 years, 3 months ago (2014-05-13 16:23:04 UTC) #3
rsc
8 years, 3 months ago (2014-05-13 16:23:28 UTC) #4
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=776945181ffa&repo=x86 ***

x86asm: basic 64-bit mode decoding

It's not a perfect match for objdump or xed yet,
but it's close enough for now.

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/95300044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b