Issue 97100047: code review 97100047: x86asm: GNUSyntax, IntelSyntax, and tests against objdu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97100047: code review 97100047: x86asm: GNUSyntax, IntelSyntax, and tests against objdu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by rsc

Modified:
9 years, 11 months ago

Reviewers:
crawshaw

CC:
crawshaw

Visibility:
Public.

Description

x86asm: GNUSyntax, IntelSyntax, and tests against objdump, xed

Patch Set 2 : diff -r 66b21e781a9a https://code.google.com/p/rsc.x86/ #

Total comments: 1

Patch Set 3 : diff -r 074e342086e6 https://code.google.com/p/rsc.x86/ #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3129 lines, -0 lines)			Patch
A	x86asm/ext_test.go	View	1	1 chunk	+707 lines, -0 lines	0 comments	Download
A	x86asm/gnu.go	View	1	1 chunk	+893 lines, -0 lines	0 comments	Download
A	x86asm/intel.go	View	1 2	1 chunk	+450 lines, -0 lines	0 comments	Download
A	x86asm/objdump_test.go	View	1	1 chunk	+363 lines, -0 lines	0 comments	Download
A	x86asm/objdumpext_test.go	View	1	1 chunk	+302 lines, -0 lines	0 comments	Download
A	x86asm/xed_test.go	View	1 2	1 chunk	+209 lines, -0 lines	0 comments	Download
A	x86asm/xedext_test.go	View	1 2	1 chunk	+205 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/

9 years, 11 months ago (2014-05-08 03:35:22 UTC) #1

rsc

I almost just submitted this TBR=rsc. I don't expect you to look at any of ...

9 years, 11 months ago (2014-05-08 03:36:22 UTC) #2

crawshaw

LGTM https://codereview.appspot.com/97100047/diff/20001/x86asm/gnu.go File x86asm/gnu.go (right): https://codereview.appspot.com/97100047/diff/20001/x86asm/gnu.go#newcode314 x86asm/gnu.go:314: // I can't explain any of this, but ...

9 years, 11 months ago (2014-05-08 11:46:12 UTC) #3

rsc

9 years, 11 months ago (2014-05-08 13:55:34 UTC) #4

*** Submitted as
https://code.google.com/p/rsc/source/detail?r=27604273fc7c&repo=x86 ***

x86asm: GNUSyntax, IntelSyntax, and tests against objdump, xed

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/97100047

Expand All Messages | Collapse All Messages