Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 97100047: code review 97100047: x86asm: GNUSyntax, IntelSyntax, and tests against objdu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by rsc
Modified:
8 years, 3 months ago
Reviewers:
crawshaw
CC:
crawshaw
Visibility:
Public.

Description

x86asm: GNUSyntax, IntelSyntax, and tests against objdump, xed

Patch Set 1 #

Patch Set 2 : diff -r 66b21e781a9a https://code.google.com/p/rsc.x86/ #

Total comments: 1

Patch Set 3 : diff -r 074e342086e6 https://code.google.com/p/rsc.x86/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3129 lines, -0 lines) Patch
A x86asm/ext_test.go View 1 1 chunk +707 lines, -0 lines 0 comments Download
A x86asm/gnu.go View 1 1 chunk +893 lines, -0 lines 0 comments Download
A x86asm/intel.go View 1 2 1 chunk +450 lines, -0 lines 0 comments Download
A x86asm/objdump_test.go View 1 1 chunk +363 lines, -0 lines 0 comments Download
A x86asm/objdumpext_test.go View 1 1 chunk +302 lines, -0 lines 0 comments Download
A x86asm/xed_test.go View 1 2 1 chunk +209 lines, -0 lines 0 comments Download
A x86asm/xedext_test.go View 1 2 1 chunk +205 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/
8 years, 3 months ago (2014-05-08 03:35:22 UTC) #1
rsc
I almost just submitted this TBR=rsc. I don't expect you to look at any of ...
8 years, 3 months ago (2014-05-08 03:36:22 UTC) #2
crawshaw
LGTM https://codereview.appspot.com/97100047/diff/20001/x86asm/gnu.go File x86asm/gnu.go (right): https://codereview.appspot.com/97100047/diff/20001/x86asm/gnu.go#newcode314 x86asm/gnu.go:314: // I can't explain any of this, but ...
8 years, 3 months ago (2014-05-08 11:46:12 UTC) #3
rsc
8 years, 3 months ago (2014-05-08 13:55:34 UTC) #4
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=27604273fc7c&repo=x86 ***

x86asm: GNUSyntax, IntelSyntax, and tests against objdump, xed

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/97100047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b