Issue 98990043: code review 98990043: x86asm: instruction definition

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98990043: code review 98990043: x86asm: instruction definition (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rsc

Modified:
11 years ago

Reviewers:
crawshaw

CC:
crawshaw

Visibility:
Public.

Patch Set 2 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Patch Set 3 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Total comments: 2

Patch Set 4 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+596 lines, -0 lines)			Patch
	A	x86asm/inst.go	View	1 2 3	1 chunk	+576 lines, -0 lines	0 comments	Download
	A	x86asm/inst_test.go	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/

11 years ago (2014-05-07 05:09:55 UTC) #1

crawshaw

LGTM It would be easy to add a test that regNames is a complete mapping ...

11 years ago (2014-05-07 13:14:06 UTC) #2

rsc

I added the test you suggested. https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go File x86asm/inst.go (right): https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go#newcode375 x86asm/inst.go:375: return fmt.Sprintf("$%#x", int64(i)) ...

11 years ago (2014-05-07 15:16:28 UTC) #3

rsc

11 years ago (2014-05-07 15:16:45 UTC) #4

*** Submitted as
https://code.google.com/p/rsc/source/detail?r=8f07e70e2550&repo=x86 ***

x86asm: instruction definition

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/98990043

Expand All Messages | Collapse All Messages