Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 98990043: code review 98990043: x86asm: instruction definition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by rsc
Modified:
8 years, 3 months ago
Reviewers:
crawshaw
CC:
crawshaw
Visibility:
Public.

Description

x86asm: instruction definition

Patch Set 1 #

Patch Set 2 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Patch Set 3 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Total comments: 2

Patch Set 4 : diff -r 876d94cecc2e https://code.google.com/p/rsc.x86/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -0 lines) Patch
A x86asm/inst.go View 1 2 3 1 chunk +576 lines, -0 lines 0 comments Download
A x86asm/inst_test.go View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello crawshaw, I'd like you to review this change to https://code.google.com/p/rsc.x86/
8 years, 3 months ago (2014-05-07 05:09:55 UTC) #1
crawshaw
LGTM It would be easy to add a test that regNames is a complete mapping ...
8 years, 3 months ago (2014-05-07 13:14:06 UTC) #2
rsc
I added the test you suggested. https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go File x86asm/inst.go (right): https://codereview.appspot.com/98990043/diff/40001/x86asm/inst.go#newcode375 x86asm/inst.go:375: return fmt.Sprintf("$%#x", int64(i)) ...
8 years, 3 months ago (2014-05-07 15:16:28 UTC) #3
rsc
8 years, 3 months ago (2014-05-07 15:16:45 UTC) #4
*** Submitted as
https://code.google.com/p/rsc/source/detail?r=8f07e70e2550&repo=x86 ***

x86asm: instruction definition

LGTM=crawshaw
R=crawshaw
https://codereview.appspot.com/98990043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b