Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 7761043: Make generator common code depend only upon constants. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by usrbincc
Modified:
12 years, 3 months ago
Reviewers:
peterhal, slightlylate, arv
CC:
traceur-compiler-reviews_googlegroups.com
Base URL:
https://code.google.com/p/traceur-compiler/@master
Visibility:
Public.

Description

Make generator common code depend only upon constants. It turns out that we don't have to set $state to machineEndState, since $GState already guards against $moveNext being inadvertently called after generator end. BUG=None TEST=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/codegeneration/generator/CPSTransformer.js View 1 chunk +0 lines, -2 lines 0 comments Download
M src/codegeneration/generator/GeneratorTransformer.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2
usrbincc
Patch order at a glance: Make generator common code depend only upon constants. https://codereview.appspot.com/7761043 Use ...
12 years, 3 months ago (2013-03-13 21:56:01 UTC) #1
arv
12 years, 3 months ago (2013-03-13 22:13:07 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b