Issue 7547046: Minimal diff for converting generator interface wrap to a function.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7547046: Minimal diff for converting generator interface wrap to a function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by usrbincc

Modified:
12 years, 3 months ago

Reviewers:
arv

CC:
traceur-compiler-reviews_googlegroups.com

Base URL:
https://code.google.com/p/traceur-compiler/@master

Visibility:
Public.

More Reviews

Description

Minimal diff for converting generator interface wrap to a function. This is setting up the final version using RuntimeInliner. BUG=None TEST=None

Patch Set 2 : Reindented. #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -67 lines)			Patch
	M	src/codegeneration/generator/GeneratorTransformer.js	View	1	1 chunk	+70 lines, -67 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

arv

LGTM https://codereview.appspot.com/7547046/diff/1/src/codegeneration/generator/GeneratorTransformer.js File src/codegeneration/generator/GeneratorTransformer.js (right): https://codereview.appspot.com/7547046/diff/1/src/codegeneration/generator/GeneratorTransformer.js#newcode238 src/codegeneration/generator/GeneratorTransformer.js:238: return { reindent?

12 years, 3 months ago (2013-03-13 22:26:54 UTC) #1

usrbincc

12 years, 3 months ago (2013-03-14 20:53:13 UTC) #2

Reindented.

The diff is a little noisy because I merged in the previous code review
changes. Things don't merge well during reindents, so I had to manually
fix some things. One area git needs to improve on.

----

Patch order at a glance:

Make generator common code depend only upon constants.
https://codereview.appspot.com/7761043
Use generator 'return' to simplify the code for 'close()'
https://codereview.appspot.com/7519046
Checking undefined properties is slow, so cache in a boolean.
https://codereview.appspot.com/7663044
Use an inner object instead of captured vars.
https://codereview.appspot.com/7547045
Minimal diff for converting generator interface wrap to a function.
https://codereview.appspot.com/7547046
Use RuntimeInliner to provide the generator common code.
https://codereview.appspot.com/7487046

Expand All Messages | Collapse All Messages