Use an inner object instead of captured vars.

Use an inner object instead of captured vars.

- This will facilitate factoring out common generator code into a
  function later.
- Also, remove redundant GSTATE assignment in machineEndStatements.

BUG=None
TEST=None

[arv, 2013-03-13 22:25:18]

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Ge...
File src/codegeneration/generator/GeneratorTransformer.js (right):

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Ge...
src/codegeneration/generator/GeneratorTransformer.js:221: ${GSTATE}:
${ST_NEWBORN},
Now we don't really need placeholders for the key names. Just do:

var ${G} = {
  state: ...,
  current: ....,
  yieldReturn: ...,
  moveNext: ...
};

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Yi...
File src/codegeneration/generator/YieldState.js (right):

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Yi...
src/codegeneration/generator/YieldState.js:64: // this.$current = expression;
What is this here? I guess I should apply the patch and see what is generated.

[usrbincc, 2013-03-14 20:43:28]

Note: As a matter of principle and convenience (reviewers and me alike),
I'm just making sure there's one copy in every patch in the series.

Patch order at a glance:

Make generator common code depend only upon constants.
https://codereview.appspot.com/7761043
Use generator 'return' to simplify the code for 'close()'
https://codereview.appspot.com/7519046
Checking undefined properties is slow, so cache in a boolean.
https://codereview.appspot.com/7663044
Use an inner object instead of captured vars.
https://codereview.appspot.com/7547045
Minimal diff for converting generator interface wrap to a function.
https://codereview.appspot.com/7547046
Use RuntimeInliner to provide the generator common code.
https://codereview.appspot.com/7487046

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Yi...
File src/codegeneration/generator/YieldState.js (right):

https://codereview.appspot.com/7547045/diff/1/src/codegeneration/generator/Yi...
src/codegeneration/generator/YieldState.js:64: // this.$current = expression;
On 2013/03/13 22:25:18, arv-chromium wrote:
> What is this here? I guess I should apply the patch and see what is generated.

It's the inner 'G' object.

https://codereview.appspot.com/7547045/diff/5001/src/codegeneration/generator...
File src/codegeneration/generator/GeneratorTransformer.js (left):

https://codereview.appspot.com/7547045/diff/5001/src/codegeneration/generator...
src/codegeneration/generator/GeneratorTransformer.js:326:
createAssignStateStatement(machineEndState),
Strictly speaking, this isn't necessary either, but removing this makes
the state machine state incomplete unless you also refer to outer GState.

https://codereview.appspot.com/7547045/diff/5001/src/codegeneration/generator...
File src/codegeneration/generator/GeneratorTransformer.js (right):

https://codereview.appspot.com/7547045/diff/5001/src/codegeneration/generator...
src/codegeneration/generator/GeneratorTransformer.js:220: GState: ${ST_NEWBORN},
We have '$state' already, and there are a few places that would just
have 'this.state' without 'GState', so retained the 'G' for clarity.
Overly paranoid?

[arv, 2013-03-14 22:10:41]

LGTM

[arv, 2013-03-14 22:12:02]

Seems like all of them are LGTM'ed now... I'll try to commit them