Checking undefined properties is slow, so cache in a boolean.

Checking undefined properties is slow, so cache in a boolean.

BUG=None
TEST=None

[arv, 2013-03-13 22:19:56]

https://codereview.appspot.com/7663044/diff/1/src/codegeneration/GeneratorTra...
File src/codegeneration/GeneratorTransformPass.js (right):

https://codereview.appspot.com/7663044/diff/1/src/codegeneration/GeneratorTra...
src/codegeneration/GeneratorTransformPass.js:268: var ${isGeneratorObject} =
!!${g}.send;
no need for the !! here. This is not returned so it does not matter if it is a
boolean or not.

[usrbincc, 2013-03-14 19:31:14]

Removed '!!'.

----

Patch order at a glance:

Make generator common code depend only upon constants.
https://codereview.appspot.com/7761043
Use generator 'return' to simplify the code for 'close()'
https://codereview.appspot.com/7519046
Checking undefined properties is slow, so cache in a boolean.
https://codereview.appspot.com/7663044
Use an inner object instead of captured vars.
https://codereview.appspot.com/7547045
Minimal diff for converting generator interface wrap to a function.
https://codereview.appspot.com/7547046
Use RuntimeInliner to provide the generator common code.
https://codereview.appspot.com/7487046

----

https://codereview.appspot.com/7663044/diff/1/src/codegeneration/GeneratorTra...
File src/codegeneration/GeneratorTransformPass.js (right):

https://codereview.appspot.com/7663044/diff/1/src/codegeneration/GeneratorTra...
src/codegeneration/GeneratorTransformPass.js:268: var ${isGeneratorObject} =
!!${g}.send;
You know, I was under some vague impression that V8 would optimize better
if it was always a boolean, but I did a quick benchmark, and there is no
difference.

I tried hoisting the variable and making two separate loops, but it was
actually slower. This is definitely faster in normal JS, but once you do
the state machine transformation, everything gets morphed into this
bizzaro world where everything must be verified.

[arv, 2013-03-14 19:51:19]

LGTM with nit.

Do you want me to start submitting these in the order you specified? I was
planning on waiting until all of them we LGTM'ed.

https://codereview.appspot.com/7663044/diff/3001/src/codegeneration/Generator...
File src/codegeneration/GeneratorTransformPass.js (right):

https://codereview.appspot.com/7663044/diff/3001/src/codegeneration/Generator...
src/codegeneration/GeneratorTransformPass.js:230: var [g, next,
isGeneratorObject] = [
Can you change this to:

var g = ...
var next = ...
var isGeneratorObject = ...

[usrbincc, 2013-03-14 20:30:40]

Removed overly-fancy var declaration. Kept the 'id' because it's
shorter. The procedural api is scary.

On 2013/03/14 19:51:19, arv-chromium wrote:
> LGTM with nit.
>
> Do you want me to start submitting these in the order you specified? I was
> planning on waiting until all of them we LGTM'ed.

It's probably easier to keep track of, applying them all in a row, so
waiting works for me. It doesn't really block any future work, since git
merge is usually pretty good.