Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2264)

Issue 4961053: Blender Cucumber to Trunk

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Kupoman
Modified:
9 years, 8 months ago
Reviewers:
dfelinto, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Patch Set 1 #

Total comments: 18

Patch Set 2 : Fixes to crashing DDS mipmaps, leaking dyn lights, and some review comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2784 lines, -1406 lines) Patch
M doc/python_api/rst/bge.types.rst View 1 2 chunks +13 lines, -1 line 0 comments Download
M intern/ghost/GHOST_ISystem.h View 1 1 chunk +1 line, -1 line 0 comments Download
M intern/ghost/intern/GHOST_System.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M intern/ghost/intern/GHOST_System.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M release/scripts/startup/bl_operators/wm.py View 1 2 chunks +18 lines, -0 lines 0 comments Download
M release/scripts/startup/bl_ui/properties_game.py View 1 9 chunks +147 lines, -32 lines 0 comments Download
M release/scripts/startup/bl_ui/properties_render.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M release/scripts/startup/bl_ui/properties_scene.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M release/scripts/startup/bl_ui/space_logic.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M source/blender/blenkernel/intern/object.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M source/blender/blenloader/intern/readfile.c View 1 1 chunk +14 lines, -0 lines 0 comments Download
M source/blender/gpu/CMakeLists.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M source/blender/gpu/GPU_draw.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/blender/gpu/GPU_material.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M source/blender/gpu/SConscript View 1 1 chunk +3 lines, -0 lines 0 comments Download
M source/blender/gpu/intern/gpu_draw.c View 1 5 chunks +84 lines, -12 lines 0 comments Download
M source/blender/gpu/intern/gpu_material.c View 1 5 chunks +20 lines, -6 lines 0 comments Download
M source/blender/imbuf/IMB_imbuf_types.h View 1 3 chunks +33 lines, -1 line 0 comments Download
M source/blender/imbuf/intern/allocimbuf.c View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/blender/imbuf/intern/dds/DirectDrawSurface.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M source/blender/imbuf/intern/dds/DirectDrawSurface.cpp View 1 3 chunks +27 lines, -1 line 0 comments Download
M source/blender/imbuf/intern/dds/dds_api.cpp View 1 2 chunks +11 lines, -1 line 0 comments Download
M source/blender/makesdna/DNA_object_types.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M source/blender/makesdna/DNA_scene_types.h View 1 2 chunks +18 lines, -3 lines 1 comment Download
M source/blender/makesrna/intern/rna_object.c View 1 3 chunks +72 lines, -0 lines 0 comments Download
M source/blender/makesrna/intern/rna_scene.c View 1 5 chunks +81 lines, -0 lines 0 comments Download
M source/gameengine/BlenderRoutines/BL_KetsjiEmbedStart.cpp View 1 3 chunks +7 lines, -10 lines 0 comments Download
M source/gameengine/BlenderRoutines/KX_BlenderInputDevice.h View 1 2 chunks +4 lines, -166 lines 0 comments Download
M source/gameengine/BlenderRoutines/KX_BlenderKeyboardDevice.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M source/gameengine/BlenderRoutines/KX_BlenderKeyboardDevice.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M source/gameengine/Converter/BL_BlenderDataConversion.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M source/gameengine/Converter/BL_BlenderDataConversion.cpp View 1 14 chunks +239 lines, -68 lines 0 comments Download
M source/gameengine/Converter/KX_BlenderSceneConverter.cpp View 1 3 chunks +12 lines, -0 lines 0 comments Download
M source/gameengine/Converter/KX_ConvertSensors.cpp View 1 3 chunks +4 lines, -178 lines 0 comments Download
M source/gameengine/GamePlayer/common/GPC_KeyboardDevice.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M source/gameengine/GamePlayer/ghost/GPG_Application.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/gameengine/GamePlayer/ghost/GPG_Application.cpp View 1 6 chunks +21 lines, -20 lines 0 comments Download
M source/gameengine/GamePlayer/ghost/GPG_ghost.cpp View 1 5 chunks +14 lines, -2 lines 0 comments Download
M source/gameengine/Ketsji/BL_BlenderShader.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download
M source/gameengine/Ketsji/BL_Material.h View 1 1 chunk +3 lines, -10 lines 0 comments Download
M source/gameengine/Ketsji/BL_Material.cpp View 1 2 chunks +15 lines, -28 lines 0 comments Download
M source/gameengine/Ketsji/BL_Texture.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M source/gameengine/Ketsji/BL_Texture.cpp View 1 3 chunks +66 lines, -1 line 0 comments Download
M source/gameengine/Ketsji/CMakeLists.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_BlenderMaterial.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M source/gameengine/Ketsji/KX_ConvertPhysicsObject.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_ConvertPhysicsObjects.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M source/gameengine/Ketsji/KX_FontObject.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M source/gameengine/Ketsji/KX_FontObject.cpp View 1 4 chunks +75 lines, -4 lines 0 comments Download
M source/gameengine/Ketsji/KX_GameObject.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_GameObject.cpp View 1 5 chunks +146 lines, -2 lines 0 comments Download
M source/gameengine/Ketsji/KX_KetsjiEngine.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_KetsjiEngine.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_Light.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_Light.cpp View 1 7 chunks +158 lines, -2 lines 0 comments Download
M source/gameengine/Ketsji/KX_PythonInit.cpp View 1 2 chunks +16 lines, -0 lines 0 comments Download
M source/gameengine/Ketsji/KX_Scene.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M source/gameengine/Ketsji/KX_VertexProxy.cpp View 1 9 chunks +20 lines, -28 lines 0 comments Download
M source/gameengine/Physics/Bullet/CcdPhysicsController.h View 1 1 chunk +1 line, -0 lines 1 comment Download
M source/gameengine/Physics/Bullet/CcdPhysicsEnvironment.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_IRasterizer.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_LightObject.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M source/gameengine/Rasterizer/RAS_MaterialBucket.cpp View 1 4 chunks +6 lines, -4 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_MeshObject.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_MeshObject.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_OpenGLRasterizer/CMakeLists.txt View 1 1 chunk +7 lines, -2 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_IStorage.h View 1 1 chunk +64 lines, -0 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_ListRasterizer.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_ListRasterizer.cpp View 1 4 chunks +8 lines, -30 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_OpenGLRasterizer.h View 1 4 chunks +8 lines, -4 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_OpenGLRasterizer.cpp View 1 11 chunks +44 lines, -249 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageIM.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageIM.cpp View 1 1 chunk +308 lines, -0 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageVA.h View 1 1 chunk +79 lines, -0 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageVA.cpp View 1 chunk +321 lines, -0 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageVBO.h View 1 1 chunk +104 lines, -0 lines 0 comments Download
A source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_StorageVBO.cpp View 1 1 chunk +277 lines, -0 lines 0 comments Download
D source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_VAOpenGLRasterizer.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
D source/gameengine/Rasterizer/RAS_OpenGLRasterizer/RAS_VAOpenGLRasterizer.cpp View 1 1 chunk +0 lines, -385 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_TexVert.h View 1 4 chunks +9 lines, -17 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_TexVert.cpp View 1 5 chunks +13 lines, -13 lines 0 comments Download
M source/gameengine/Rasterizer/RAS_texmatrix.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M source/gameengine/VideoTexture/blendVideoTex.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfelinto
first batch of review. I stopped right after KX_Font and KX_KetsjiEngine. next I will review ...
10 years ago (2011-09-01 09:37:16 UTC) #1
Kupoman
Addressed a few of the comments from Dalai. http://codereview.appspot.com/4961053/diff/1/release/scripts/startup/bl_ui/properties_scene.py File release/scripts/startup/bl_ui/properties_scene.py (right): http://codereview.appspot.com/4961053/diff/1/release/scripts/startup/bl_ui/properties_scene.py#newcode37 release/scripts/startup/bl_ui/properties_scene.py:37: bl_label ...
10 years ago (2011-09-08 05:46:32 UTC) #2
dfelinto
just noticed a big problem in the DNA changes. http://codereview.appspot.com/4961053/diff/7001/source/blender/makesdna/DNA_scene_types.h File source/blender/makesdna/DNA_scene_types.h (right): http://codereview.appspot.com/4961053/diff/7001/source/blender/makesdna/DNA_scene_types.h#newcode443 source/blender/makesdna/DNA_scene_types.h:443: ...
10 years ago (2011-09-13 17:54:14 UTC) #3
dfelinto
9 years, 8 months ago (2012-01-04 11:00:39 UTC) #4
small comment on collision mask code

http://codereview.appspot.com/4961053/diff/7001/source/gameengine/Physics/Bul...
File source/gameengine/Physics/Bullet/CcdPhysicsController.h (right):

http://codereview.appspot.com/4961053/diff/7001/source/gameengine/Physics/Bul...
source/gameengine/Physics/Bullet/CcdPhysicsController.h:224: UserFilter = 1<<8 |
1<<9 | 1<<10 | 1<<11 | 1<<12 | 1<<13 | 1<<14 | 1<<15,
why those hardcoded values, what do they relate to?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b