Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1712)

Issue 359780043: WIP for IO

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by ajuma
Modified:
1 day, 4 hours ago
Reviewers:
Visibility:
Public.

Description

WIP for IO Based on a patch originally by smfr, with contributions by vollick BUG=

Patch Set 1 #

Patch Set 2 : Fixed root parsing #

Patch Set 3 : Cleaned up root parsing #

Patch Set 4 : Computed root bounds correctly. Now 13/24 WPTs pass #

Patch Set 5 : Now pass 15 out of 24 WPTs #

Patch Set 6 : Make containing block test pass #

Patch Set 7 : 20 tests pass #

Patch Set 8 : Finish fixing zero-area intersection #

Patch Set 9 : 21 of 25 now pass #

Patch Set 10 : Fixed existing layout tests #

Patch Set 11 : 22 tests pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3214 lines, -77 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/imported/w3c/ChangeLog View 1 2 3 4 5 6 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box.html View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/client-rect.html View 1 2 3 4 5 6 7 8 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/client-rect-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block.html View 1 2 3 4 5 6 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe.html View 1 2 3 4 5 6 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/disconnect.html View 1 2 3 4 5 6 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/disconnect-expected.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/display-none.html View 1 2 3 4 5 6 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/display-none-expected.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/edge-inclusive-intersection.html View 1 2 3 4 5 6 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root.html View 1 2 3 4 5 6 1 chunk +71 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/isIntersecting-change-events.html View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-targets.html View 1 2 3 4 5 6 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-targets-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-thresholds.html View 1 2 3 4 5 6 1 chunk +96 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-thresholds-expected.txt View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-attributes.html View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-attributes-expected.txt View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-exceptions.html View 1 2 3 4 5 6 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-exceptions-expected.txt View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-in-iframe.html View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-without-js-reference.html View 1 2 3 4 5 6 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/remove-element.html View 1 2 3 4 5 6 1 chunk +82 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/remove-element-expected.txt View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/cross-origin-subframe.html View 1 2 3 4 5 6 1 chunk +125 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/iframe-no-root-subframe.html View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/intersection-observer-test-utils.js View 1 2 3 4 5 6 1 chunk +127 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/observer-in-iframe-subframe.html View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/resources/timestamp-subframe.html View 1 2 3 4 5 6 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-margin.html View 1 2 3 4 5 6 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-margin-expected.txt View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-no-root.html View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-no-root-expected.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-root.html View 1 2 3 4 5 6 1 chunk +90 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-root-expected.txt View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-zero-size-target.html View 1 2 3 4 5 6 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/shadow-content.html View 1 2 3 4 5 6 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/shadow-content-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/text-target.html View 1 2 3 4 5 6 7 8 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/text-target-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/timestamp.html View 1 2 3 4 5 6 1 chunk +99 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/timestamp-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/unclipped-root.html View 1 2 3 4 5 6 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/unclipped-root-expected.txt View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-hidden.html View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-visible.html View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/intersection-observer/intersection-observer-entry-interface.html View 1 2 3 4 5 6 7 8 9 3 chunks +11 lines, -2 lines 0 comments Download
M LayoutTests/intersection-observer/intersection-observer-entry-interface-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/intersection-observer/intersection-observer-interface.html View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -4 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +98 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.h View 4 chunks +22 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 6 chunks +327 lines, -1 line 0 comments Download
M Source/WebCore/dom/Element.h View 4 chunks +25 lines, -5 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 4 chunks +87 lines, -0 lines 0 comments Download
M Source/WebCore/dom/ElementRareData.h View 3 chunks +10 lines, -0 lines 0 comments Download
M Source/WebCore/dom/ElementRareData.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.h View 1 2 3 4 5 6 7 2 chunks +34 lines, -10 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +153 lines, -6 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.idl View 2 chunks +4 lines, -1 line 0 comments Download
M Source/WebCore/page/IntersectionObserverEntry.h View 4 chunks +11 lines, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserverEntry.cpp View 2 chunks +32 lines, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserverEntry.idl View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/Logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.cpp View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutRect.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutRect.cpp View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBlock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBlock.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 2 3 4 5 6 4 chunks +18 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/RenderInline.cpp View 1 2 3 4 5 6 3 chunks +14 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 2 3 4 5 6 1 chunk +6 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 2 3 4 5 6 1 chunk +8 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGForeignObject.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGInline.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGInline.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGModelObject.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGRoot.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGRoot.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGText.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGText.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/SVGRenderSupport.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/ChangeLog View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/WebPreferences.yaml View 2 chunks +9 lines, -8 lines 0 comments Download
M Tools/ChangeLog View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/mac/DumpRenderTree.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/WebKitTestRunner/TestController.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b