Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 359780043: WIP for IO

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ajuma
Modified:
1 month, 1 week ago
Reviewers:
Visibility:
Public.

Description

WIP for IO Based on a patch originally by smfr, with contributions by vollick BUG=

Patch Set 1 #

Patch Set 2 : Fixed root parsing #

Patch Set 3 : Cleaned up root parsing #

Patch Set 4 : Computed root bounds correctly. Now 13/24 WPTs pass #

Patch Set 5 : Now pass 15 out of 24 WPTs #

Patch Set 6 : Make containing block test pass #

Patch Set 7 : 20 tests pass #

Patch Set 8 : Finish fixing zero-area intersection #

Patch Set 9 : 21 of 25 now pass #

Patch Set 10 : Fixed existing layout tests #

Patch Set 11 : 22 tests pass #

Patch Set 12 : Passes 24 out of 25 tests #

Patch Set 13 : Passes all WPTs. Starting on making rootBounds nullable #

Patch Set 14 : Properly report root bounds #

Patch Set 15 : Comment clean up #

Patch Set 16 : Update For WK1 #

Patch Set 17 : Update For WK1 #

Patch Set 18 : Make timestamp logic use the callback's execution context #

Patch Set 19 : Make Document store a list of observers rather than targets #

Patch Set 20 : Change to storing IntersectionObserverData as rare data #

Patch Set 21 : Plumbed out number of active observers and updated the test #

Patch Set 22 : Change root to a raw pointer and add a test #

Patch Set 23 : Small simplification #

Patch Set 24 : Attempt to rebase #

Patch Set 25 : Fix inline test while making sure the text test still passes too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -139 lines) Patch
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/client-rect-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/disconnect-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/display-none-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/edge-inclusive-intersection-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/inline-client-rect-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/isIntersecting-change-events-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-targets-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/multiple-thresholds-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +9 lines, -8 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-exceptions-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/observer-without-js-reference-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/remove-element-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/root-margin-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-no-root-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-root-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-zero-size-target-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/shadow-content-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/text-target-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/timestamp-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/unclipped-root-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-hidden-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/intersection-observer/zero-area-element-visible-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/intersection-observer/root-element-deleted.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/intersection-observer/root-element-deleted-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/intersection-observer/root-element-moved.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/intersection-observer/root-element-moved-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +309 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +25 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 8 chunks +341 lines, -1 line 0 comments Download
M Source/WebCore/dom/Element.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +26 lines, -5 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +98 lines, -0 lines 0 comments Download
M Source/WebCore/dom/ElementRareData.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +10 lines, -0 lines 0 comments Download
M Source/WebCore/dom/ElementRareData.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +47 lines, -9 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 4 chunks +134 lines, -8 lines 0 comments Download
M Source/WebCore/page/IntersectionObserver.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserverEntry.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +7 lines, -0 lines 0 comments Download
M Source/WebCore/page/IntersectionObserverEntry.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +31 lines, -0 lines 0 comments Download
M Source/WebCore/platform/Logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.h View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +21 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutRect.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutRect.cpp View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBlock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBlock.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 4 chunks +18 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/RenderInline.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +12 lines, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +6 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 2 3 4 5 6 1 chunk +8 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGForeignObject.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGInline.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGInline.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGModelObject.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGRoot.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGRoot.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGText.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/RenderSVGText.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/rendering/svg/SVGRenderSupport.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/testing/Internals.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/testing/Internals.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/ChangeLog View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/WebPreferences.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +16 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/TestOptions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -1 line 0 comments Download
M Tools/DumpRenderTree/TestOptions.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b