Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1647)

Delta Between Two Patch Sets: Tools/ChangeLog

Issue 359780043: WIP for IO
Left Patch Set: Update For WK1 Created 5 years, 8 months ago
Right Patch Set: Fix inline test while making sure the text test still passes too. Created 5 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h ('k') | Tools/DumpRenderTree/TestOptions.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 2018-07-25 Ali Juma <ajuma@chromium.org> 1 2018-08-08 Ali Juma <ajuma@chromium.org>
2 2
3 Implement IntersectionObserver 3 Implement IntersectionObserver
4 https://bugs.webkit.org/show_bug.cgi?id=159475 4 https://bugs.webkit.org/show_bug.cgi?id=159475
5 5
6 Reviewed by NOBODY (OOPS!). 6 Reviewed by NOBODY (OOPS!).
7
8 * DumpRenderTree/TestOptions.cpp:
9 (TestOptions::TestOptions):
10 * DumpRenderTree/TestOptions.h:
11 * DumpRenderTree/mac/DumpRenderTree.mm:
12 (enableExperimentalFeatures):
13 (setWebPreferencesForTestOptions):
14 * WebKitTestRunner/TestController.cpp:
15 (WTR::TestController::resetPreferencesToConsistentValues):
16
17 2018-08-10 David Fenton <david_fenton@apple.com>
18
19 Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
20 https://bugs.webkit.org/show_bug.cgi?id=188470.
21
22 Unreviewed test gardening, disabling the tests.
23
24 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
25 (TEST_F):
26
27 2018-08-10 Joseph Pecoraro <pecoraro@apple.com>
28
29 Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
30 https://bugs.webkit.org/show_bug.cgi?id=188458
31
32 Reviewed by Alex Christensen.
33
34 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
35 (TestExpectationParser):
36 * TestResultServer/static-dashboards/flakiness_dashboard.js:
37
38 2018-08-09 Fujii Hironori <Hironori.Fujii@sony.com>
39
40 [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
41 https://bugs.webkit.org/show_bug.cgi?id=187973
42
43 Reviewed by Alex Christensen.
44
45 In LayoutTests, test names have been canonicalized in Unix style
46 since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
47 Bug 179572, Bug 180660 and Bug 181814 have changed to use
48 os.path.seq instead of slash if Windows Python is used.
49
50 Revert parts of those changes. Change relative_test_filename to
51 return a slash sperated test name as well as chromium_win.py used
52 to do.
53
54 This change fixes all 41 test-webkitpy failures in WinCairo port.
55
56 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
57 (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
58 * Scripts/webkitpy/port/base.py:
59 (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.s ep.
60 (Port.relative_test_filename): Replace self.host.filesystem.sep with sel f.TEST_PATH_SEPARATOR.
61 (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
62 * Scripts/webkitpy/port/driver.py:
63 (Driver): Use '/' instead of os.sep.
64 * Scripts/webkitpy/port/win.py:
65 (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
66
67 2018-08-09 Thomas Denney <tdenney@apple.com>
68
69 [WHLSL] Add individual test durations to output
70 https://bugs.webkit.org/show_bug.cgi?id=188448
71
72 Reviewed by Myles C. Maxfield.
73
74 * WebGPUShadingLanguageRI/Test.js: Add timing output.
75
76 2018-08-09 Ben Richards <benton_richards@apple.com>
77
78 We should cache the compiled sandbox profile in a data vault
79 https://bugs.webkit.org/show_bug.cgi?id=184991
80
81 Reviewed by Ryosuke Niwa.
82
83 Added trace points for sandbox initialization
84
85 * Tracing/SystemTracePoints.plist:
86
87 2018-08-09 Jer Noble <jer.noble@apple.com>
88
89 Video playback is using more power
90 https://bugs.webkit.org/show_bug.cgi?id=188452
91 <rdar://problem/42298937>
92
93 Reviewed by Eric Carlson.
94
95 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
96 (PreferredAudioBufferSize::createView):
97 (PreferredAudioBufferSize::preferredAudioBufferSize const):
98 (TEST_F):
99
100 2018-08-09 Alex Christensen <achristensen@webkit.org>
101
102 REGRESSION(234640) Loading stalls in environments without SafariSafeBrow sing framework
103 https://bugs.webkit.org/show_bug.cgi?id=188453
104 <rdar://problem/43102553>
105
106 Reviewed by Chris Dumez
107
108 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
109 (TEST):
110 (+[NullLookupContext sharedLookupContext]):
111 (TestWebKitAPI::TEST): Deleted.
112
113 2018-08-09 Alex Christensen <achristensen@webkit.org>
114
115 WKURLSchemeHandler crashes when sent errors with sync XHR
116 https://bugs.webkit.org/show_bug.cgi?id=188358
117
118 Reviewed by Chris Dumez.
119
120 * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
121 (-[SyncErrorScheme webView:startURLSchemeTask:]):
122 (-[SyncErrorScheme webView:stopURLSchemeTask:]):
123 (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedB yFrame:completionHandler:]):
124
125 2018-08-09 Per Arne Vollan <pvollan@apple.com>
126
127 REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.ht ml is failing
128 https://bugs.webkit.org/show_bug.cgi?id=188397
129
130 Reviewed by Tim Horton.
131
132 After r234652, [NSScroller preferredScrollerStyle] is called in the UI p rocess, and we need to set the same
133 user defaults related to scrollbars in the UI process as we do in the We bProcess.
134
135 * WebKitTestRunner/mac/main.mm:
136 (setDefaultsToConsistentValuesForTesting):
137
138 2018-08-09 Wenson Hsieh <wenson_hsieh@apple.com>
139
140 [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSi mulator
141 https://bugs.webkit.org/show_bug.cgi?id=188439
142
143 Reviewed by Andy Estes and Megan Gardner.
144
145 Refactor DataInteractionSimulator (currently used for drag and drop test ing on iOS) so that it exists across
146 macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rena me DataInteractionTests to
147 DragAndDropTests.
148
149 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
150 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
151 (TestWebKitAPI::TEST):
152 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/Tes tWebKitAPI/Tests/ios/DataInteractionTests.mm.
153 (testIconImage):
154 (testZIPArchive):
155 (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:] ):
156 (-[TestWKWebView editorContainsImageElement]):
157 (-[TestWKWebView editorValue]):
158 (makeCGRectValue):
159 (checkCGRectIsEqualToCGRectWithLogging):
160 (checkSelectionRectsWithLogging):
161 (checkRichTextTypePrecedesPlainTextType):
162 (checkFirstTypeIsPresentAndSecondTypeIsMissing):
163 (checkTypeIdentifierIsRegisteredAtIndex):
164 (checkEstimatedSize):
165 (checkSuggestedNameAndEstimatedSize):
166 (checkStringArraysAreEqual):
167 (checkDragCaretRectIsContainedInRect):
168 (checkJSONWithLogging):
169 (testIconImageData):
170 (runTestWithTemporaryTextFile):
171 (runTestWithTemporaryFolder):
172 (TestWebKitAPI::TEST):
173 (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
174 (TestWebKitAPI::testDragAndDropOntoTargetElements):
175 (TestWebKitAPI::testIconImageData):
176 * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWeb KitAPI/ios/DataInteractionSimulator.h.
177 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestW ebKitAPI/ios/DataInteractionSimulator.mm.
178 (-[WKWebView dropInteractionDelegate]):
179 (-[WKWebView dragInteractionDelegate]):
180 (-[WKWebView dropInteraction]):
181 (-[WKWebView dragInteraction]):
182 (-[MockDragDropSession initWithItems:location:window:allowMove:]):
183 (-[MockDragDropSession allowsMoveOperation]):
184 (-[MockDragDropSession isRestrictedToDraggingApplication]):
185 (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
186 (-[MockDragDropSession canLoadObjectsOfClass:]):
187 (-[MockDragDropSession canLoadObjectsOfClasses:]):
188 (-[MockDragDropSession items]):
189 (-[MockDragDropSession setItems:]):
190 (-[MockDragDropSession addItems:]):
191 (-[MockDragDropSession locationInView:]):
192 (-[MockDropSession initWithProviders:location:window:allowMove:]):
193 (-[MockDropSession isLocal]):
194 (-[MockDropSession progress]):
195 (-[MockDropSession setProgressIndicatorStyle:]):
196 (-[MockDropSession progressIndicatorStyle]):
197 (-[MockDropSession operationMask]):
198 (-[MockDropSession localDragSession]):
199 (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
200 (-[MockDropSession canCreateItemsOfClass:]):
201 (-[MockDropSession loadObjectsOfClass:completion:]):
202 (-[MockDragSession initWithWindow:allowMove:]):
203 (-[MockDragSession localOperationMask]):
204 (-[MockDragSession externalOperationMask]):
205 (-[MockDragSession session]):
206 (-[MockDragSession localContext]):
207 (-[MockDragSession setLocalContext:]):
208 (dragAndDropEventNames):
209 (-[DragAndDropSimulatorApplication _cancelAllTouches]):
210 (-[DragAndDropSimulator initWithWebView:]):
211 (-[DragAndDropSimulator dealloc]):
212 (-[DragAndDropSimulator _resetSimulatedState]):
213 (-[DragAndDropSimulator observedEventNames]):
214 (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
215 (-[DragAndDropSimulator runFrom:to:]):
216 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
217 (-[DragAndDropSimulator finalSelectionRects]):
218 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
219 (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
220 (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
221 (-[DragAndDropSimulator _advanceProgress]):
222 (-[DragAndDropSimulator _currentLocation]):
223 (-[DragAndDropSimulator _scheduleAdvanceProgress]):
224 (-[DragAndDropSimulator sourceItemProviders]):
225 (-[DragAndDropSimulator externalItemProviders]):
226 (-[DragAndDropSimulator setExternalItemProviders:]):
227 (-[DragAndDropSimulator phase]):
228 (-[DragAndDropSimulator liftPreviews]):
229 (-[DragAndDropSimulator lastKnownDragCaretRect]):
230 (-[DragAndDropSimulator waitForInputSession]):
231 (-[DragAndDropSimulator insertedAttachments]):
232 (-[DragAndDropSimulator removedAttachments]):
233 (-[DragAndDropSimulator endDataTransfer]):
234 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forS ession:itemProviders:]):
235 (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOpe ration:forSession:]):
236 (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersFor ItemProvider:representingObjects:additionalData:]):
237 (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
238 (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
239 (-[DragAndDropSimulator _webView:didInsertAttachment:]):
240 (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
241 (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
242 (-[DragAndDropSimulator _webView:didStartInputSession:]):
243 * TestWebKitAPI/ios/UIKitSPI.h:
244 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
245 (-[DragAndDropSimulator initWithWebView:]):
246 (-[DragAndDropSimulator dealloc]):
247 (-[DragAndDropSimulator runFrom:to:]):
248 (-[DragAndDropSimulator insertedAttachments]):
249 (-[DragAndDropSimulator removedAttachments]):
250
251 2018-08-09 Sihui Liu <sihui_liu@apple.com>
252
253 REGRESSION (r232083): WKWebView loses first-party cookies on iOS
254 https://bugs.webkit.org/show_bug.cgi?id=188443
255 <rdar://problem/42991584>
256
257 Reviewed by Chris Dumez.
258
259 Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
260
261 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
262
263 2018-08-09 Ross Kirsling <ross.kirsling@sony.com>
264
265 Unreviewed follow-up fix for r234720.
266
267 * Scripts/webkitpy/bindings/main.py:
268 (BindingsTests.close_and_remove):
269 (BindingsTests.main):
270 Return to the original approach, since this seems to be the simplest cro ss-platform solution.
271
272 2018-08-09 Ali Juma <ajuma@chromium.org>
273
274 Import WPTs for IntersectionObserver
275 https://bugs.webkit.org/show_bug.cgi?id=188416
276
277 Reviewed by Simon Fraser.
278
279 Enable IntersectionObserver in DumpRenderTree.·
280
281 * DumpRenderTree/mac/DumpRenderTree.mm:
282 (enableExperimentalFeatures):
283 (setWebPreferencesForTestOptions):
284 * WebKitTestRunner/TestController.cpp:
285 (WTR::TestController::resetPreferencesToConsistentValues):
286
287 2018-08-08 Ross Kirsling <ross.kirsling@sony.com>
288
289 run-bindings-tests is not Win32-compatible
290 https://bugs.webkit.org/show_bug.cgi?id=188424
291
292 Reviewed by Fujii Hironori.
293
294 * Scripts/webkitpy/bindings/main.py:
295 (BindingsTests.main):
296 Stop leaking file descriptors.
297 (See https://www.logilab.org/blogentry/17873 for details, though the sol ution here is even simpler.)
298
299 2018-08-08 Alex Christensen <achristensen@webkit.org>
300
301 Fix possible null dereference in WebBackForwardList::restoreFromState
302 https://bugs.webkit.org/show_bug.cgi?id=188418
303 <rdar://problem/42531726>
304
305 Reviewed by Chris Dumez.
306
307 * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
308 (TestWebKitAPI::TEST):
309
310 2018-08-08 Ross Kirsling <ross.kirsling@sony.com>
311
312 run-builtins-generator-tests does not correctly handle CRLFs from stderr
313 https://bugs.webkit.org/show_bug.cgi?id=188392
314
315 Reviewed by Fujii Hironori.
316
317 Background:
318 file.write converts LF to os.linesep, so if the input string contains CR LF, we end up writing CRCRLF to the file.
319
320 * Scripts/webkitpy/common/system/executive.py:
321 (Executive.run_command):
322 Normalize CRLF to LF in decoded stdout/stderr data, so that we don't ret urn consumers a platform-specific string.
323
324 2018-08-08 Aditya Keerthi <akeerthi@apple.com>
325
326 Unreviewed, add myself to committers list.
327
328 * Scripts/webkitpy/common/config/contributors.json:
329
330 2018-08-08 Commit Queue <commit-queue@webkit.org>
331
332 Unreviewed, rolling out r234314, r234320, and r234321.
333 https://bugs.webkit.org/show_bug.cgi?id=188414
334
335 Caused email sign in issue (Requested by ryanhaddad on
336 #webkit).
337
338 Reverted changesets:
339
340 "Remove unused WKNavigationDelegatePrivate
341 decidePolicyForNavigationAction SPI"
342 https://bugs.webkit.org/show_bug.cgi?id=188077
343 https://trac.webkit.org/changeset/234314
344
345 "Fix API tests after r234314"
346 https://bugs.webkit.org/show_bug.cgi?id=188077
347 https://trac.webkit.org/changeset/234320
348
349 "Fix API tests after r234314"
350 https://bugs.webkit.org/show_bug.cgi?id=188077
351 https://trac.webkit.org/changeset/234321
352
353 2018-08-08 Wenson Hsieh <wenson_hsieh@apple.com>
354
355 [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky fai lure
356 https://bugs.webkit.org/show_bug.cgi?id=188401
357 <rdar://problem/32542300>
358
359 Reviewed by Ryosuke Niwa.
360
361 When run individually, fast/events/ios/contenteditable-autocapitalize.ht ml passes consistently; however, when
362 run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
363 is because each of the three steps of this test ends when UIScriptContro ller's `didHideKeyboardCallback` is
364 invoked, and if the keyboard only begins to dismiss after the previous t est completes, we have a race. When the
365 keyboard finishes dismissing after the UI script is evaluated, it will t rigger UI script completion early and
366 skip over one of the steps in the layout test, resulting in a text diff failure.
367
368 To fix this, add a mechanism in WebKitTestRunner to wait until the keybo ard is dismissed (with a short timeout)
369 as a part of resetting test controller state, before moving on to the ne xt layout test.
370
371 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
372 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
373 (-[TestRunnerWKWebView didStartFormControlInteraction]):
374 (-[TestRunnerWKWebView didEndFormControlInteraction]):
375
376 Use these hooks to keep track of whether the previous test is presenting any form input UI.
377
378 (-[TestRunnerWKWebView isInteractingWithFormControl]):
379 * WebKitTestRunner/ios/TestControllerIOS.mm:
380 (WTR::handleKeyboardWillHideNotification):
381 (WTR::handleKeyboardDidHideNotification):
382 (WTR::TestController::platformInitialize):
383 (WTR::TestController::platformDestroy):
384
385 Register during initialization (and unregister during teardown) for keyb oard hiding notifications, to keep track
386 of when the keyboard dismissal animation ends.
387
388 (WTR::TestController::platformResetStateToConsistentValues):
389
390 Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
391 which causes the field to lose focus. (2) If necessary, wait for the cur rent keyboard dismissal animation to
392 finish. This includes any keyboard dismissal animations triggered as a r esult of step (1).
393
394 2018-08-05 Darin Adler <darin@apple.com>
395
396 [Cocoa] More tweaks and refactoring to prepare for ARC
397 https://bugs.webkit.org/show_bug.cgi?id=188245
398
399 Reviewed by Dan Bernstein.
400
401 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
402 CFTypeRef instead of void*.
403
404 * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
405 (createCoreAnimationLayer): Use CFBridgingRetain.
406
407 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
408 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
409 (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
410 (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
411 (AccessibilityUIElement::textMarkerRangeLength): Ditto.
412 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttri bute): Ditto.
413 (AccessibilityUIElement::indexForTextMarker): Ditto.
414 (AccessibilityUIElement::textMarkerForIndex): Ditto.
415 (AccessibilityUIElement::isTextMarkerValid): Ditto.
416 (AccessibilityUIElement::previousTextMarker): Ditto.
417 (AccessibilityUIElement::nextTextMarker): Ditto.
418 (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
419 (createJSStringRef): Ditto.
420 (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
421 (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
422 (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
423 (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
424 (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
425 (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
426 (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
427 (AccessibilityUIElement::textMarkerForPoint): Ditto.
428 (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
429 (AccessibilityUIElement::startTextMarker): Ditto.
430 (AccessibilityUIElement::endTextMarker): Ditto.
431 (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
432 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
433 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
434 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditt o.
435 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
436 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
437 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
438 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto .
439 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
440 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
441 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
442
443 * DumpRenderTree/mac/DumpRenderTree.mm:
444 (resetWebPreferencesToConsistentValues): Use bridging cast.
445 (dumpFramesAsText): Ditto.
446 (dumpBackForwardListForAllWindows): Use a modern for loop instead of
447 CFArray functions to iterate the array.
448 (dump): Use bridging cast.
449 (runTest): Ditto.
450
451 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
452 (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAlloca teObject.
453 (toUTI): Return a RetainPtr<CFStringRef>.
454 (-[LocalPasteboard types]): Use the above and bridging casts.
455 (-[LocalPasteboard availableTypeFromArray:]): Ditto.
456 (-[LocalPasteboard setData:forType:]): Ditto.
457 (-[LocalPasteboard dataForType:]): Ditto.
458 (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSeriali zation
459 instead of CFPropertyList.
460 (-[LocalPasteboard setString:forType:]): Use NSString method instead of
461 CFStringCreateExternalRepresentation.
462
463 * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashS et
464 instead of an Objective-C object pointer type.
465 * DumpRenderTree/mac/MockGeolocationProvider.mm:
466 (-[MockGeolocationProvider registerWebView:]): Update for above.
467 (-[MockGeolocationProvider unregisterWebView:]): Ditto.
468 (-[MockGeolocationProvider timerFired]): Ditto.
469
470 * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
471 HashMap and HashSet instead of an Objective-C object pointer type.
472 * DumpRenderTree/mac/MockWebNotificationProvider.mm:
473 (-[MockWebNotificationProvider registerWebView:]): Update for above.
474 (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
475 (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
476 (-[MockWebNotificationProvider cancelNotification:]): Ditto.
477 (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
478
479 * DumpRenderTree/mac/ObjCPlugin.m:
480 (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
481
482 * DumpRenderTree/mac/TestRunnerMac.mm:
483 (TestRunner::addDisallowedURL): Use bridging cast.
484 (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
485 (TestRunner::clearApplicationCacheForOrigin): Ditto.
486 (originsArrayToJS): Ditto.
487 (TestRunner::copyDecodedHostName): Ditto.
488 (TestRunner::copyEncodedHostName): Ditto.
489 (TestRunner::queueLoad): Ditto.
490 (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
491 (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
492 (TestRunner::setUserStyleSheetLocation): Ditto.
493 (TestRunner::setValueForUser): Ditto.
494 (TestRunner::overridePreference): Ditto.
495 (TestRunner::execCommand): Ditto.
496 (TestRunner::findString): Ditto.
497 (TestRunner::isCommandEnabled): Ditto.
498 (TestRunner::addOriginAccessWhitelistEntry): Ditto.
499 (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
500 (TestRunner::addUserScript): Ditto.
501 (TestRunner::addUserStyleSheet): Ditto.
502 (TestRunner::evaluateInWebInspector): Ditto.
503 (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
504 (TestRunner::authenticateSession): Ditto.
505 (TestRunner::grantWebNotificationPermission): Ditto.
506 (TestRunner::denyWebNotificationPermission): Ditto.
507 * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
508 (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
509
510 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
511 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bri dging cast.
512 (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
513 (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
514 (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
515 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
516 (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
517 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
518 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
519 (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
520 (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
521 (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
522 (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
523 (WTR::AccessibilityUIElement::startTextMarker): Ditto.
524 (WTR::AccessibilityUIElement::endTextMarker): Ditto.
525 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Dit to.
526 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Di tto.
527 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
528 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto .
529 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Di tto.
530 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMar ker): Ditto.
531 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
532 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Dit to.
533 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMark er): Ditto.
534 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): D itto.
535
536 * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
537 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
538
539 * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRun nerWindow.h
540 so we can use the type and know it inherits from NSWindow.
541
542 * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestR unnerWindow.h
543 so we can use the type and know it inherits from NSWindow. Moved WebKitT estRunnerWindow
544 class into a separate file.
545 (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_ke yWindow]
546 instead of have a second copy of the implementation.
547
548 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTe stRunnerWindow.h
549 so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
550 (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
551
552 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
553 (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAlloca teObject.
554 (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
555 (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
556 (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSeriali zation
557 instead of CFPropertyList.
558 (-[LocalPasteboard setString:forType:]): Use NSString method instead of
559 CFStringCreateExternalRepresentation.
560
561 * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
562 WebKitTestRunnerWindow here so it can be included by files that need to know
563 what the type is and that it inherits from NSWindow.
564
565 * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implement ation here.
566 (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
567 messier implementation.
568
569 2018-08-07 Alex Christensen <achristensen@webkit.org>
570
571 Add a test for using SafeBrowsing
572 https://bugs.webkit.org/show_bug.cgi?id=188290
573
574 Reviewed by Chris Dumez.
575
576 Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
577 We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
578
579 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
580 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
581 (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
582 (TestWebKitAPI::TEST):
583
584 2018-08-07 Lucas Forschler <lforschler@apple.com>
585
586 If there's a Radar in the ChangeLog, webkit-patch upload/create-bug shou ld put the radar in the bug and set InRadar
587 https://bugs.webkit.org/show_bug.cgi?id=188235
588
589 Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
590
591 * Scripts/webkitpy/common/checkout/changelog.py:·
592 (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
593 * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the n ew _parse_radar_id functionality
594 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
595 (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the chang eform
596 * Scripts/webkitpy/tool/commands/upload.py:
597 (Upload): Teach the upload step how to add radar information when creati ng a new bug.
598 * Scripts/webkitpy/tool/steps/__init__.py:
599 * Scripts/webkitpy/tool/steps/addradar.py: Added.
600 (AddRadar):
601 (AddRadar.run): Contains the logic to add the radar information to bugzi lla.
602 * Scripts/webkitpy/tool/steps/createbug.py:
603 (CreateBug.run): set a "created_new_bug" state when creating a new bugzi lla bug.
604
605 2018-08-07 Wenson Hsieh <wenson_hsieh@apple.com>
606
607 Post-review feedback after r234614.
608 https://bugs.webkit.org/show_bug.cgi?id=188322
609 <rdar://problem/42455270>
610
611 Reviewed by Sam Weinig.
612
613 Use std::round instead of roundl — there's no reason to go from double t o long double precision when rounding.
614
615 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
616 (rounded):
617
618 2018-08-07 Don Olmstead <don.olmstead@sony.com>
619
620 [MiniBrowser][Win] Allow selection of recent user agents
621 https://bugs.webkit.org/show_bug.cgi?id=188371
622
623 Reviewed by Fujii Hironori.
624
625 Updates the user agent spoofing strings to the latest released
626 versions and adds Microsoft Edge's user agent.
627
628 Moves the menu item selection to the common base class, BrowserWindow
629 to support user agent spoofing in a WebKitLegacyBrowserWindow and
630 WebKitBrowserWindow.
631
632 * MiniBrowser/win/BrowserWindow.cpp: Added.
633 (BrowserWindow::setUserAgent):
634 * MiniBrowser/win/BrowserWindow.h:
635 * MiniBrowser/win/CMakeLists.txt:
636 * MiniBrowser/win/MainWindow.cpp:
637 (MainWindow::toggleMenuItem):
638 * MiniBrowser/win/MiniBrowserLib.rc:
639 * MiniBrowser/win/MiniBrowserLibResource.h:
640 * MiniBrowser/win/WebKitBrowserWindow.cpp:
641 * MiniBrowser/win/WebKitBrowserWindow.h:
642 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
643 (WebKitLegacyBrowserWindow::setUserAgent):
644 * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
645
646 2018-08-07 Yusuke Suzuki <utatane.tea@gmail.com>
647
648 Unreviewed, add a new address to my configuration
649
650 * Scripts/webkitpy/common/config/contributors.json:
651
652 2018-08-06 David Quesada <david_quesada@apple.com>
653
654 webkitdirs.pm should default to iPhone SE for 64-bit testing
655 https://bugs.webkit.org/show_bug.cgi?id=188361
656
657 Reviewed by Daniel Bates.
658
659 Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
660
661 * Scripts/webkitdirs.pm:
662 (findOrCreateSimulatorForIOSDevice):
663 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
664 (parse_args):
665 Update the help text for --device-type to reflect the new default de vice.
666
667 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
668
669 [iOS] Caret disappears after resigning and becoming first responder if a ctive focus state is retained
670 https://bugs.webkit.org/show_bug.cgi?id=188322
671 <rdar://problem/42455270>
672
673 Reviewed by Tim Horton.
674
675 Fixes an API test added in r234600, which had incorrect test expectation s — namely, the width of the caret rect
676 was not in content view coordinates, unlike the x, y, and height.
677
678 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
679 (rounded):
680 (-[TestWKWebView waitForCaretViewFrameToBecome:]):
681 (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
682 (TestWebKitAPI::TEST):
683
684 2018-08-06 Ryan Haddad <ryanhaddad@apple.com>
685
686 Unreviewed, rolling out r234569.
687
688 Breaks internal builds.
689
690 Reverted changeset:
691
692 "We should cache the compiled sandbox profile in a data vault"
693 https://bugs.webkit.org/show_bug.cgi?id=184991
694 https://trac.webkit.org/changeset/234569
695
696 2018-08-06 Fujii Hironori <Hironori.Fujii@sony.com>
697
698 [Win][DLLLauncher] Remove --highDPI switch
699 https://bugs.webkit.org/show_bug.cgi?id=188255
700
701 Reviewed by Yusuke Suzuki.
702
703 Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
704 aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
705 became useless since the change. Remove the switch.
706
707 This change fixes the issue all dump render tree tests are failing
708 in WinCairo port if high DPI display is connected.
709
710 * MiniBrowser/win/Common.cpp:
711 (parseCommandLine): Removed `--highDPI` switch.
712 * win/DLLLauncher/DLLLauncherMain.cpp:
713 (wWinMain): Do not call SetProcessDPIAware.
714 (shouldUseHighDPI): Deleted.
715
716 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
717
718 [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
719 https://bugs.webkit.org/show_bug.cgi?id=188335
720 <rdar://problem/32542437> and <rdar://problem/32542433>
721
722 Reviewed by Tim Horton.
723
724 Remove a UIScriptController helper method that attempted to wait for Qui ckType buttons to appear, and then send
725 touch events to the buttons. These were only used for the two tests whic h this patch refactors. See the
726 LayoutTests ChangeLog for more detail.
727
728 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
729 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
730 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
731 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
732 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
733 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAt Index): Deleted.
734 * TestRunnerShared/UIScriptContext/UIScriptController.h:
735 * TestRunnerShared/spi/UIKitTestSPI.h:
736
737 Remove an internal class declaration that is now unnecessary.
738
739 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
740 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
741 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAt Index): Deleted.
742
743 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
744
745 [iOS] Caret disappears after resigning and becoming first responder if a ctive focus state is retained
746 https://bugs.webkit.org/show_bug.cgi?id=188322
747 <rdar://problem/42455270>
748
749 Reviewed by Tim Horton.
750
751 Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
752 test. Also adds new API tests to verify that when a web view resigns fir st responder, both caret and range
753 selection views are hidden, and when first responder status is restored, both caret and range selection views
754 are made visible again.
755
756 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
757 (WTR::UIScriptController::selectionStartGrabberViewRect const):
758 (WTR::UIScriptController::selectionEndGrabberViewRect const):
759 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
760 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
761 (WTR::UIScriptController::selectionStartGrabberViewRect const):
762 (WTR::UIScriptController::selectionEndGrabberViewRect const):
763 * TestRunnerShared/UIScriptContext/UIScriptController.h:
764 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
765 (-[TestWKWebView waitForCaretViewFrameToBecome:]):
766 (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
767 (webViewWithAutofocusedInput):
768
769 Pull out some common logic for creating a web view that allows programma tic focus to present the keyboard, and
770 immediately loading a web page with an autofocusing text field.
771
772 (TestWebKitAPI::TEST):
773 * TestWebKitAPI/cocoa/TestWKWebView.h:
774 * TestWebKitAPI/cocoa/TestWKWebView.mm:
775 (-[TestWKWebView caretViewRectInContentCoordinates]):
776 (-[TestWKWebView selectionViewRectsInContentCoordinates]):
777 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
778 (WTR::UIScriptController::selectionStartGrabberViewRect const):
779 (WTR::UIScriptController::selectionEndGrabberViewRect const):
780
781 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
782
783 [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
784 https://bugs.webkit.org/show_bug.cgi?id=188334
785 <rdar://problem/40630074>
786
787 Reviewed by Tim Horton.
788
789 To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
790 and stores the completion callback ID for the previously dispatched even ts as vendor-defined data. When this
791 vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
792 it to a completion block, and invoke the completion block to signal that the previous HID event has been
793 processed.
794
795 This callback ID is an unsigned, so we tell IOKit that we need `sizeof(u nsigned)` (4 bytes) to store it. On
796 shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `size of(CFIndex)`. When we later call
797 IOHIDEventGetIntegerValue to read the value of our vendor-defined data a s a CFIndex, we get our expected
798 callback ID because the buffer was clamped to 8 bytes.
799
800 However, on recent iOS SDKs that contain the fix for <rdar://problem/200 82284>, IOKit no longer clamps the size
801 of the vendor-defined data buffer to 8 bytes. This means that when we tr y to use IOHIDEventGetIntegerValue to
802 read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
803 the upper 4 bytes are garbage. In the case where any of these upper 4 by tes are non-zero, we fail to map the
804 callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
805 be thrown.
806
807 To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDE ventGetIntegerValue's return type.
808
809 * WebKitTestRunner/ios/HIDEventGenerator.mm:
810 (+[HIDEventGenerator nextEventCallbackID]):
811 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
812
813 Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by usi ng auto and move semantics.
814
815 2018-08-03 Ben Richards <benton_richards@apple.com>
816
817 We should cache the compiled sandbox profile in a data vault
818 https://bugs.webkit.org/show_bug.cgi?id=184991
819
820 Reviewed by Ryosuke Niwa.
821
822 Added trace points for sandbox initialization
823
824 * Tracing/SystemTracePoints.plist:
825
826 2018-08-03 David Fenton <david_fenton@apple.com>
827
828 Unreviewed, rolling out r234517.
829
830 Caused API test failures on iOS
831
832 Reverted changeset:
833
834 "[Cocoa] setCookie API fails to set session cookies for
835 defaultDataStore if processPool created but not used"
836 https://bugs.webkit.org/show_bug.cgi?id=188209
837 https://trac.webkit.org/changeset/234517
838
839 2018-08-03 Ben Richards <benton_richards@apple.com>
840
841 Add configuration for automatic process pre-warming
842 https://bugs.webkit.org/show_bug.cgi?id=187108
843
844 Reviewed by Ryosuke Niwa.
845
846 Added new test case for setting maximum prewarmed process count and upda ted test case for process swap on navigation to set the maximum prewarmed proces s count to be 1 where relevant.
847
848 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
849 * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
850 (TEST):
851 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
852 * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
853 (TEST):
854
855 2018-08-03 Aakash Jain <aakash_jain@apple.com>
856
857 [ews-build] Add build step to Check Patch Relevance
858 https://bugs.webkit.org/show_bug.cgi?id=188295
859
860 Reviewed by Lucas Forschler.
861
862 * BuildSlaveSupport/ews-build/steps.py:
863 (CheckPatchRelevance): Added step to check patch relevance.
864 (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevan t.
865 (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
866 (CheckPatchRelevance._addToLog): Add the log message.
867 (CheckPatchRelevance.start):
868 * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance st ep appropriately.
869
870 2018-08-03 Jer Noble <jer.noble@apple.com>
871
872 Unreviewed gardening; r234534 changed the policy for what audio session is set when a
873 media element is paused. Updating the test to reflect the new policy.
874
875 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
876 (TestWebKitAPI::TEST):
877
878 2018-08-03 Zalan Bujtas <zalan@apple.com>
879
880 [LFC][Floating] Now that the document renderer belongs to "complicated c ases", adjust viewport stretching.
881 https://bugs.webkit.org/show_bug.cgi?id=188306
882
883 Reviewed by Antti Koivisto.
884
885 * LayoutReloaded/misc/LFC-passing-tests.txt:
886
887 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
888
889 [WPE] Use the new key mapper API from WPEBackend
890 https://bugs.webkit.org/show_bug.cgi?id=188216
891
892 Reviewed by Žan Doberšek.
893
894 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
895 (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_ for_key_code() to get the hardware key
896 code.
897 * wpe/backends/WindowViewBackend.cpp:
898 (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
899 (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
900 (WPEToolingBackends::WindowViewBackend::modifiers const):
901 * wpe/backends/WindowViewBackend.h:
902
903 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
904
905 [WPE] Implement MouseEvent.buttons
906 https://bugs.webkit.org/show_bug.cgi?id=187998
907
908 Reviewed by Žan Doberšek.
909
910 Pass modifiers to mouse events.
911
912 * WebKitTestRunner/EventSenderProxy.h:
913 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
914 (WTR::senderButtonToWPEButton):
915 (WTR::modifierForButton):
916 (WTR::EventSenderProxy::mouseDown):
917 (WTR::EventSenderProxy::mouseUp):
918 (WTR::EventSenderProxy::mouseMoveTo):
919 (WTR::EventSenderProxy::mouseScrollBy):
920 (WTR::wkEventModifiersToWPE):
921 (WTR::wpeKeySymForKeyRef):
922 (WTR::EventSenderProxy::keyDown):
923 (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
924 * wpe/backends/WindowViewBackend.cpp:
925 (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
926 (WPEToolingBackends::WindowViewBackend::modifiers const):
927 * wpe/backends/WindowViewBackend.h:
928
929 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
930
931 [WPE] Use WPE key symbols and new API instead of xkbcommon and the key m apper
932 https://bugs.webkit.org/show_bug.cgi?id=188093
933
934 Reviewed by Žan Doberšek.
935
936 * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
937 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
938 (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_co de().
939 (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event s ince it was removed.
940 * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versio ns.
941 * wpe/backends/WindowViewBackend.cpp:
942 (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unic ode char to the event since it was removed.
943 * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
944
945 2018-08-02 Nan Wang <n_wang@apple.com>
946
947 AX: [iOS] add support to return the attributed string under the element
948 https://bugs.webkit.org/show_bug.cgi?id=188276
949 <rdar://problem/42872357>
950
951 Reviewed by Chris Fleizach.
952
953 * DumpRenderTree/AccessibilityUIElement.cpp:
954 (attributedStringForElementCallback):
955 (AccessibilityUIElement::getJSClass):
956 * DumpRenderTree/AccessibilityUIElement.h:
957 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
958 (AccessibilityUIElement::attributedStringForElement):
959 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
960 (WTR::AccessibilityUIElement::attributedStringForElement):
961 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
962 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
963 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
964 (WTR::AccessibilityUIElement::attributedStringForElement):
965
966 2018-08-02 Ryan Haddad <ryanhaddad@apple.com>
967
968 Skip API test DataInteractionTests.CustomActionSheetPopover on current S DKs.
969 https://bugs.webkit.org/show_bug.cgi?id=175204
970
971 Unreviewed test gardening.
972
973 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
974
975 2018-08-02 Sihui Liu <sihui_liu@apple.com>
976
977 [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
978 https://bugs.webkit.org/show_bug.cgi?id=188209
979
980 Reviewed by Geoffrey Garen.
981
982 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
983 (TEST):
984
985 2018-08-02 Dan Bernstein <mitz@apple.com>
986
987 Fixed WebKit.AttrStyle timing out on build.webkit.org.
988
989 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL tha t requires network
990 access to one that doesn’t.
991 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
992 (TEST): Updated expected value.
993
994 2018-08-02 Wenson Hsieh <wenson_hsieh@apple.com>
995
996 [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
997 https://bugs.webkit.org/show_bug.cgi?id=188251
998 <rdar://problem/37842108>
999
1000 Reviewed by Tim Horton.
1001
1002 Adds a new API test to verify that clients (in this case, UIKit) is allo wed to invoke
1003 -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
1004
1005 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1006 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
1007 (TestWebKitAPI::TEST):
1008 * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
1009
1010 Pull some logic used to force an input session to start out from an exis ting API test file
1011 (WKWebViewAutofillTests) and into a separate helper class that is used b y both the existing API tests and the
1012 new keyboard input test.
1013
1014 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1015 (-[AutofillTestView initWithFrame:]):
1016 (TestWebKitAPI::TEST):
1017 (-[TestInputDelegate init]): Deleted.
1018 (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
1019 * TestWebKitAPI/ios/UIKitSPI.h:
1020
1021 Add some UIKit SPI utilized by the new API test.
1022
1023 2018-08-01 Dan Bernstein <mitz@apple.com>
1024
1025 Optionally expose Attr::style to JavaScript
1026 https://bugs.webkit.org/show_bug.cgi?id=188226
1027 <rdar://problem/42818113>
1028
1029 Reviewed by Darin Adler.
1030
1031 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1032 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
1033 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
1034 (TEST):
1035
1036 2018-08-02 David Fenton <david_fenton@apple.com>
1037
1038 Unreviewed, rolling out r234489.
1039
1040 Caused 50+ crashes and 60+ API failures on iOS
1041
1042 Reverted changeset:
1043
1044 "[WTF] Rename String::format to String::deprecatedFormat"
1045 https://bugs.webkit.org/show_bug.cgi?id=188191
1046 https://trac.webkit.org/changeset/234489
1047
1048 2018-08-01 Ross Kirsling <ross.kirsling@sony.com>
1049
1050 TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mo de
1051 https://bugs.webkit.org/show_bug.cgi?id=188244
1052
1053 Reviewed by Daniel Bates.
1054
1055 Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mod e.·
1056
1057 * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
1058
1059 2018-08-01 Tomas Popela <tpopela@redhat.com>
1060
1061 [WTF] Rename String::format to String::deprecatedFormat
1062 https://bugs.webkit.org/show_bug.cgi?id=188191
1063
1064 Reviewed by Darin Adler.
1065
1066 It should be replaced with string concatenation.
1067
1068 * DumpRenderTree/win/DumpRenderTree.cpp:
1069 (applicationId):
1070 (main):
1071 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1072 (TestWebKitAPI::Util::createURLForResource):
1073 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1074 (WTR::cacheTestRunnerCallback):
1075 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAt k.cpp:
1076 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1077 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1078 (WTR::AccessibilityUIElement::attributedStringForRange):
1079 (WTR::AccessibilityUIElement::url):
1080 (WTR::stringAtOffset):
1081 * WebKitTestRunner/TestController.cpp:
1082 (WTR::TestController::didReceiveAuthenticationChallenge):
1083 (WTR::TestController::downloadDidFail):
1084 (WTR::originUserVisibleName):
1085 (WTR::userMediaOriginHash):
1086 (WTR::TestController::didNavigateWithNavigationData):
1087 (WTR::TestController::didPerformClientRedirect):
1088 (WTR::TestController::didPerformServerRedirect):
1089 (WTR::TestController::didUpdateHistoryTitle):
1090
1091 2018-08-01 Nan Wang <n_wang@apple.com>
1092
1093 AX: AOM: Add ARIA IDL Attribute Reflection
1094 https://bugs.webkit.org/show_bug.cgi?id=184676
1095 <rdar://problem/39476882>
1096
1097 Reviewed by Chris Fleizach.
7 1098
8 * DumpRenderTree/mac/DumpRenderTree.mm: 1099 * DumpRenderTree/mac/DumpRenderTree.mm:
9 (enableExperimentalFeatures): 1100 (enableExperimentalFeatures):
10 * WebKitTestRunner/TestController.cpp: 1101 * WebKitTestRunner/TestController.cpp:
11 (WTR::TestController::resetPreferencesToConsistentValues): 1102 (WTR::TestController::resetPreferencesToConsistentValues):
1103
1104 2018-08-01 Jonathan Bedard <jbedard@apple.com>
1105
1106 Use iPhone SE as the default simulated device
1107 https://bugs.webkit.org/show_bug.cgi?id=188227
1108
1109 Reviewed by Aakash Jain.
1110
1111 * Scripts/webkitpy/port/ios_simulator.py:
1112 (IOSSimulatorPort):
1113
1114 2018-08-01 Commit Queue <commit-queue@webkit.org>
1115
1116 Unreviewed, rolling out r234443 and r234445.
1117 https://bugs.webkit.org/show_bug.cgi?id=188224
1118
1119 Revision caused 3 api failures across all platforms.
1120 (Requested by Truitt on #webkit).
1121
1122 Reverted changesets:
1123
1124 "Add configuration for automatic process pre-warming"
1125 https://bugs.webkit.org/show_bug.cgi?id=187108
1126 https://trac.webkit.org/changeset/234443
1127
1128 "Add configuration for automatic process pre-warming"
1129 https://bugs.webkit.org/show_bug.cgi?id=187108
1130 https://trac.webkit.org/changeset/234445
1131
1132 2018-07-31 Ben Richards <benton_richards@apple.com>
1133
1134 Add configuration for automatic process pre-warming
1135 https://bugs.webkit.org/show_bug.cgi?id=187108
1136
1137 Reviewed by Ryosuke Niwa.
1138
1139 Added new test case for setting maximum prewarmed process count and upda ted test case for process swap on navigation to set the maximum prewarmed proces s count to be 1 where relevant.
1140
1141 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1143 * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Ad ded.
1144 (TEST):
1145
1146 2018-07-31 John Wilander <wilander@apple.com>
1147
1148 Resource Load Statistics: Remove partitioned cookies for reduced complex ity, lower memory footprint, and ability to support more platforms
1149 https://bugs.webkit.org/show_bug.cgi?id=188109
1150 <rdar://problem/42664391>
1151
1152 Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
1153
1154 This patch removes cookie partitioning which reduces the model to just
1155 blocked cookies (in third-party contexts) and first-party cookie access.
1156
1157 Several of the changes are renaming to reflect that there are no more
1158 cookie partitions.
1159
1160 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1161 Removed or renamed functions to reflect that there are no more
1162 partitioned cookies.
1163 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1164 (WTR::InjectedBundle::didReceiveMessageToPage):
1165 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166 (WTR::TestRunner::statisticsUpdateCookieBlocking):
1167 (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
1168 (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
1169 (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
1170 (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
1171 (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
1172 (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
1173 (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCall back): Deleted.
1174 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1175 * WebKitTestRunner/TestController.cpp:
1176 (WTR::TestController::statisticsUpdateCookieBlocking):
1177 (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Dele ted.
1178 (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Delet ed.
1179 (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
1180 (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Delet ed.
1181 * WebKitTestRunner/TestController.h:
1182 * WebKitTestRunner/TestInvocation.cpp:
1183 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1184 (WTR::TestInvocation::didSetBlockCookiesForHost):
1185 (WTR::TestInvocation::didSetHasHadUserInteraction):
1186 (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1187 (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
1188 * WebKitTestRunner/TestInvocation.h:
1189 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1190 (WTR::initializeWebViewConfiguration):
1191
1192 2018-07-31 Alex Christensen <achristensen@webkit.org>
1193
1194 Build fix. Remove unused variable.
1195
1196 * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1197 (TestWebKitAPI::TEST):
1198 transform was never used. It was introduced in r205871
1199 Apparently I'm the first one to build in a certain configuration that fo und it.
1200
1201 2018-07-31 Fujii Hironori <Hironori.Fujii@sony.com>
1202
1203 server_process.py should print returncode in debug log if the process cr ashed
1204 https://bugs.webkit.org/show_bug.cgi?id=188160
1205
1206 Reviewed by Konstantin Tokarev.
1207
1208 * Scripts/webkitpy/port/server_process.py:
1209 (ServerProcess.has_crashed): Put self._proc.returncode into the debug lo g message.
1210
1211 2018-07-31 Tomas Popela <tpopela@redhat.com>
1212
1213 [WTF] String::formatWithArguments() is unused
1214 https://bugs.webkit.org/show_bug.cgi?id=187955
1215
1216 Reviewed by Darin Adler.
1217
1218 Remove tests for WTF::String::formatWithArguments() as it's unused and
1219 we are removing it.
1220
1221 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1222
1223 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1224
1225 [ews-build] Fix typo in builder name for Bindings-tests-EWS.
1226
1227 * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
1228 other builders.
1229
1230 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1231
1232 [ews-build] Add support for API tests in OpenSource EWS
1233 https://bugs.webkit.org/show_bug.cgi?id=188156
1234
1235 Reviewed by Lucas Forschler.
1236
1237 * BuildSlaveSupport/ews-build/config.json:
1238 * BuildSlaveSupport/ews-build/factories.py:
1239 (BuildFactory.__init__): Added triggers parameter.
1240 (BuildFactory): If trigger is defined, create and upload archive and tri gger appropriate queues.
1241 (BuildFactory.propertiesToPassToTriggers): Pass all the required propert ies to triggered queue.
1242 (APITestsFactory): Factory for running API tests.
1243 * BuildSlaveSupport/ews-build/steps.py:
1244 (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the·
1245 source of the property.
1246
1247 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1248
1249 [ews-build] loadConfig should ensure that the triggers are valid
1250 https://bugs.webkit.org/show_bug.cgi?id=188134
1251
1252 Reviewed by Lucas Forschler.
1253
1254 * BuildSlaveSupport/ews-build/loadConfig.py:
1255 (checkValidBuilder): Added a check to ensure that the builder doesn't re fernce non-existing scheduler.
1256 (checkValidSchedulers): Ensures that the scheduler is not un-used.
1257 * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests .
1258
1259 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1260
1261 Unreviewed, fix typo in test expectations and mark another test as timin g out
1262
1263 * TestWebKitAPI/glib/TestExpectations.json:
1264
1265 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1266
1267 More unreviewed GTK test gardening
1268
1269 * TestWebKitAPI/glib/TestExpectations.json:
1270
1271 2018-07-27 Simon Fraser <simon.fraser@apple.com>
1272
1273 Be more conservative with compositing layer creation when memory is low
1274 https://bugs.webkit.org/show_bug.cgi?id=187866
1275 rdar://problem/42366345
1276
1277 Reviewed by Zalan Bujtas.
1278 ········
1279 When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
1280 compositing layers. We avoid compositing for these situations:
1281 1. Layers with 3D transforms which are affine (like translateZ(0)).
1282 2. Layers with will-change
1283 3. Layers for canvases (other than WebGL/WebGPU)
1284 ········
1285 We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
1286 falling into "conservative mode" at 50% of jetsam limit, and "strict mod e" at 65%.
1287 Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
1288 ········
1289 Plumb through a "compositingPolicyOverride" both so that on-device testi ng isn't
1290 flakily falling into a different mode, and so that we can impose the con servative
1291 mode for testing.
1292
1293 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1294 (WTR::InjectedBundlePage::prepare):
1295
1296 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1297
1298 Unreviewed GTK test gardening
1299
1300 * TestWebKitAPI/glib/TestExpectations.json:
1301
1302 2018-07-27 Alex Christensen <achristensen@webkit.org>
1303
1304 Fix API tests after r234314
1305 https://bugs.webkit.org/show_bug.cgi?id=188077
1306
1307 Make API tests use new delegate method.
1308
1309 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1310 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:userInfo:decisionHandler:]):
1311 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]): Deleted.
1312
1313 2018-07-27 Alex Christensen <achristensen@webkit.org>
1314
1315 Fix API tests after r234314
1316 https://bugs.webkit.org/show_bug.cgi?id=188077
1317
1318 Make API tests use new delegate method.
1319
1320 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1321 (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNaviga tionAction:userInfo:decisionHandler:]):
1322 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:use rInfo:decisionHandler:]):
1323 (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationActio n:userInfo:decisionHandler:]):
1324 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:u serInfo:decisionHandler:]):
1325 (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userIn fo:decisionHandler:]):
1326 (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNaviga tionAction:decisionHandler:]): Deleted.
1327 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:dec isionHandler:]): Deleted.
1328 (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationActio n:decisionHandler:]): Deleted.
1329 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:d ecisionHandler:]): Deleted.
1330 (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisi onHandler:]): Deleted.
1331
1332 2018-07-26 Andy VanWagoner <andy@vanwagoner.family>
1333
1334 [INTL] Remove INTL sub-feature compile flags
1335 https://bugs.webkit.org/show_bug.cgi?id=188081
1336
1337 Reviewed by Michael Catanzaro.
1338
1339 * Scripts/webkitperl/FeatureList.pm:
1340 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1341
1342 2018-07-26 Chris Dumez <cdumez@apple.com>
1343
1344 Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
1345 https://bugs.webkit.org/show_bug.cgi?id=188078
1346 <rdar://problem/42562493>
1347
1348 Reviewed by Geoff Garen.
1349
1350 Add API test coverage. It exercises the right code path but unfortunatel y is not yet a regression
1351 test because TestWebKitAPI does not appear to be sandboxed (rdar://probl em/42638129).
1352
1353 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1354 * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
1355 (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
1356 (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withE rror:]):
1357 (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
1358 (TEST):
1359
1360 2018-07-26 Aaron Chu <aaron_chu@apple.com>
1361
1362 Add Aaron Chu as a committer to contributors.json
1363 https://bugs.webkit.org/show_bug.cgi?id=188066
1364
1365 Unreviwed. Added myself as committer.
1366
1367 * Scripts/webkitpy/common/config/contributors.json:
1368
1369 2018-07-26 Aakash Jain <aakash_jain@apple.com>
1370
1371 [ews-build] Add build step to run API Tests
1372 https://bugs.webkit.org/show_bug.cgi?id=188079
1373
1374 Reviewed by Lucas Forschler.
1375
1376 * BuildSlaveSupport/ews-build/steps.py:
1377 (TestWithFailureCount): Common class for various tests with failure coun t.
1378 (TestWithFailureCount.start): Configure Buildbot's logobserver.
1379 (TestWithFailureCount.commandComplete): Updates the failure count.
1380 (TestWithFailureCount.evaluateCommand): Set the step status appropriatel y.
1381 (TestWithFailureCount.getResultSummary): Set the step summary appropriat ely.
1382 (RunAPITests): Build step to run API tests.
1383 (RunAPITests.countFailures): Count the failures by parsing the output.
1384 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1385
1386 2018-07-26 Ross Kirsling <ross.kirsling@sony.com>
1387
1388 String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1389 https://bugs.webkit.org/show_bug.cgi?id=187963
1390
1391 Reviewed by Alex Christensen.
1392
1393 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1394 Add tests for String::split and String::splitAllowingEmptyEntries.
1395
1396 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1397 * WebKitTestRunner/TestController.cpp:
1398 (WTR::updateTestOptionsFromTestHeader):
1399 Update split/splitAllowingEmptyEntries usage.
1400
1401 2018-07-26 Commit Queue <commit-queue@webkit.org>
1402
1403 Unreviewed, rolling out r234181 and r234189.
1404 https://bugs.webkit.org/show_bug.cgi?id=188075
1405
1406 These are not needed right now (Requested by thorton on
1407 #webkit).
1408
1409 Reverted changesets:
1410
1411 "Enable Web Content Filtering on watchOS"
1412 https://bugs.webkit.org/show_bug.cgi?id=187979
1413 https://trac.webkit.org/changeset/234181
1414
1415 "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1416 https://bugs.webkit.org/show_bug.cgi?id=187985
1417 https://trac.webkit.org/changeset/234189
1418
1419 2018-07-04 Darin Adler <darin@apple.com>
1420
1421 Improve WebGPU implementation, including using Metal Objective-C protoco ls more simply and correctly
1422 https://bugs.webkit.org/show_bug.cgi?id=187333
1423
1424 Reviewed by Sam Weinig.
1425
1426 * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
1427 * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
1428 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
1429 * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
1430 * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
1431
1432 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1433
1434 [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
1435 https://bugs.webkit.org/show_bug.cgi?id=188031
1436
1437 Reviewed by Lucas Forschler.
1438
1439 * BuildSlaveSupport/ews-build/steps.py:
1440 (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
1441 (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
1442 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1443
1444 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1445
1446 [ews-build] Add build step UploadBuiltProduct
1447 https://bugs.webkit.org/show_bug.cgi?id=188016
1448
1449 Reviewed by Lucas Forschler.
1450
1451 * BuildSlaveSupport/ews-build/steps.py:
1452 (UploadBuiltProduct): Added build step UploadBuiltProduct.
1453 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1454
1455 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1456
1457 [ews-build] Add build step ArchiveBuiltProduct
1458 https://bugs.webkit.org/show_bug.cgi?id=188014
1459
1460 Reviewed by Lucas Forschler.
1461
1462 * BuildSlaveSupport/ews-build/steps.py:
1463 (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
1464 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1465
1466 2018-07-25 Chris Dumez <cdumez@apple.com>
1467
1468 navigator.userAgent may return outdated value after webView.customUserAg ent is set
1469 https://bugs.webkit.org/show_bug.cgi?id=188009
1470 <rdar://problem/42566456>
1471
1472 Reviewed by Alex Christensen.
1473
1474 Add API test coverage.
1475
1476 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477 * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
1478 (TEST):
12 1479
13 2018-07-25 Charlie Turner <cturner@igalia.com> 1480 2018-07-25 Charlie Turner <cturner@igalia.com>
14 1481
15 [Flatpak] Pass more environment variables to sandbox 1482 [Flatpak] Pass more environment variables to sandbox
16 https://bugs.webkit.org/show_bug.cgi?id=188002 1483 https://bugs.webkit.org/show_bug.cgi?id=188002
17 1484
18 Reviewed by Michael Catanzaro. 1485 Reviewed by Michael Catanzaro.
19 1486
20 * flatpak/flatpakutils.py: 1487 * flatpak/flatpakutils.py:
21 (WebkitFlatpak.run_in_sandbox): 1488 (WebkitFlatpak.run_in_sandbox):
(...skipping 19725 matching lines...) Expand 10 before | Expand all | Expand 10 after
19747 Test two forms of storage to be sure we are using a different WebsiteDat aStore: cookies and sessionStorage. 21214 Test two forms of storage to be sure we are using a different WebsiteDat aStore: cookies and sessionStorage.
19748 21215
19749 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: 21216 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
19750 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]): 21217 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]):
19751 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]) : 21218 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]) :
19752 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan elWithMessage:initiatedByFrame:completionHandler:]): 21219 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan elWithMessage:initiatedByFrame:completionHandler:]):
19753 (websiteDataStoreTestWebView): 21220 (websiteDataStoreTestWebView):
19754 (TEST): 21221 (TEST):
19755 21222
19756 == Rolled over to ChangeLog-2018-01-01 == 21223 == Rolled over to ChangeLog-2018-01-01 ==
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b