LEFT | RIGHT |
1 2018-07-25 Ali Juma <ajuma@chromium.org> | 1 2018-08-08 Ali Juma <ajuma@chromium.org> |
2 | 2 |
3 Implement IntersectionObserver | 3 Implement IntersectionObserver |
4 https://bugs.webkit.org/show_bug.cgi?id=159475 | 4 https://bugs.webkit.org/show_bug.cgi?id=159475 |
5 | 5 |
6 Reviewed by NOBODY (OOPS!). | 6 Reviewed by NOBODY (OOPS!). |
7 | 7 |
| 8 * DumpRenderTree/TestOptions.cpp: |
| 9 (TestOptions::TestOptions): |
| 10 * DumpRenderTree/TestOptions.h: |
8 * DumpRenderTree/mac/DumpRenderTree.mm: | 11 * DumpRenderTree/mac/DumpRenderTree.mm: |
9 (enableExperimentalFeatures): | 12 (enableExperimentalFeatures): |
| 13 (setWebPreferencesForTestOptions): |
10 * WebKitTestRunner/TestController.cpp: | 14 * WebKitTestRunner/TestController.cpp: |
11 (WTR::TestController::resetPreferencesToConsistentValues): | 15 (WTR::TestController::resetPreferencesToConsistentValues): |
| 16 |
| 17 2018-08-10 David Fenton <david_fenton@apple.com> |
| 18 |
| 19 Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and
TestWebKitAPI.PreferredAudioBufferSize.WebAudio. |
| 20 https://bugs.webkit.org/show_bug.cgi?id=188470. |
| 21 |
| 22 Unreviewed test gardening, disabling the tests. |
| 23 |
| 24 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm: |
| 25 (TEST_F): |
| 26 |
| 27 2018-08-10 Joseph Pecoraro <pecoraro@apple.com> |
| 28 |
| 29 Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools |
| 30 https://bugs.webkit.org/show_bug.cgi?id=188458 |
| 31 |
| 32 Reviewed by Alex Christensen. |
| 33 |
| 34 * Scripts/webkitpy/layout_tests/models/test_expectations.py: |
| 35 (TestExpectationParser): |
| 36 * TestResultServer/static-dashboards/flakiness_dashboard.js: |
| 37 |
| 38 2018-08-09 Fujii Hironori <Hironori.Fujii@sony.com> |
| 39 |
| 40 [webkitpy][Win] LayoutTests: test names should be Unix style, separated
by slash not backslash |
| 41 https://bugs.webkit.org/show_bug.cgi?id=187973 |
| 42 |
| 43 Reviewed by Alex Christensen. |
| 44 |
| 45 In LayoutTests, test names have been canonicalized in Unix style |
| 46 since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219, |
| 47 Bug 179572, Bug 180660 and Bug 181814 have changed to use |
| 48 os.path.seq instead of slash if Windows Python is used. |
| 49 |
| 50 Revert parts of those changes. Change relative_test_filename to |
| 51 return a slash sperated test name as well as chromium_win.py used |
| 52 to do. |
| 53 |
| 54 This change fixes all 41 test-webkitpy failures in WinCairo port. |
| 55 |
| 56 * Scripts/webkitpy/layout_tests/models/test_expectations.py: |
| 57 (TestExpectationParser._parse_line): Do not convert a test name by using
normpath. |
| 58 * Scripts/webkitpy/port/base.py: |
| 59 (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.s
ep. |
| 60 (Port.relative_test_filename): Replace self.host.filesystem.sep with sel
f.TEST_PATH_SEPARATOR. |
| 61 (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR. |
| 62 * Scripts/webkitpy/port/driver.py: |
| 63 (Driver): Use '/' instead of os.sep. |
| 64 * Scripts/webkitpy/port/win.py: |
| 65 (WinCairoPort): Do not override TEST_PATH_SEPARATOR. |
| 66 |
| 67 2018-08-09 Thomas Denney <tdenney@apple.com> |
| 68 |
| 69 [WHLSL] Add individual test durations to output |
| 70 https://bugs.webkit.org/show_bug.cgi?id=188448 |
| 71 |
| 72 Reviewed by Myles C. Maxfield. |
| 73 |
| 74 * WebGPUShadingLanguageRI/Test.js: Add timing output. |
| 75 |
| 76 2018-08-09 Ben Richards <benton_richards@apple.com> |
| 77 |
| 78 We should cache the compiled sandbox profile in a data vault |
| 79 https://bugs.webkit.org/show_bug.cgi?id=184991 |
| 80 |
| 81 Reviewed by Ryosuke Niwa. |
| 82 |
| 83 Added trace points for sandbox initialization |
| 84 |
| 85 * Tracing/SystemTracePoints.plist: |
| 86 |
| 87 2018-08-09 Jer Noble <jer.noble@apple.com> |
| 88 |
| 89 Video playback is using more power |
| 90 https://bugs.webkit.org/show_bug.cgi?id=188452 |
| 91 <rdar://problem/42298937> |
| 92 |
| 93 Reviewed by Eric Carlson. |
| 94 |
| 95 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm: |
| 96 (PreferredAudioBufferSize::createView): |
| 97 (PreferredAudioBufferSize::preferredAudioBufferSize const): |
| 98 (TEST_F): |
| 99 |
| 100 2018-08-09 Alex Christensen <achristensen@webkit.org> |
| 101 |
| 102 REGRESSION(234640) Loading stalls in environments without SafariSafeBrow
sing framework |
| 103 https://bugs.webkit.org/show_bug.cgi?id=188453 |
| 104 <rdar://problem/43102553> |
| 105 |
| 106 Reviewed by Chris Dumez |
| 107 |
| 108 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: |
| 109 (TEST): |
| 110 (+[NullLookupContext sharedLookupContext]): |
| 111 (TestWebKitAPI::TEST): Deleted. |
| 112 |
| 113 2018-08-09 Alex Christensen <achristensen@webkit.org> |
| 114 |
| 115 WKURLSchemeHandler crashes when sent errors with sync XHR |
| 116 https://bugs.webkit.org/show_bug.cgi?id=188358 |
| 117 |
| 118 Reviewed by Chris Dumez. |
| 119 |
| 120 * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: |
| 121 (-[SyncErrorScheme webView:startURLSchemeTask:]): |
| 122 (-[SyncErrorScheme webView:stopURLSchemeTask:]): |
| 123 (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedB
yFrame:completionHandler:]): |
| 124 |
| 125 2018-08-09 Per Arne Vollan <pvollan@apple.com> |
| 126 |
| 127 REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.ht
ml is failing |
| 128 https://bugs.webkit.org/show_bug.cgi?id=188397 |
| 129 |
| 130 Reviewed by Tim Horton. |
| 131 |
| 132 After r234652, [NSScroller preferredScrollerStyle] is called in the UI p
rocess, and we need to set the same |
| 133 user defaults related to scrollbars in the UI process as we do in the We
bProcess. |
| 134 |
| 135 * WebKitTestRunner/mac/main.mm: |
| 136 (setDefaultsToConsistentValuesForTesting): |
| 137 |
| 138 2018-08-09 Wenson Hsieh <wenson_hsieh@apple.com> |
| 139 |
| 140 [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSi
mulator |
| 141 https://bugs.webkit.org/show_bug.cgi?id=188439 |
| 142 |
| 143 Reviewed by Andy Estes and Megan Gardner. |
| 144 |
| 145 Refactor DataInteractionSimulator (currently used for drag and drop test
ing on iOS) so that it exists across |
| 146 macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rena
me DataInteractionTests to |
| 147 DragAndDropTests. |
| 148 |
| 149 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: |
| 150 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: |
| 151 (TestWebKitAPI::TEST): |
| 152 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/Tes
tWebKitAPI/Tests/ios/DataInteractionTests.mm. |
| 153 (testIconImage): |
| 154 (testZIPArchive): |
| 155 (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]
): |
| 156 (-[TestWKWebView editorContainsImageElement]): |
| 157 (-[TestWKWebView editorValue]): |
| 158 (makeCGRectValue): |
| 159 (checkCGRectIsEqualToCGRectWithLogging): |
| 160 (checkSelectionRectsWithLogging): |
| 161 (checkRichTextTypePrecedesPlainTextType): |
| 162 (checkFirstTypeIsPresentAndSecondTypeIsMissing): |
| 163 (checkTypeIdentifierIsRegisteredAtIndex): |
| 164 (checkEstimatedSize): |
| 165 (checkSuggestedNameAndEstimatedSize): |
| 166 (checkStringArraysAreEqual): |
| 167 (checkDragCaretRectIsContainedInRect): |
| 168 (checkJSONWithLogging): |
| 169 (testIconImageData): |
| 170 (runTestWithTemporaryTextFile): |
| 171 (runTestWithTemporaryFolder): |
| 172 (TestWebKitAPI::TEST): |
| 173 (TestWebKitAPI::setUpTestWebViewForDataTransferItems): |
| 174 (TestWebKitAPI::testDragAndDropOntoTargetElements): |
| 175 (TestWebKitAPI::testIconImageData): |
| 176 * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWeb
KitAPI/ios/DataInteractionSimulator.h. |
| 177 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestW
ebKitAPI/ios/DataInteractionSimulator.mm. |
| 178 (-[WKWebView dropInteractionDelegate]): |
| 179 (-[WKWebView dragInteractionDelegate]): |
| 180 (-[WKWebView dropInteraction]): |
| 181 (-[WKWebView dragInteraction]): |
| 182 (-[MockDragDropSession initWithItems:location:window:allowMove:]): |
| 183 (-[MockDragDropSession allowsMoveOperation]): |
| 184 (-[MockDragDropSession isRestrictedToDraggingApplication]): |
| 185 (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]): |
| 186 (-[MockDragDropSession canLoadObjectsOfClass:]): |
| 187 (-[MockDragDropSession canLoadObjectsOfClasses:]): |
| 188 (-[MockDragDropSession items]): |
| 189 (-[MockDragDropSession setItems:]): |
| 190 (-[MockDragDropSession addItems:]): |
| 191 (-[MockDragDropSession locationInView:]): |
| 192 (-[MockDropSession initWithProviders:location:window:allowMove:]): |
| 193 (-[MockDropSession isLocal]): |
| 194 (-[MockDropSession progress]): |
| 195 (-[MockDropSession setProgressIndicatorStyle:]): |
| 196 (-[MockDropSession progressIndicatorStyle]): |
| 197 (-[MockDropSession operationMask]): |
| 198 (-[MockDropSession localDragSession]): |
| 199 (-[MockDropSession hasItemsConformingToTypeIdentifier:]): |
| 200 (-[MockDropSession canCreateItemsOfClass:]): |
| 201 (-[MockDropSession loadObjectsOfClass:completion:]): |
| 202 (-[MockDragSession initWithWindow:allowMove:]): |
| 203 (-[MockDragSession localOperationMask]): |
| 204 (-[MockDragSession externalOperationMask]): |
| 205 (-[MockDragSession session]): |
| 206 (-[MockDragSession localContext]): |
| 207 (-[MockDragSession setLocalContext:]): |
| 208 (dragAndDropEventNames): |
| 209 (-[DragAndDropSimulatorApplication _cancelAllTouches]): |
| 210 (-[DragAndDropSimulator initWithWebView:]): |
| 211 (-[DragAndDropSimulator dealloc]): |
| 212 (-[DragAndDropSimulator _resetSimulatedState]): |
| 213 (-[DragAndDropSimulator observedEventNames]): |
| 214 (-[DragAndDropSimulator simulateAllTouchesCanceled:]): |
| 215 (-[DragAndDropSimulator runFrom:to:]): |
| 216 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]): |
| 217 (-[DragAndDropSimulator finalSelectionRects]): |
| 218 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]): |
| 219 (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]): |
| 220 (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]): |
| 221 (-[DragAndDropSimulator _advanceProgress]): |
| 222 (-[DragAndDropSimulator _currentLocation]): |
| 223 (-[DragAndDropSimulator _scheduleAdvanceProgress]): |
| 224 (-[DragAndDropSimulator sourceItemProviders]): |
| 225 (-[DragAndDropSimulator externalItemProviders]): |
| 226 (-[DragAndDropSimulator setExternalItemProviders:]): |
| 227 (-[DragAndDropSimulator phase]): |
| 228 (-[DragAndDropSimulator liftPreviews]): |
| 229 (-[DragAndDropSimulator lastKnownDragCaretRect]): |
| 230 (-[DragAndDropSimulator waitForInputSession]): |
| 231 (-[DragAndDropSimulator insertedAttachments]): |
| 232 (-[DragAndDropSimulator removedAttachments]): |
| 233 (-[DragAndDropSimulator endDataTransfer]): |
| 234 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forS
ession:itemProviders:]): |
| 235 (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOpe
ration:forSession:]): |
| 236 (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersFor
ItemProvider:representingObjects:additionalData:]): |
| 237 (-[DragAndDropSimulator _webView:showCustomSheetForElement:]): |
| 238 (-[DragAndDropSimulator _webView:willPerformDropWithSession:]): |
| 239 (-[DragAndDropSimulator _webView:didInsertAttachment:]): |
| 240 (-[DragAndDropSimulator _webView:didRemoveAttachment:]): |
| 241 (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]): |
| 242 (-[DragAndDropSimulator _webView:didStartInputSession:]): |
| 243 * TestWebKitAPI/ios/UIKitSPI.h: |
| 244 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added. |
| 245 (-[DragAndDropSimulator initWithWebView:]): |
| 246 (-[DragAndDropSimulator dealloc]): |
| 247 (-[DragAndDropSimulator runFrom:to:]): |
| 248 (-[DragAndDropSimulator insertedAttachments]): |
| 249 (-[DragAndDropSimulator removedAttachments]): |
| 250 |
| 251 2018-08-09 Sihui Liu <sihui_liu@apple.com> |
| 252 |
| 253 REGRESSION (r232083): WKWebView loses first-party cookies on iOS |
| 254 https://bugs.webkit.org/show_bug.cgi?id=188443 |
| 255 <rdar://problem/42991584> |
| 256 |
| 257 Reviewed by Chris Dumez. |
| 258 |
| 259 Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS. |
| 260 |
| 261 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: |
| 262 |
| 263 2018-08-09 Ross Kirsling <ross.kirsling@sony.com> |
| 264 |
| 265 Unreviewed follow-up fix for r234720. |
| 266 |
| 267 * Scripts/webkitpy/bindings/main.py: |
| 268 (BindingsTests.close_and_remove): |
| 269 (BindingsTests.main): |
| 270 Return to the original approach, since this seems to be the simplest cro
ss-platform solution. |
| 271 |
| 272 2018-08-09 Ali Juma <ajuma@chromium.org> |
| 273 |
| 274 Import WPTs for IntersectionObserver |
| 275 https://bugs.webkit.org/show_bug.cgi?id=188416 |
| 276 |
| 277 Reviewed by Simon Fraser. |
| 278 |
| 279 Enable IntersectionObserver in DumpRenderTree.· |
| 280 |
| 281 * DumpRenderTree/mac/DumpRenderTree.mm: |
| 282 (enableExperimentalFeatures): |
| 283 (setWebPreferencesForTestOptions): |
| 284 * WebKitTestRunner/TestController.cpp: |
| 285 (WTR::TestController::resetPreferencesToConsistentValues): |
| 286 |
| 287 2018-08-08 Ross Kirsling <ross.kirsling@sony.com> |
| 288 |
| 289 run-bindings-tests is not Win32-compatible |
| 290 https://bugs.webkit.org/show_bug.cgi?id=188424 |
| 291 |
| 292 Reviewed by Fujii Hironori. |
| 293 |
| 294 * Scripts/webkitpy/bindings/main.py: |
| 295 (BindingsTests.main): |
| 296 Stop leaking file descriptors. |
| 297 (See https://www.logilab.org/blogentry/17873 for details, though the sol
ution here is even simpler.) |
| 298 |
| 299 2018-08-08 Alex Christensen <achristensen@webkit.org> |
| 300 |
| 301 Fix possible null dereference in WebBackForwardList::restoreFromState |
| 302 https://bugs.webkit.org/show_bug.cgi?id=188418 |
| 303 <rdar://problem/42531726> |
| 304 |
| 305 Reviewed by Chris Dumez. |
| 306 |
| 307 * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp: |
| 308 (TestWebKitAPI::TEST): |
| 309 |
| 310 2018-08-08 Ross Kirsling <ross.kirsling@sony.com> |
| 311 |
| 312 run-builtins-generator-tests does not correctly handle CRLFs from stderr |
| 313 https://bugs.webkit.org/show_bug.cgi?id=188392 |
| 314 |
| 315 Reviewed by Fujii Hironori. |
| 316 |
| 317 Background: |
| 318 file.write converts LF to os.linesep, so if the input string contains CR
LF, we end up writing CRCRLF to the file. |
| 319 |
| 320 * Scripts/webkitpy/common/system/executive.py: |
| 321 (Executive.run_command): |
| 322 Normalize CRLF to LF in decoded stdout/stderr data, so that we don't ret
urn consumers a platform-specific string. |
| 323 |
| 324 2018-08-08 Aditya Keerthi <akeerthi@apple.com> |
| 325 |
| 326 Unreviewed, add myself to committers list. |
| 327 |
| 328 * Scripts/webkitpy/common/config/contributors.json: |
| 329 |
| 330 2018-08-08 Commit Queue <commit-queue@webkit.org> |
| 331 |
| 332 Unreviewed, rolling out r234314, r234320, and r234321. |
| 333 https://bugs.webkit.org/show_bug.cgi?id=188414 |
| 334 |
| 335 Caused email sign in issue (Requested by ryanhaddad on |
| 336 #webkit). |
| 337 |
| 338 Reverted changesets: |
| 339 |
| 340 "Remove unused WKNavigationDelegatePrivate |
| 341 decidePolicyForNavigationAction SPI" |
| 342 https://bugs.webkit.org/show_bug.cgi?id=188077 |
| 343 https://trac.webkit.org/changeset/234314 |
| 344 |
| 345 "Fix API tests after r234314" |
| 346 https://bugs.webkit.org/show_bug.cgi?id=188077 |
| 347 https://trac.webkit.org/changeset/234320 |
| 348 |
| 349 "Fix API tests after r234314" |
| 350 https://bugs.webkit.org/show_bug.cgi?id=188077 |
| 351 https://trac.webkit.org/changeset/234321 |
12 | 352 |
13 2018-08-08 Wenson Hsieh <wenson_hsieh@apple.com> | 353 2018-08-08 Wenson Hsieh <wenson_hsieh@apple.com> |
14 | 354 |
15 [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky fai
lure | 355 [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky fai
lure |
16 https://bugs.webkit.org/show_bug.cgi?id=188401 | 356 https://bugs.webkit.org/show_bug.cgi?id=188401 |
17 <rdar://problem/32542300> | 357 <rdar://problem/32542300> |
18 | 358 |
19 Reviewed by Ryosuke Niwa. | 359 Reviewed by Ryosuke Niwa. |
20 | 360 |
21 When run individually, fast/events/ios/contenteditable-autocapitalize.ht
ml passes consistently; however, when | 361 When run individually, fast/events/ios/contenteditable-autocapitalize.ht
ml passes consistently; however, when |
(...skipping 20852 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
20874 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. | 21214 Test two forms of storage to be sure we are using a different WebsiteDat
aStore: cookies and sessionStorage. |
20875 | 21215 |
20876 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: | 21216 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: |
20877 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): | 21217 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig
ationAction:decisionHandler:]): |
20878 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: | 21218 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:])
: |
20879 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): | 21219 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan
elWithMessage:initiatedByFrame:completionHandler:]): |
20880 (websiteDataStoreTestWebView): | 21220 (websiteDataStoreTestWebView): |
20881 (TEST): | 21221 (TEST): |
20882 | 21222 |
20883 == Rolled over to ChangeLog-2018-01-01 == | 21223 == Rolled over to ChangeLog-2018-01-01 == |
LEFT | RIGHT |