Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(467)

Delta Between Two Patch Sets: Tools/ChangeLog

Issue 359780043: WIP for IO
Left Patch Set: Passes 24 out of 25 tests Created 5 years, 8 months ago
Right Patch Set: Fix inline test while making sure the text test still passes too. Created 5 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h ('k') | Tools/DumpRenderTree/TestOptions.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 2018-07-12 Ali Juma <ajuma@chromium.org> 1 2018-08-08 Ali Juma <ajuma@chromium.org>
2 2
3 Implement IntersectionObserver 3 Implement IntersectionObserver
4 https://bugs.webkit.org/show_bug.cgi?id=159475 4 https://bugs.webkit.org/show_bug.cgi?id=159475
5 5
6 Reviewed by NOBODY (OOPS!). 6 Reviewed by NOBODY (OOPS!).
7
8 * DumpRenderTree/TestOptions.cpp:
9 (TestOptions::TestOptions):
10 * DumpRenderTree/TestOptions.h:
11 * DumpRenderTree/mac/DumpRenderTree.mm:
12 (enableExperimentalFeatures):
13 (setWebPreferencesForTestOptions):
14 * WebKitTestRunner/TestController.cpp:
15 (WTR::TestController::resetPreferencesToConsistentValues):
16
17 2018-08-10 David Fenton <david_fenton@apple.com>
18
19 Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
20 https://bugs.webkit.org/show_bug.cgi?id=188470.
21
22 Unreviewed test gardening, disabling the tests.
23
24 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
25 (TEST_F):
26
27 2018-08-10 Joseph Pecoraro <pecoraro@apple.com>
28
29 Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
30 https://bugs.webkit.org/show_bug.cgi?id=188458
31
32 Reviewed by Alex Christensen.
33
34 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
35 (TestExpectationParser):
36 * TestResultServer/static-dashboards/flakiness_dashboard.js:
37
38 2018-08-09 Fujii Hironori <Hironori.Fujii@sony.com>
39
40 [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
41 https://bugs.webkit.org/show_bug.cgi?id=187973
42
43 Reviewed by Alex Christensen.
44
45 In LayoutTests, test names have been canonicalized in Unix style
46 since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
47 Bug 179572, Bug 180660 and Bug 181814 have changed to use
48 os.path.seq instead of slash if Windows Python is used.
49
50 Revert parts of those changes. Change relative_test_filename to
51 return a slash sperated test name as well as chromium_win.py used
52 to do.
53
54 This change fixes all 41 test-webkitpy failures in WinCairo port.
55
56 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
57 (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
58 * Scripts/webkitpy/port/base.py:
59 (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.s ep.
60 (Port.relative_test_filename): Replace self.host.filesystem.sep with sel f.TEST_PATH_SEPARATOR.
61 (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
62 * Scripts/webkitpy/port/driver.py:
63 (Driver): Use '/' instead of os.sep.
64 * Scripts/webkitpy/port/win.py:
65 (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
66
67 2018-08-09 Thomas Denney <tdenney@apple.com>
68
69 [WHLSL] Add individual test durations to output
70 https://bugs.webkit.org/show_bug.cgi?id=188448
71
72 Reviewed by Myles C. Maxfield.
73
74 * WebGPUShadingLanguageRI/Test.js: Add timing output.
75
76 2018-08-09 Ben Richards <benton_richards@apple.com>
77
78 We should cache the compiled sandbox profile in a data vault
79 https://bugs.webkit.org/show_bug.cgi?id=184991
80
81 Reviewed by Ryosuke Niwa.
82
83 Added trace points for sandbox initialization
84
85 * Tracing/SystemTracePoints.plist:
86
87 2018-08-09 Jer Noble <jer.noble@apple.com>
88
89 Video playback is using more power
90 https://bugs.webkit.org/show_bug.cgi?id=188452
91 <rdar://problem/42298937>
92
93 Reviewed by Eric Carlson.
94
95 * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
96 (PreferredAudioBufferSize::createView):
97 (PreferredAudioBufferSize::preferredAudioBufferSize const):
98 (TEST_F):
99
100 2018-08-09 Alex Christensen <achristensen@webkit.org>
101
102 REGRESSION(234640) Loading stalls in environments without SafariSafeBrow sing framework
103 https://bugs.webkit.org/show_bug.cgi?id=188453
104 <rdar://problem/43102553>
105
106 Reviewed by Chris Dumez
107
108 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
109 (TEST):
110 (+[NullLookupContext sharedLookupContext]):
111 (TestWebKitAPI::TEST): Deleted.
112
113 2018-08-09 Alex Christensen <achristensen@webkit.org>
114
115 WKURLSchemeHandler crashes when sent errors with sync XHR
116 https://bugs.webkit.org/show_bug.cgi?id=188358
117
118 Reviewed by Chris Dumez.
119
120 * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
121 (-[SyncErrorScheme webView:startURLSchemeTask:]):
122 (-[SyncErrorScheme webView:stopURLSchemeTask:]):
123 (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedB yFrame:completionHandler:]):
124
125 2018-08-09 Per Arne Vollan <pvollan@apple.com>
126
127 REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.ht ml is failing
128 https://bugs.webkit.org/show_bug.cgi?id=188397
129
130 Reviewed by Tim Horton.
131
132 After r234652, [NSScroller preferredScrollerStyle] is called in the UI p rocess, and we need to set the same
133 user defaults related to scrollbars in the UI process as we do in the We bProcess.
134
135 * WebKitTestRunner/mac/main.mm:
136 (setDefaultsToConsistentValuesForTesting):
137
138 2018-08-09 Wenson Hsieh <wenson_hsieh@apple.com>
139
140 [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSi mulator
141 https://bugs.webkit.org/show_bug.cgi?id=188439
142
143 Reviewed by Andy Estes and Megan Gardner.
144
145 Refactor DataInteractionSimulator (currently used for drag and drop test ing on iOS) so that it exists across
146 macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rena me DataInteractionTests to
147 DragAndDropTests.
148
149 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
150 * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
151 (TestWebKitAPI::TEST):
152 * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/Tes tWebKitAPI/Tests/ios/DataInteractionTests.mm.
153 (testIconImage):
154 (testZIPArchive):
155 (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:] ):
156 (-[TestWKWebView editorContainsImageElement]):
157 (-[TestWKWebView editorValue]):
158 (makeCGRectValue):
159 (checkCGRectIsEqualToCGRectWithLogging):
160 (checkSelectionRectsWithLogging):
161 (checkRichTextTypePrecedesPlainTextType):
162 (checkFirstTypeIsPresentAndSecondTypeIsMissing):
163 (checkTypeIdentifierIsRegisteredAtIndex):
164 (checkEstimatedSize):
165 (checkSuggestedNameAndEstimatedSize):
166 (checkStringArraysAreEqual):
167 (checkDragCaretRectIsContainedInRect):
168 (checkJSONWithLogging):
169 (testIconImageData):
170 (runTestWithTemporaryTextFile):
171 (runTestWithTemporaryFolder):
172 (TestWebKitAPI::TEST):
173 (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
174 (TestWebKitAPI::testDragAndDropOntoTargetElements):
175 (TestWebKitAPI::testIconImageData):
176 * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWeb KitAPI/ios/DataInteractionSimulator.h.
177 * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestW ebKitAPI/ios/DataInteractionSimulator.mm.
178 (-[WKWebView dropInteractionDelegate]):
179 (-[WKWebView dragInteractionDelegate]):
180 (-[WKWebView dropInteraction]):
181 (-[WKWebView dragInteraction]):
182 (-[MockDragDropSession initWithItems:location:window:allowMove:]):
183 (-[MockDragDropSession allowsMoveOperation]):
184 (-[MockDragDropSession isRestrictedToDraggingApplication]):
185 (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
186 (-[MockDragDropSession canLoadObjectsOfClass:]):
187 (-[MockDragDropSession canLoadObjectsOfClasses:]):
188 (-[MockDragDropSession items]):
189 (-[MockDragDropSession setItems:]):
190 (-[MockDragDropSession addItems:]):
191 (-[MockDragDropSession locationInView:]):
192 (-[MockDropSession initWithProviders:location:window:allowMove:]):
193 (-[MockDropSession isLocal]):
194 (-[MockDropSession progress]):
195 (-[MockDropSession setProgressIndicatorStyle:]):
196 (-[MockDropSession progressIndicatorStyle]):
197 (-[MockDropSession operationMask]):
198 (-[MockDropSession localDragSession]):
199 (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
200 (-[MockDropSession canCreateItemsOfClass:]):
201 (-[MockDropSession loadObjectsOfClass:completion:]):
202 (-[MockDragSession initWithWindow:allowMove:]):
203 (-[MockDragSession localOperationMask]):
204 (-[MockDragSession externalOperationMask]):
205 (-[MockDragSession session]):
206 (-[MockDragSession localContext]):
207 (-[MockDragSession setLocalContext:]):
208 (dragAndDropEventNames):
209 (-[DragAndDropSimulatorApplication _cancelAllTouches]):
210 (-[DragAndDropSimulator initWithWebView:]):
211 (-[DragAndDropSimulator dealloc]):
212 (-[DragAndDropSimulator _resetSimulatedState]):
213 (-[DragAndDropSimulator observedEventNames]):
214 (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
215 (-[DragAndDropSimulator runFrom:to:]):
216 (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
217 (-[DragAndDropSimulator finalSelectionRects]):
218 (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
219 (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
220 (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
221 (-[DragAndDropSimulator _advanceProgress]):
222 (-[DragAndDropSimulator _currentLocation]):
223 (-[DragAndDropSimulator _scheduleAdvanceProgress]):
224 (-[DragAndDropSimulator sourceItemProviders]):
225 (-[DragAndDropSimulator externalItemProviders]):
226 (-[DragAndDropSimulator setExternalItemProviders:]):
227 (-[DragAndDropSimulator phase]):
228 (-[DragAndDropSimulator liftPreviews]):
229 (-[DragAndDropSimulator lastKnownDragCaretRect]):
230 (-[DragAndDropSimulator waitForInputSession]):
231 (-[DragAndDropSimulator insertedAttachments]):
232 (-[DragAndDropSimulator removedAttachments]):
233 (-[DragAndDropSimulator endDataTransfer]):
234 (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forS ession:itemProviders:]):
235 (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOpe ration:forSession:]):
236 (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersFor ItemProvider:representingObjects:additionalData:]):
237 (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
238 (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
239 (-[DragAndDropSimulator _webView:didInsertAttachment:]):
240 (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
241 (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
242 (-[DragAndDropSimulator _webView:didStartInputSession:]):
243 * TestWebKitAPI/ios/UIKitSPI.h:
244 * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
245 (-[DragAndDropSimulator initWithWebView:]):
246 (-[DragAndDropSimulator dealloc]):
247 (-[DragAndDropSimulator runFrom:to:]):
248 (-[DragAndDropSimulator insertedAttachments]):
249 (-[DragAndDropSimulator removedAttachments]):
250
251 2018-08-09 Sihui Liu <sihui_liu@apple.com>
252
253 REGRESSION (r232083): WKWebView loses first-party cookies on iOS
254 https://bugs.webkit.org/show_bug.cgi?id=188443
255 <rdar://problem/42991584>
256
257 Reviewed by Chris Dumez.
258
259 Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
260
261 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
262
263 2018-08-09 Ross Kirsling <ross.kirsling@sony.com>
264
265 Unreviewed follow-up fix for r234720.
266
267 * Scripts/webkitpy/bindings/main.py:
268 (BindingsTests.close_and_remove):
269 (BindingsTests.main):
270 Return to the original approach, since this seems to be the simplest cro ss-platform solution.
271
272 2018-08-09 Ali Juma <ajuma@chromium.org>
273
274 Import WPTs for IntersectionObserver
275 https://bugs.webkit.org/show_bug.cgi?id=188416
276
277 Reviewed by Simon Fraser.
278
279 Enable IntersectionObserver in DumpRenderTree.·
280
281 * DumpRenderTree/mac/DumpRenderTree.mm:
282 (enableExperimentalFeatures):
283 (setWebPreferencesForTestOptions):
284 * WebKitTestRunner/TestController.cpp:
285 (WTR::TestController::resetPreferencesToConsistentValues):
286
287 2018-08-08 Ross Kirsling <ross.kirsling@sony.com>
288
289 run-bindings-tests is not Win32-compatible
290 https://bugs.webkit.org/show_bug.cgi?id=188424
291
292 Reviewed by Fujii Hironori.
293
294 * Scripts/webkitpy/bindings/main.py:
295 (BindingsTests.main):
296 Stop leaking file descriptors.
297 (See https://www.logilab.org/blogentry/17873 for details, though the sol ution here is even simpler.)
298
299 2018-08-08 Alex Christensen <achristensen@webkit.org>
300
301 Fix possible null dereference in WebBackForwardList::restoreFromState
302 https://bugs.webkit.org/show_bug.cgi?id=188418
303 <rdar://problem/42531726>
304
305 Reviewed by Chris Dumez.
306
307 * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
308 (TestWebKitAPI::TEST):
309
310 2018-08-08 Ross Kirsling <ross.kirsling@sony.com>
311
312 run-builtins-generator-tests does not correctly handle CRLFs from stderr
313 https://bugs.webkit.org/show_bug.cgi?id=188392
314
315 Reviewed by Fujii Hironori.
316
317 Background:
318 file.write converts LF to os.linesep, so if the input string contains CR LF, we end up writing CRCRLF to the file.
319
320 * Scripts/webkitpy/common/system/executive.py:
321 (Executive.run_command):
322 Normalize CRLF to LF in decoded stdout/stderr data, so that we don't ret urn consumers a platform-specific string.
323
324 2018-08-08 Aditya Keerthi <akeerthi@apple.com>
325
326 Unreviewed, add myself to committers list.
327
328 * Scripts/webkitpy/common/config/contributors.json:
329
330 2018-08-08 Commit Queue <commit-queue@webkit.org>
331
332 Unreviewed, rolling out r234314, r234320, and r234321.
333 https://bugs.webkit.org/show_bug.cgi?id=188414
334
335 Caused email sign in issue (Requested by ryanhaddad on
336 #webkit).
337
338 Reverted changesets:
339
340 "Remove unused WKNavigationDelegatePrivate
341 decidePolicyForNavigationAction SPI"
342 https://bugs.webkit.org/show_bug.cgi?id=188077
343 https://trac.webkit.org/changeset/234314
344
345 "Fix API tests after r234314"
346 https://bugs.webkit.org/show_bug.cgi?id=188077
347 https://trac.webkit.org/changeset/234320
348
349 "Fix API tests after r234314"
350 https://bugs.webkit.org/show_bug.cgi?id=188077
351 https://trac.webkit.org/changeset/234321
352
353 2018-08-08 Wenson Hsieh <wenson_hsieh@apple.com>
354
355 [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky fai lure
356 https://bugs.webkit.org/show_bug.cgi?id=188401
357 <rdar://problem/32542300>
358
359 Reviewed by Ryosuke Niwa.
360
361 When run individually, fast/events/ios/contenteditable-autocapitalize.ht ml passes consistently; however, when
362 run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
363 is because each of the three steps of this test ends when UIScriptContro ller's `didHideKeyboardCallback` is
364 invoked, and if the keyboard only begins to dismiss after the previous t est completes, we have a race. When the
365 keyboard finishes dismissing after the UI script is evaluated, it will t rigger UI script completion early and
366 skip over one of the steps in the layout test, resulting in a text diff failure.
367
368 To fix this, add a mechanism in WebKitTestRunner to wait until the keybo ard is dismissed (with a short timeout)
369 as a part of resetting test controller state, before moving on to the ne xt layout test.
370
371 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
372 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
373 (-[TestRunnerWKWebView didStartFormControlInteraction]):
374 (-[TestRunnerWKWebView didEndFormControlInteraction]):
375
376 Use these hooks to keep track of whether the previous test is presenting any form input UI.
377
378 (-[TestRunnerWKWebView isInteractingWithFormControl]):
379 * WebKitTestRunner/ios/TestControllerIOS.mm:
380 (WTR::handleKeyboardWillHideNotification):
381 (WTR::handleKeyboardDidHideNotification):
382 (WTR::TestController::platformInitialize):
383 (WTR::TestController::platformDestroy):
384
385 Register during initialization (and unregister during teardown) for keyb oard hiding notifications, to keep track
386 of when the keyboard dismissal animation ends.
387
388 (WTR::TestController::platformResetStateToConsistentValues):
389
390 Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
391 which causes the field to lose focus. (2) If necessary, wait for the cur rent keyboard dismissal animation to
392 finish. This includes any keyboard dismissal animations triggered as a r esult of step (1).
393
394 2018-08-05 Darin Adler <darin@apple.com>
395
396 [Cocoa] More tweaks and refactoring to prepare for ARC
397 https://bugs.webkit.org/show_bug.cgi?id=188245
398
399 Reviewed by Dan Bernstein.
400
401 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
402 CFTypeRef instead of void*.
403
404 * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
405 (createCoreAnimationLayer): Use CFBridgingRetain.
406
407 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
408 (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
409 (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
410 (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
411 (AccessibilityUIElement::textMarkerRangeLength): Ditto.
412 (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttri bute): Ditto.
413 (AccessibilityUIElement::indexForTextMarker): Ditto.
414 (AccessibilityUIElement::textMarkerForIndex): Ditto.
415 (AccessibilityUIElement::isTextMarkerValid): Ditto.
416 (AccessibilityUIElement::previousTextMarker): Ditto.
417 (AccessibilityUIElement::nextTextMarker): Ditto.
418 (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
419 (createJSStringRef): Ditto.
420 (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
421 (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
422 (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
423 (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
424 (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
425 (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
426 (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
427 (AccessibilityUIElement::textMarkerForPoint): Ditto.
428 (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
429 (AccessibilityUIElement::startTextMarker): Ditto.
430 (AccessibilityUIElement::endTextMarker): Ditto.
431 (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
432 (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
433 (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
434 (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditt o.
435 (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
436 (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
437 (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
438 (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto .
439 (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
440 (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
441 (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
442
443 * DumpRenderTree/mac/DumpRenderTree.mm:
444 (resetWebPreferencesToConsistentValues): Use bridging cast.
445 (dumpFramesAsText): Ditto.
446 (dumpBackForwardListForAllWindows): Use a modern for loop instead of
447 CFArray functions to iterate the array.
448 (dump): Use bridging cast.
449 (runTest): Ditto.
450
451 * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
452 (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAlloca teObject.
453 (toUTI): Return a RetainPtr<CFStringRef>.
454 (-[LocalPasteboard types]): Use the above and bridging casts.
455 (-[LocalPasteboard availableTypeFromArray:]): Ditto.
456 (-[LocalPasteboard setData:forType:]): Ditto.
457 (-[LocalPasteboard dataForType:]): Ditto.
458 (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSeriali zation
459 instead of CFPropertyList.
460 (-[LocalPasteboard setString:forType:]): Use NSString method instead of
461 CFStringCreateExternalRepresentation.
462
463 * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashS et
464 instead of an Objective-C object pointer type.
465 * DumpRenderTree/mac/MockGeolocationProvider.mm:
466 (-[MockGeolocationProvider registerWebView:]): Update for above.
467 (-[MockGeolocationProvider unregisterWebView:]): Ditto.
468 (-[MockGeolocationProvider timerFired]): Ditto.
469
470 * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
471 HashMap and HashSet instead of an Objective-C object pointer type.
472 * DumpRenderTree/mac/MockWebNotificationProvider.mm:
473 (-[MockWebNotificationProvider registerWebView:]): Update for above.
474 (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
475 (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
476 (-[MockWebNotificationProvider cancelNotification:]): Ditto.
477 (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
478
479 * DumpRenderTree/mac/ObjCPlugin.m:
480 (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
481
482 * DumpRenderTree/mac/TestRunnerMac.mm:
483 (TestRunner::addDisallowedURL): Use bridging cast.
484 (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
485 (TestRunner::clearApplicationCacheForOrigin): Ditto.
486 (originsArrayToJS): Ditto.
487 (TestRunner::copyDecodedHostName): Ditto.
488 (TestRunner::copyEncodedHostName): Ditto.
489 (TestRunner::queueLoad): Ditto.
490 (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
491 (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
492 (TestRunner::setUserStyleSheetLocation): Ditto.
493 (TestRunner::setValueForUser): Ditto.
494 (TestRunner::overridePreference): Ditto.
495 (TestRunner::execCommand): Ditto.
496 (TestRunner::findString): Ditto.
497 (TestRunner::isCommandEnabled): Ditto.
498 (TestRunner::addOriginAccessWhitelistEntry): Ditto.
499 (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
500 (TestRunner::addUserScript): Ditto.
501 (TestRunner::addUserStyleSheet): Ditto.
502 (TestRunner::evaluateInWebInspector): Ditto.
503 (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
504 (TestRunner::authenticateSession): Ditto.
505 (TestRunner::grantWebNotificationPermission): Ditto.
506 (TestRunner::denyWebNotificationPermission): Ditto.
507 * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
508 (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
509
510 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
511 (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bri dging cast.
512 (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
513 (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
514 (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
515 (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
516 (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
517 (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
518 (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
519 (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
520 (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
521 (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
522 (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
523 (WTR::AccessibilityUIElement::startTextMarker): Ditto.
524 (WTR::AccessibilityUIElement::endTextMarker): Ditto.
525 (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Dit to.
526 (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Di tto.
527 (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
528 (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto .
529 (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Di tto.
530 (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMar ker): Ditto.
531 (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
532 (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Dit to.
533 (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMark er): Ditto.
534 (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): D itto.
535
536 * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
537 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
538
539 * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRun nerWindow.h
540 so we can use the type and know it inherits from NSWindow.
541
542 * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestR unnerWindow.h
543 so we can use the type and know it inherits from NSWindow. Moved WebKitT estRunnerWindow
544 class into a separate file.
545 (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_ke yWindow]
546 instead of have a second copy of the implementation.
547
548 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTe stRunnerWindow.h
549 so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
550 (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
551
552 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
553 (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAlloca teObject.
554 (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
555 (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
556 (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSeriali zation
557 instead of CFPropertyList.
558 (-[LocalPasteboard setString:forType:]): Use NSString method instead of
559 CFStringCreateExternalRepresentation.
560
561 * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
562 WebKitTestRunnerWindow here so it can be included by files that need to know
563 what the type is and that it inherits from NSWindow.
564
565 * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implement ation here.
566 (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
567 messier implementation.
568
569 2018-08-07 Alex Christensen <achristensen@webkit.org>
570
571 Add a test for using SafeBrowsing
572 https://bugs.webkit.org/show_bug.cgi?id=188290
573
574 Reviewed by Chris Dumez.
575
576 Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
577 We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
578
579 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
580 * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
581 (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
582 (TestWebKitAPI::TEST):
583
584 2018-08-07 Lucas Forschler <lforschler@apple.com>
585
586 If there's a Radar in the ChangeLog, webkit-patch upload/create-bug shou ld put the radar in the bug and set InRadar
587 https://bugs.webkit.org/show_bug.cgi?id=188235
588
589 Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
590
591 * Scripts/webkitpy/common/checkout/changelog.py:·
592 (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
593 * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the n ew _parse_radar_id functionality
594 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
595 (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the chang eform
596 * Scripts/webkitpy/tool/commands/upload.py:
597 (Upload): Teach the upload step how to add radar information when creati ng a new bug.
598 * Scripts/webkitpy/tool/steps/__init__.py:
599 * Scripts/webkitpy/tool/steps/addradar.py: Added.
600 (AddRadar):
601 (AddRadar.run): Contains the logic to add the radar information to bugzi lla.
602 * Scripts/webkitpy/tool/steps/createbug.py:
603 (CreateBug.run): set a "created_new_bug" state when creating a new bugzi lla bug.
604
605 2018-08-07 Wenson Hsieh <wenson_hsieh@apple.com>
606
607 Post-review feedback after r234614.
608 https://bugs.webkit.org/show_bug.cgi?id=188322
609 <rdar://problem/42455270>
610
611 Reviewed by Sam Weinig.
612
613 Use std::round instead of roundl — there's no reason to go from double t o long double precision when rounding.
614
615 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
616 (rounded):
617
618 2018-08-07 Don Olmstead <don.olmstead@sony.com>
619
620 [MiniBrowser][Win] Allow selection of recent user agents
621 https://bugs.webkit.org/show_bug.cgi?id=188371
622
623 Reviewed by Fujii Hironori.
624
625 Updates the user agent spoofing strings to the latest released
626 versions and adds Microsoft Edge's user agent.
627
628 Moves the menu item selection to the common base class, BrowserWindow
629 to support user agent spoofing in a WebKitLegacyBrowserWindow and
630 WebKitBrowserWindow.
631
632 * MiniBrowser/win/BrowserWindow.cpp: Added.
633 (BrowserWindow::setUserAgent):
634 * MiniBrowser/win/BrowserWindow.h:
635 * MiniBrowser/win/CMakeLists.txt:
636 * MiniBrowser/win/MainWindow.cpp:
637 (MainWindow::toggleMenuItem):
638 * MiniBrowser/win/MiniBrowserLib.rc:
639 * MiniBrowser/win/MiniBrowserLibResource.h:
640 * MiniBrowser/win/WebKitBrowserWindow.cpp:
641 * MiniBrowser/win/WebKitBrowserWindow.h:
642 * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
643 (WebKitLegacyBrowserWindow::setUserAgent):
644 * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
645
646 2018-08-07 Yusuke Suzuki <utatane.tea@gmail.com>
647
648 Unreviewed, add a new address to my configuration
649
650 * Scripts/webkitpy/common/config/contributors.json:
651
652 2018-08-06 David Quesada <david_quesada@apple.com>
653
654 webkitdirs.pm should default to iPhone SE for 64-bit testing
655 https://bugs.webkit.org/show_bug.cgi?id=188361
656
657 Reviewed by Daniel Bates.
658
659 Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
660
661 * Scripts/webkitdirs.pm:
662 (findOrCreateSimulatorForIOSDevice):
663 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
664 (parse_args):
665 Update the help text for --device-type to reflect the new default de vice.
666
667 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
668
669 [iOS] Caret disappears after resigning and becoming first responder if a ctive focus state is retained
670 https://bugs.webkit.org/show_bug.cgi?id=188322
671 <rdar://problem/42455270>
672
673 Reviewed by Tim Horton.
674
675 Fixes an API test added in r234600, which had incorrect test expectation s — namely, the width of the caret rect
676 was not in content view coordinates, unlike the x, y, and height.
677
678 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
679 (rounded):
680 (-[TestWKWebView waitForCaretViewFrameToBecome:]):
681 (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
682 (TestWebKitAPI::TEST):
683
684 2018-08-06 Ryan Haddad <ryanhaddad@apple.com>
685
686 Unreviewed, rolling out r234569.
687
688 Breaks internal builds.
689
690 Reverted changeset:
691
692 "We should cache the compiled sandbox profile in a data vault"
693 https://bugs.webkit.org/show_bug.cgi?id=184991
694 https://trac.webkit.org/changeset/234569
695
696 2018-08-06 Fujii Hironori <Hironori.Fujii@sony.com>
697
698 [Win][DLLLauncher] Remove --highDPI switch
699 https://bugs.webkit.org/show_bug.cgi?id=188255
700
701 Reviewed by Yusuke Suzuki.
702
703 Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
704 aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
705 became useless since the change. Remove the switch.
706
707 This change fixes the issue all dump render tree tests are failing
708 in WinCairo port if high DPI display is connected.
709
710 * MiniBrowser/win/Common.cpp:
711 (parseCommandLine): Removed `--highDPI` switch.
712 * win/DLLLauncher/DLLLauncherMain.cpp:
713 (wWinMain): Do not call SetProcessDPIAware.
714 (shouldUseHighDPI): Deleted.
715
716 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
717
718 [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
719 https://bugs.webkit.org/show_bug.cgi?id=188335
720 <rdar://problem/32542437> and <rdar://problem/32542433>
721
722 Reviewed by Tim Horton.
723
724 Remove a UIScriptController helper method that attempted to wait for Qui ckType buttons to appear, and then send
725 touch events to the buttons. These were only used for the two tests whic h this patch refactors. See the
726 LayoutTests ChangeLog for more detail.
727
728 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
729 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
730 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
731 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
732 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
733 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAt Index): Deleted.
734 * TestRunnerShared/UIScriptContext/UIScriptController.h:
735 * TestRunnerShared/spi/UIKitTestSPI.h:
736
737 Remove an internal class declaration that is now unnecessary.
738
739 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
740 (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
741 (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAt Index): Deleted.
742
743 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
744
745 [iOS] Caret disappears after resigning and becoming first responder if a ctive focus state is retained
746 https://bugs.webkit.org/show_bug.cgi?id=188322
747 <rdar://problem/42455270>
748
749 Reviewed by Tim Horton.
750
751 Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
752 test. Also adds new API tests to verify that when a web view resigns fir st responder, both caret and range
753 selection views are hidden, and when first responder status is restored, both caret and range selection views
754 are made visible again.
755
756 * DumpRenderTree/ios/UIScriptControllerIOS.mm:
757 (WTR::UIScriptController::selectionStartGrabberViewRect const):
758 (WTR::UIScriptController::selectionEndGrabberViewRect const):
759 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
760 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
761 (WTR::UIScriptController::selectionStartGrabberViewRect const):
762 (WTR::UIScriptController::selectionEndGrabberViewRect const):
763 * TestRunnerShared/UIScriptContext/UIScriptController.h:
764 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
765 (-[TestWKWebView waitForCaretViewFrameToBecome:]):
766 (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
767 (webViewWithAutofocusedInput):
768
769 Pull out some common logic for creating a web view that allows programma tic focus to present the keyboard, and
770 immediately loading a web page with an autofocusing text field.
771
772 (TestWebKitAPI::TEST):
773 * TestWebKitAPI/cocoa/TestWKWebView.h:
774 * TestWebKitAPI/cocoa/TestWKWebView.mm:
775 (-[TestWKWebView caretViewRectInContentCoordinates]):
776 (-[TestWKWebView selectionViewRectsInContentCoordinates]):
777 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
778 (WTR::UIScriptController::selectionStartGrabberViewRect const):
779 (WTR::UIScriptController::selectionEndGrabberViewRect const):
780
781 2018-08-06 Wenson Hsieh <wenson_hsieh@apple.com>
782
783 [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
784 https://bugs.webkit.org/show_bug.cgi?id=188334
785 <rdar://problem/40630074>
786
787 Reviewed by Tim Horton.
788
789 To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
790 and stores the completion callback ID for the previously dispatched even ts as vendor-defined data. When this
791 vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
792 it to a completion block, and invoke the completion block to signal that the previous HID event has been
793 processed.
794
795 This callback ID is an unsigned, so we tell IOKit that we need `sizeof(u nsigned)` (4 bytes) to store it. On
796 shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `size of(CFIndex)`. When we later call
797 IOHIDEventGetIntegerValue to read the value of our vendor-defined data a s a CFIndex, we get our expected
798 callback ID because the buffer was clamped to 8 bytes.
799
800 However, on recent iOS SDKs that contain the fix for <rdar://problem/200 82284>, IOKit no longer clamps the size
801 of the vendor-defined data buffer to 8 bytes. This means that when we tr y to use IOHIDEventGetIntegerValue to
802 read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
803 the upper 4 bytes are garbage. In the case where any of these upper 4 by tes are non-zero, we fail to map the
804 callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
805 be thrown.
806
807 To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDE ventGetIntegerValue's return type.
808
809 * WebKitTestRunner/ios/HIDEventGenerator.mm:
810 (+[HIDEventGenerator nextEventCallbackID]):
811 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
812
813 Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by usi ng auto and move semantics.
814
815 2018-08-03 Ben Richards <benton_richards@apple.com>
816
817 We should cache the compiled sandbox profile in a data vault
818 https://bugs.webkit.org/show_bug.cgi?id=184991
819
820 Reviewed by Ryosuke Niwa.
821
822 Added trace points for sandbox initialization
823
824 * Tracing/SystemTracePoints.plist:
825
826 2018-08-03 David Fenton <david_fenton@apple.com>
827
828 Unreviewed, rolling out r234517.
829
830 Caused API test failures on iOS
831
832 Reverted changeset:
833
834 "[Cocoa] setCookie API fails to set session cookies for
835 defaultDataStore if processPool created but not used"
836 https://bugs.webkit.org/show_bug.cgi?id=188209
837 https://trac.webkit.org/changeset/234517
838
839 2018-08-03 Ben Richards <benton_richards@apple.com>
840
841 Add configuration for automatic process pre-warming
842 https://bugs.webkit.org/show_bug.cgi?id=187108
843
844 Reviewed by Ryosuke Niwa.
845
846 Added new test case for setting maximum prewarmed process count and upda ted test case for process swap on navigation to set the maximum prewarmed proces s count to be 1 where relevant.
847
848 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
849 * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
850 (TEST):
851 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
852 * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
853 (TEST):
854
855 2018-08-03 Aakash Jain <aakash_jain@apple.com>
856
857 [ews-build] Add build step to Check Patch Relevance
858 https://bugs.webkit.org/show_bug.cgi?id=188295
859
860 Reviewed by Lucas Forschler.
861
862 * BuildSlaveSupport/ews-build/steps.py:
863 (CheckPatchRelevance): Added step to check patch relevance.
864 (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevan t.
865 (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
866 (CheckPatchRelevance._addToLog): Add the log message.
867 (CheckPatchRelevance.start):
868 * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance st ep appropriately.
869
870 2018-08-03 Jer Noble <jer.noble@apple.com>
871
872 Unreviewed gardening; r234534 changed the policy for what audio session is set when a
873 media element is paused. Updating the test to reflect the new policy.
874
875 * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
876 (TestWebKitAPI::TEST):
877
878 2018-08-03 Zalan Bujtas <zalan@apple.com>
879
880 [LFC][Floating] Now that the document renderer belongs to "complicated c ases", adjust viewport stretching.
881 https://bugs.webkit.org/show_bug.cgi?id=188306
882
883 Reviewed by Antti Koivisto.
884
885 * LayoutReloaded/misc/LFC-passing-tests.txt:
886
887 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
888
889 [WPE] Use the new key mapper API from WPEBackend
890 https://bugs.webkit.org/show_bug.cgi?id=188216
891
892 Reviewed by Žan Doberšek.
893
894 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
895 (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_ for_key_code() to get the hardware key
896 code.
897 * wpe/backends/WindowViewBackend.cpp:
898 (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
899 (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
900 (WPEToolingBackends::WindowViewBackend::modifiers const):
901 * wpe/backends/WindowViewBackend.h:
902
903 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
904
905 [WPE] Implement MouseEvent.buttons
906 https://bugs.webkit.org/show_bug.cgi?id=187998
907
908 Reviewed by Žan Doberšek.
909
910 Pass modifiers to mouse events.
911
912 * WebKitTestRunner/EventSenderProxy.h:
913 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
914 (WTR::senderButtonToWPEButton):
915 (WTR::modifierForButton):
916 (WTR::EventSenderProxy::mouseDown):
917 (WTR::EventSenderProxy::mouseUp):
918 (WTR::EventSenderProxy::mouseMoveTo):
919 (WTR::EventSenderProxy::mouseScrollBy):
920 (WTR::wkEventModifiersToWPE):
921 (WTR::wpeKeySymForKeyRef):
922 (WTR::EventSenderProxy::keyDown):
923 (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
924 * wpe/backends/WindowViewBackend.cpp:
925 (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
926 (WPEToolingBackends::WindowViewBackend::modifiers const):
927 * wpe/backends/WindowViewBackend.h:
928
929 2018-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
930
931 [WPE] Use WPE key symbols and new API instead of xkbcommon and the key m apper
932 https://bugs.webkit.org/show_bug.cgi?id=188093
933
934 Reviewed by Žan Doberšek.
935
936 * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
937 * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
938 (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_co de().
939 (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event s ince it was removed.
940 * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versio ns.
941 * wpe/backends/WindowViewBackend.cpp:
942 (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unic ode char to the event since it was removed.
943 * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
944
945 2018-08-02 Nan Wang <n_wang@apple.com>
946
947 AX: [iOS] add support to return the attributed string under the element
948 https://bugs.webkit.org/show_bug.cgi?id=188276
949 <rdar://problem/42872357>
950
951 Reviewed by Chris Fleizach.
952
953 * DumpRenderTree/AccessibilityUIElement.cpp:
954 (attributedStringForElementCallback):
955 (AccessibilityUIElement::getJSClass):
956 * DumpRenderTree/AccessibilityUIElement.h:
957 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
958 (AccessibilityUIElement::attributedStringForElement):
959 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
960 (WTR::AccessibilityUIElement::attributedStringForElement):
961 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
962 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
963 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
964 (WTR::AccessibilityUIElement::attributedStringForElement):
965
966 2018-08-02 Ryan Haddad <ryanhaddad@apple.com>
967
968 Skip API test DataInteractionTests.CustomActionSheetPopover on current S DKs.
969 https://bugs.webkit.org/show_bug.cgi?id=175204
970
971 Unreviewed test gardening.
972
973 * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
974
975 2018-08-02 Sihui Liu <sihui_liu@apple.com>
976
977 [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
978 https://bugs.webkit.org/show_bug.cgi?id=188209
979
980 Reviewed by Geoffrey Garen.
981
982 * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
983 (TEST):
984
985 2018-08-02 Dan Bernstein <mitz@apple.com>
986
987 Fixed WebKit.AttrStyle timing out on build.webkit.org.
988
989 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL tha t requires network
990 access to one that doesn’t.
991 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
992 (TEST): Updated expected value.
993
994 2018-08-02 Wenson Hsieh <wenson_hsieh@apple.com>
995
996 [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
997 https://bugs.webkit.org/show_bug.cgi?id=188251
998 <rdar://problem/37842108>
999
1000 Reviewed by Tim Horton.
1001
1002 Adds a new API test to verify that clients (in this case, UIKit) is allo wed to invoke
1003 -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
1004
1005 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1006 * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
1007 (TestWebKitAPI::TEST):
1008 * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
1009
1010 Pull some logic used to force an input session to start out from an exis ting API test file
1011 (WKWebViewAutofillTests) and into a separate helper class that is used b y both the existing API tests and the
1012 new keyboard input test.
1013
1014 * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1015 (-[AutofillTestView initWithFrame:]):
1016 (TestWebKitAPI::TEST):
1017 (-[TestInputDelegate init]): Deleted.
1018 (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
1019 * TestWebKitAPI/ios/UIKitSPI.h:
1020
1021 Add some UIKit SPI utilized by the new API test.
1022
1023 2018-08-01 Dan Bernstein <mitz@apple.com>
1024
1025 Optionally expose Attr::style to JavaScript
1026 https://bugs.webkit.org/show_bug.cgi?id=188226
1027 <rdar://problem/42818113>
1028
1029 Reviewed by Darin Adler.
1030
1031 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1032 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
1033 * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
1034 (TEST):
1035
1036 2018-08-02 David Fenton <david_fenton@apple.com>
1037
1038 Unreviewed, rolling out r234489.
1039
1040 Caused 50+ crashes and 60+ API failures on iOS
1041
1042 Reverted changeset:
1043
1044 "[WTF] Rename String::format to String::deprecatedFormat"
1045 https://bugs.webkit.org/show_bug.cgi?id=188191
1046 https://trac.webkit.org/changeset/234489
1047
1048 2018-08-01 Ross Kirsling <ross.kirsling@sony.com>
1049
1050 TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mo de
1051 https://bugs.webkit.org/show_bug.cgi?id=188244
1052
1053 Reviewed by Daniel Bates.
1054
1055 Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mod e.·
1056
1057 * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
1058
1059 2018-08-01 Tomas Popela <tpopela@redhat.com>
1060
1061 [WTF] Rename String::format to String::deprecatedFormat
1062 https://bugs.webkit.org/show_bug.cgi?id=188191
1063
1064 Reviewed by Darin Adler.
1065
1066 It should be replaced with string concatenation.
1067
1068 * DumpRenderTree/win/DumpRenderTree.cpp:
1069 (applicationId):
1070 (main):
1071 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1072 (TestWebKitAPI::Util::createURLForResource):
1073 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1074 (WTR::cacheTestRunnerCallback):
1075 * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAt k.cpp:
1076 (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1077 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1078 (WTR::AccessibilityUIElement::attributedStringForRange):
1079 (WTR::AccessibilityUIElement::url):
1080 (WTR::stringAtOffset):
1081 * WebKitTestRunner/TestController.cpp:
1082 (WTR::TestController::didReceiveAuthenticationChallenge):
1083 (WTR::TestController::downloadDidFail):
1084 (WTR::originUserVisibleName):
1085 (WTR::userMediaOriginHash):
1086 (WTR::TestController::didNavigateWithNavigationData):
1087 (WTR::TestController::didPerformClientRedirect):
1088 (WTR::TestController::didPerformServerRedirect):
1089 (WTR::TestController::didUpdateHistoryTitle):
1090
1091 2018-08-01 Nan Wang <n_wang@apple.com>
1092
1093 AX: AOM: Add ARIA IDL Attribute Reflection
1094 https://bugs.webkit.org/show_bug.cgi?id=184676
1095 <rdar://problem/39476882>
1096
1097 Reviewed by Chris Fleizach.
7 1098
8 * DumpRenderTree/mac/DumpRenderTree.mm: 1099 * DumpRenderTree/mac/DumpRenderTree.mm:
9 (enableExperimentalFeatures): 1100 (enableExperimentalFeatures):
10 * WebKitTestRunner/TestController.cpp: 1101 * WebKitTestRunner/TestController.cpp:
11 (WTR::TestController::resetPreferencesToConsistentValues): 1102 (WTR::TestController::resetPreferencesToConsistentValues):
1103
1104 2018-08-01 Jonathan Bedard <jbedard@apple.com>
1105
1106 Use iPhone SE as the default simulated device
1107 https://bugs.webkit.org/show_bug.cgi?id=188227
1108
1109 Reviewed by Aakash Jain.
1110
1111 * Scripts/webkitpy/port/ios_simulator.py:
1112 (IOSSimulatorPort):
1113
1114 2018-08-01 Commit Queue <commit-queue@webkit.org>
1115
1116 Unreviewed, rolling out r234443 and r234445.
1117 https://bugs.webkit.org/show_bug.cgi?id=188224
1118
1119 Revision caused 3 api failures across all platforms.
1120 (Requested by Truitt on #webkit).
1121
1122 Reverted changesets:
1123
1124 "Add configuration for automatic process pre-warming"
1125 https://bugs.webkit.org/show_bug.cgi?id=187108
1126 https://trac.webkit.org/changeset/234443
1127
1128 "Add configuration for automatic process pre-warming"
1129 https://bugs.webkit.org/show_bug.cgi?id=187108
1130 https://trac.webkit.org/changeset/234445
1131
1132 2018-07-31 Ben Richards <benton_richards@apple.com>
1133
1134 Add configuration for automatic process pre-warming
1135 https://bugs.webkit.org/show_bug.cgi?id=187108
1136
1137 Reviewed by Ryosuke Niwa.
1138
1139 Added new test case for setting maximum prewarmed process count and upda ted test case for process swap on navigation to set the maximum prewarmed proces s count to be 1 where relevant.
1140
1141 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1142 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1143 * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Ad ded.
1144 (TEST):
1145
1146 2018-07-31 John Wilander <wilander@apple.com>
1147
1148 Resource Load Statistics: Remove partitioned cookies for reduced complex ity, lower memory footprint, and ability to support more platforms
1149 https://bugs.webkit.org/show_bug.cgi?id=188109
1150 <rdar://problem/42664391>
1151
1152 Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
1153
1154 This patch removes cookie partitioning which reduces the model to just
1155 blocked cookies (in third-party contexts) and first-party cookie access.
1156
1157 Several of the changes are renaming to reflect that there are no more
1158 cookie partitions.
1159
1160 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1161 Removed or renamed functions to reflect that there are no more
1162 partitioned cookies.
1163 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1164 (WTR::InjectedBundle::didReceiveMessageToPage):
1165 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1166 (WTR::TestRunner::statisticsUpdateCookieBlocking):
1167 (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
1168 (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
1169 (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
1170 (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
1171 (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
1172 (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
1173 (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCall back): Deleted.
1174 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1175 * WebKitTestRunner/TestController.cpp:
1176 (WTR::TestController::statisticsUpdateCookieBlocking):
1177 (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Dele ted.
1178 (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Delet ed.
1179 (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
1180 (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Delet ed.
1181 * WebKitTestRunner/TestController.h:
1182 * WebKitTestRunner/TestInvocation.cpp:
1183 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1184 (WTR::TestInvocation::didSetBlockCookiesForHost):
1185 (WTR::TestInvocation::didSetHasHadUserInteraction):
1186 (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
1187 (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
1188 * WebKitTestRunner/TestInvocation.h:
1189 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1190 (WTR::initializeWebViewConfiguration):
1191
1192 2018-07-31 Alex Christensen <achristensen@webkit.org>
1193
1194 Build fix. Remove unused variable.
1195
1196 * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1197 (TestWebKitAPI::TEST):
1198 transform was never used. It was introduced in r205871
1199 Apparently I'm the first one to build in a certain configuration that fo und it.
1200
1201 2018-07-31 Fujii Hironori <Hironori.Fujii@sony.com>
1202
1203 server_process.py should print returncode in debug log if the process cr ashed
1204 https://bugs.webkit.org/show_bug.cgi?id=188160
1205
1206 Reviewed by Konstantin Tokarev.
1207
1208 * Scripts/webkitpy/port/server_process.py:
1209 (ServerProcess.has_crashed): Put self._proc.returncode into the debug lo g message.
1210
1211 2018-07-31 Tomas Popela <tpopela@redhat.com>
1212
1213 [WTF] String::formatWithArguments() is unused
1214 https://bugs.webkit.org/show_bug.cgi?id=187955
1215
1216 Reviewed by Darin Adler.
1217
1218 Remove tests for WTF::String::formatWithArguments() as it's unused and
1219 we are removing it.
1220
1221 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1222
1223 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1224
1225 [ews-build] Fix typo in builder name for Bindings-tests-EWS.
1226
1227 * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
1228 other builders.
1229
1230 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1231
1232 [ews-build] Add support for API tests in OpenSource EWS
1233 https://bugs.webkit.org/show_bug.cgi?id=188156
1234
1235 Reviewed by Lucas Forschler.
1236
1237 * BuildSlaveSupport/ews-build/config.json:
1238 * BuildSlaveSupport/ews-build/factories.py:
1239 (BuildFactory.__init__): Added triggers parameter.
1240 (BuildFactory): If trigger is defined, create and upload archive and tri gger appropriate queues.
1241 (BuildFactory.propertiesToPassToTriggers): Pass all the required propert ies to triggered queue.
1242 (APITestsFactory): Factory for running API tests.
1243 * BuildSlaveSupport/ews-build/steps.py:
1244 (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the·
1245 source of the property.
1246
1247 2018-07-30 Aakash Jain <aakash_jain@apple.com>
1248
1249 [ews-build] loadConfig should ensure that the triggers are valid
1250 https://bugs.webkit.org/show_bug.cgi?id=188134
1251
1252 Reviewed by Lucas Forschler.
1253
1254 * BuildSlaveSupport/ews-build/loadConfig.py:
1255 (checkValidBuilder): Added a check to ensure that the builder doesn't re fernce non-existing scheduler.
1256 (checkValidSchedulers): Ensures that the scheduler is not un-used.
1257 * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests .
1258
1259 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1260
1261 Unreviewed, fix typo in test expectations and mark another test as timin g out
1262
1263 * TestWebKitAPI/glib/TestExpectations.json:
1264
1265 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1266
1267 More unreviewed GTK test gardening
1268
1269 * TestWebKitAPI/glib/TestExpectations.json:
1270
1271 2018-07-27 Simon Fraser <simon.fraser@apple.com>
1272
1273 Be more conservative with compositing layer creation when memory is low
1274 https://bugs.webkit.org/show_bug.cgi?id=187866
1275 rdar://problem/42366345
1276
1277 Reviewed by Zalan Bujtas.
1278 ········
1279 When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
1280 compositing layers. We avoid compositing for these situations:
1281 1. Layers with 3D transforms which are affine (like translateZ(0)).
1282 2. Layers with will-change
1283 3. Layers for canvases (other than WebGL/WebGPU)
1284 ········
1285 We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
1286 falling into "conservative mode" at 50% of jetsam limit, and "strict mod e" at 65%.
1287 Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
1288 ········
1289 Plumb through a "compositingPolicyOverride" both so that on-device testi ng isn't
1290 flakily falling into a different mode, and so that we can impose the con servative
1291 mode for testing.
1292
1293 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1294 (WTR::InjectedBundlePage::prepare):
1295
1296 2018-07-27 Michael Catanzaro <mcatanzaro@igalia.com>
1297
1298 Unreviewed GTK test gardening
1299
1300 * TestWebKitAPI/glib/TestExpectations.json:
1301
1302 2018-07-27 Alex Christensen <achristensen@webkit.org>
1303
1304 Fix API tests after r234314
1305 https://bugs.webkit.org/show_bug.cgi?id=188077
1306
1307 Make API tests use new delegate method.
1308
1309 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1310 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:userInfo:decisionHandler:]):
1311 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]): Deleted.
1312
1313 2018-07-27 Alex Christensen <achristensen@webkit.org>
1314
1315 Fix API tests after r234314
1316 https://bugs.webkit.org/show_bug.cgi?id=188077
1317
1318 Make API tests use new delegate method.
1319
1320 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1321 (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNaviga tionAction:userInfo:decisionHandler:]):
1322 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:use rInfo:decisionHandler:]):
1323 (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationActio n:userInfo:decisionHandler:]):
1324 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:u serInfo:decisionHandler:]):
1325 (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userIn fo:decisionHandler:]):
1326 (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNaviga tionAction:decisionHandler:]): Deleted.
1327 (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:dec isionHandler:]): Deleted.
1328 (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationActio n:decisionHandler:]): Deleted.
1329 (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:d ecisionHandler:]): Deleted.
1330 (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisi onHandler:]): Deleted.
1331
1332 2018-07-26 Andy VanWagoner <andy@vanwagoner.family>
1333
1334 [INTL] Remove INTL sub-feature compile flags
1335 https://bugs.webkit.org/show_bug.cgi?id=188081
1336
1337 Reviewed by Michael Catanzaro.
1338
1339 * Scripts/webkitperl/FeatureList.pm:
1340 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1341
1342 2018-07-26 Chris Dumez <cdumez@apple.com>
1343
1344 Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
1345 https://bugs.webkit.org/show_bug.cgi?id=188078
1346 <rdar://problem/42562493>
1347
1348 Reviewed by Geoff Garen.
1349
1350 Add API test coverage. It exercises the right code path but unfortunatel y is not yet a regression
1351 test because TestWebKitAPI does not appear to be sandboxed (rdar://probl em/42638129).
1352
1353 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1354 * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
1355 (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
1356 (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withE rror:]):
1357 (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
1358 (TEST):
1359
1360 2018-07-26 Aaron Chu <aaron_chu@apple.com>
1361
1362 Add Aaron Chu as a committer to contributors.json
1363 https://bugs.webkit.org/show_bug.cgi?id=188066
1364
1365 Unreviwed. Added myself as committer.
1366
1367 * Scripts/webkitpy/common/config/contributors.json:
1368
1369 2018-07-26 Aakash Jain <aakash_jain@apple.com>
1370
1371 [ews-build] Add build step to run API Tests
1372 https://bugs.webkit.org/show_bug.cgi?id=188079
1373
1374 Reviewed by Lucas Forschler.
1375
1376 * BuildSlaveSupport/ews-build/steps.py:
1377 (TestWithFailureCount): Common class for various tests with failure coun t.
1378 (TestWithFailureCount.start): Configure Buildbot's logobserver.
1379 (TestWithFailureCount.commandComplete): Updates the failure count.
1380 (TestWithFailureCount.evaluateCommand): Set the step status appropriatel y.
1381 (TestWithFailureCount.getResultSummary): Set the step summary appropriat ely.
1382 (RunAPITests): Build step to run API tests.
1383 (RunAPITests.countFailures): Count the failures by parsing the output.
1384 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1385
1386 2018-07-26 Ross Kirsling <ross.kirsling@sony.com>
1387
1388 String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1389 https://bugs.webkit.org/show_bug.cgi?id=187963
1390
1391 Reviewed by Alex Christensen.
1392
1393 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1394 Add tests for String::split and String::splitAllowingEmptyEntries.
1395
1396 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1397 * WebKitTestRunner/TestController.cpp:
1398 (WTR::updateTestOptionsFromTestHeader):
1399 Update split/splitAllowingEmptyEntries usage.
1400
1401 2018-07-26 Commit Queue <commit-queue@webkit.org>
1402
1403 Unreviewed, rolling out r234181 and r234189.
1404 https://bugs.webkit.org/show_bug.cgi?id=188075
1405
1406 These are not needed right now (Requested by thorton on
1407 #webkit).
1408
1409 Reverted changesets:
1410
1411 "Enable Web Content Filtering on watchOS"
1412 https://bugs.webkit.org/show_bug.cgi?id=187979
1413 https://trac.webkit.org/changeset/234181
1414
1415 "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1416 https://bugs.webkit.org/show_bug.cgi?id=187985
1417 https://trac.webkit.org/changeset/234189
1418
1419 2018-07-04 Darin Adler <darin@apple.com>
1420
1421 Improve WebGPU implementation, including using Metal Objective-C protoco ls more simply and correctly
1422 https://bugs.webkit.org/show_bug.cgi?id=187333
1423
1424 Reviewed by Sam Weinig.
1425
1426 * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
1427 * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
1428 * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
1429 * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
1430 * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
1431
1432 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1433
1434 [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
1435 https://bugs.webkit.org/show_bug.cgi?id=188031
1436
1437 Reviewed by Lucas Forschler.
1438
1439 * BuildSlaveSupport/ews-build/steps.py:
1440 (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
1441 (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
1442 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1443
1444 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1445
1446 [ews-build] Add build step UploadBuiltProduct
1447 https://bugs.webkit.org/show_bug.cgi?id=188016
1448
1449 Reviewed by Lucas Forschler.
1450
1451 * BuildSlaveSupport/ews-build/steps.py:
1452 (UploadBuiltProduct): Added build step UploadBuiltProduct.
1453 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1454
1455 2018-07-25 Aakash Jain <aakash_jain@apple.com>
1456
1457 [ews-build] Add build step ArchiveBuiltProduct
1458 https://bugs.webkit.org/show_bug.cgi?id=188014
1459
1460 Reviewed by Lucas Forschler.
1461
1462 * BuildSlaveSupport/ews-build/steps.py:
1463 (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
1464 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1465
1466 2018-07-25 Chris Dumez <cdumez@apple.com>
1467
1468 navigator.userAgent may return outdated value after webView.customUserAg ent is set
1469 https://bugs.webkit.org/show_bug.cgi?id=188009
1470 <rdar://problem/42566456>
1471
1472 Reviewed by Alex Christensen.
1473
1474 Add API test coverage.
1475
1476 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477 * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
1478 (TEST):
1479
1480 2018-07-25 Charlie Turner <cturner@igalia.com>
1481
1482 [Flatpak] Pass more environment variables to sandbox
1483 https://bugs.webkit.org/show_bug.cgi?id=188002
1484
1485 Reviewed by Michael Catanzaro.
1486
1487 * flatpak/flatpakutils.py:
1488 (WebkitFlatpak.run_in_sandbox):
1489
1490 2018-07-25 Zan Dobersek <zdobersek@igalia.com>
1491
1492 [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl AP Is
1493 https://bugs.webkit.org/show_bug.cgi?id=187997
1494
1495 Reviewed by Carlos Garcia Campos.
1496
1497 Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
1498 the EGL-oriented API that simply serves EGLImageKHR objects instead of
1499 raw buffer resources. This allows us not to wrangle with creating and
1500 managing lifetime of the same EGLImageKHR by ourselves.
1501
1502 ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
1503 struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
1504 the exportable object. This means that for each frame we're served an
1505 EGLImageKHR object that is passed on to the displayBuffer()
1506 implementation.
1507
1508 HeadlessViewBackend now just manages the pending and committed image
1509 objects. Width and height values used during pixel data retrieval are
1510 gathered from the ViewBackend's size that was specified when
1511 constructed.
1512
1513 WindowViewBackend similarly only manages the committed image object,
1514 not having to create an equivalent EGLImageKHR object from the raw
1515 buffer resource anymore.
1516
1517 Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
1518 classes are removed, and destructors for both classes are made virtual.
1519
1520 The WPEBackend-fdo version is bumped in order to have the EGL-specific
1521 export API available.
1522
1523 * flatpak/org.webkit.WPE.yaml:
1524 * wpe/backends/HeadlessViewBackend.cpp:
1525 (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1526 (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1527 (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1528 (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1529 (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1530 * wpe/backends/HeadlessViewBackend.h:
1531 * wpe/backends/ViewBackend.cpp:
1532 (WPEToolingBackends::ViewBackend::initialize):
1533 * wpe/backends/ViewBackend.h:
1534 * wpe/backends/WindowViewBackend.cpp:
1535 (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1536 (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1537 (WPEToolingBackends::WindowViewBackend::displayBuffer):
1538 * wpe/backends/WindowViewBackend.h:
1539 * wpe/jhbuild.modules:
1540
1541 2018-07-24 Thomas Denney <tdenney@apple.com>
1542
1543 Remove support for the double type from WHLSL
1544 https://bugs.webkit.org/show_bug.cgi?id=187977
1545
1546 Reviewed by Myles C. Maxfield.
1547
1548 * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLit eralType.js include.
1549 * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
1550 * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
1551 * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic funct ions.
1552 * WebGPUShadingLanguageRI/Parse.js:
1553 (parseTerm): Removed parsing of double literals.
1554 * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and Doubl eLiteralType.js include.
1555 * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
1556 * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declar ations.
1557 * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and Double LiteralType.js include.
1558 * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or po rted them to use floats.
1559 * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and Doubl eLiteralType.js include.
1560
1561 2018-07-24 Tim Horton <timothy_horton@apple.com>
1562
1563 Enable Web Content Filtering on watchOS
1564 https://bugs.webkit.org/show_bug.cgi?id=187979
1565 <rdar://problem/42559346>
1566
1567 Reviewed by Wenson Hsieh.
1568
1569 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1570
1571 2018-07-24 Daniel Bates <dabates@apple.com>
1572
1573 Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
1574 https://bugs.webkit.org/show_bug.cgi?id=187971
1575
1576 Reviewed by Saam Barati.
1577
1578 Add unit tests to cover move constructing a NeverDestroyed with a non-co nst and const data type
1579 as well as invoking makeNeverDestroyed() with the result of a function t hat returns a move-only
1580 data type.
1581
1582 * TestWebKitAPI/CMakeLists.txt:
1583 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1584 * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
1585 (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
1586 (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
1587 (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
1588 (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
1589 (TestWebKitAPI::TEST):
1590 * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
1591 * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
1592 (TestWebKitAPI::TEST):
1593
1594 2018-07-24 Thomas Denney <tdenney@apple.com>
1595 Minor changes to the WHLSL interpreter to support the new compiler
1596 https://bugs.webkit.org/show_bug.cgi?id=187728
1597
1598 Reviewed by Myles C. Maxfield.
1599
1600 This bug contains small changes that are make minor changes to the
1601 behaviour of the existing interpreter (the tests are unaffected and all
1602 still pass).
1603
1604 * WebGPUShadingLanguageRI/EnumType.js:
1605 (EnumType.prototype.get isEnum): Property added to EnumType and Type
1606 * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
1607 * WebGPUShadingLanguageRI/Func.js:
1608 (Func.prototype.get isEntryPoint): Add boolean property
1609 * WebGPUShadingLanguageRI/FuncInstantiator.js:
1610 (FuncInstantiator.prototype.get instances): Public accessor for existing
1611 private field
1612 * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
1613 that it directly wraps a Func instance (therefore the only interface
1614 change is to the constructor and the addition of the func accessor).
1615 This change allows the de-inlining of functions.
1616 (FunctionLikeBlock):
1617 (FunctionLikeBlock.prototype.get func):
1618 (FunctionLikeBlock.prototype.get returnType):
1619 (FunctionLikeBlock.prototype.get parameters):
1620 (FunctionLikeBlock.prototype.get body):
1621 * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
1622 constructor
1623 (Inliner.prototype.visitCallExpression):
1624 (Inliner):
1625 * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
1626 to native functions (with additional support in StandardLibrary.js).
1627 This reduces first-time compile-time from around 4s to around 0.1s.
1628 (Intrinsics):
1629 * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
1630 comments completes correctly
1631 (Lexer.prototype.next):
1632 (Lexer):
1633 * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
1634 property, which is based on the type of the lValue and the semantics of
1635 the language (the @ operator yields an array reference with the thread
1636 scope).
1637 (MakeArrayRefExpression):
1638 (MakeArrayRefExpression.prototype.get type):
1639 * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
1640 implementationData to support swizzle operator change
1641 (NativeFunc.prototype.get implementationData):
1642 (NativeFunc.prototype.set implementationData):
1643 * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
1644 constructor
1645 (Rewriter.prototype.visitFunctionLikeBlock):
1646 * WebGPUShadingLanguageRI/StandardLibrary.js:
1647 (_generateSwizzle): Deleted.
1648 * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
1649 carrying metadata about swizzle operators so that they are implemented
1650 as native functions rather than generated at compile time.
1651 (SwizzleOp):
1652 (SwizzleOp.prototype.get outSize):
1653 (SwizzleOp.prototype.get components):
1654 (SwizzleOp.prototype.get inSize):
1655 (SwizzleOp.prototype.toString):
1656 (SwizzleOp.allSwizzleOperators.):
1657 (SwizzleOp.allSwizzleOperators):
1658 * WebGPUShadingLanguageRI/StandardLibrary.js: + (SwizzleOp):
1659 (SwizzleOp.prototype.get outSize):
1660 (SwizzleOp.prototype.get components):
1661 (SwizzleOp.prototype.get inSize):
1662 (SwizzleOp.prototype.toString):
1663 (generateSwizzles):
1664 (_generateSwizzle): Deleted.
1665 * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
1666 above.
1667 (Type.prototype.get isEnum):
1668
1669 2018-07-24 Ryan Haddad <ryanhaddad@apple.com>
1670
1671 Unreviewed, rolling out r234121.
1672
1673 Caused perf test failures.
1674
1675 Reverted changeset:
1676
1677 "We should cache the compiled sandbox profile in a data vault"
1678 https://bugs.webkit.org/show_bug.cgi?id=184991
1679 https://trac.webkit.org/changeset/234121
1680
1681 2018-07-24 Thibault Saunier <tsaunier@igalia.com>
1682
1683 [Flatpak] Add openh264 as needed by WebRTC
1684 https://bugs.webkit.org/show_bug.cgi?id=187956
1685
1686 Reviewed by Philippe Normand.
1687
1688 * flatpak/org.webkit.WebKit.yaml:
1689
1690 2018-07-24 Ross Kirsling <ross.kirsling@sony.com>
1691
1692 WebCore::URL::hostIsIPAddress needs a Windows implementation
1693 https://bugs.webkit.org/show_bug.cgi?id=187859
1694
1695 Reviewed by Fujii Hironori.
1696
1697 * TestWebKitAPI/Tests/WebCore/URL.cpp:
1698 Check for a few other ways an IP address could be invalid.
1699
1700 2018-07-24 Charlie Turner <cturner@igalia.com>
1701
1702 [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
1703 https://bugs.webkit.org/show_bug.cgi?id=187951
1704
1705 When running run-webkit-tests --wpe --debug, it was observed that
1706 both self.platform != 'wpe' and self.debug != True. This turned
1707 out to be because of the "args" argument consuming the remainder
1708 of future arguments that came after it. Since the first argument
1709 to load_from_args was the test script to run, it would end up
1710 never processing the other arguments supplied to the wrapper
1711 script.
1712
1713 Tested this by rebuilding GTK in debug mode, running the
1714 minibrowser with various extra options, and running some tests
1715 with various extra options.
1716
1717 Reviewed by Michael Catanzaro.
1718
1719 * flatpak/flatpakutils.py:
1720 (WebkitFlatpak.load_from_args):
1721
1722 2018-07-24 Thibault Saunier <tsaunier@igalia.com>
1723
1724 [Flatpak] Remove now unnecessary 'hacks' for running tests
1725 https://bugs.webkit.org/show_bug.cgi?id=187608
1726
1727 Reviewed by Philippe Normand.
1728
1729 We used to need to not share X11 with the sandbox when running tests
1730 but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
1731 sandbox (we mount it on `/run/host/tmp` now).
1732
1733 This has the advantage of making running the MiniBrowser to display test
1734 results working again.
1735
1736 * flatpak/flatpakutils.py:
1737 (WebkitFlatpak.clean_args):
1738 (WebkitFlatpak.run_in_sandbox):
1739 (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
1740
1741 2018-07-23 Fujii Hironori <Hironori.Fujii@sony.com>
1742
1743 webkitpy.port.server_process_unittest.TestServerProcess.test_basic faile d on Windows Python
1744 https://bugs.webkit.org/show_bug.cgi?id=187581
1745
1746 Reviewed by Daniel Bates.
1747
1748 There are two failures in this test case:
1749 1. proc.poll() doesn't return 0.
1750 2. stderr is not output.
1751
1752 For failure #1, this is expected. the process should not exit at
1753 the time. proc.poll() should return None because the process is
1754 still alive.
1755
1756 This change added a new test to check proc.poll() becomes 0 after
1757 the process successfully exits.
1758
1759 For failure #2, stderr is not flushed even though stdout is
1760 flushed. This change uses '-u' command switch to force stdin,
1761 stdout and stderr to be totally unbuffered.
1762
1763 * Scripts/webkitpy/port/server_process_unittest.py:
1764 (TestServerProcess.test_basic): Added -u command switch. Do not
1765 flush stdout. Removed the special condition for Windows. Add a new
1766 test to check proc.poll() returns 0.
1767 (TestServerProcess.test_process_crashing): Added -u command
1768 switch. Do not flush stdout.
1769
1770 2018-07-23 Ross Kirsling <ross.kirsling@sony.com>
1771
1772 WTF::StringView::split should have an allowEmptyEntries flag
1773 https://bugs.webkit.org/show_bug.cgi?id=187864
1774
1775 Reviewed by Konstantin Tokarev.
1776
1777 * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
1778
1779 2018-07-23 Ben Richards <benton_richards@apple.com>
1780
1781 We should cache the compiled sandbox profile in a data vault
1782 https://bugs.webkit.org/show_bug.cgi?id=184991
1783
1784 Reviewed by Ryosuke Niwa.
1785
1786 Added trace points for sandbox initialization
1787
1788 * Tracing/SystemTracePoints.plist:
1789
1790 2018-07-23 Zalan Bujtas <zalan@apple.com>
1791
1792 DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
1793 https://bugs.webkit.org/show_bug.cgi?id=187924
1794 <rdar://problem/41745884>
1795
1796 Reviewed by Simon Fraser.
1797
1798 WebKit relies on -viewWillDraw getting called on WebHTMLView, even thoug h that view has not been marked as needing display.
1799
1800 * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1801 (createBitmapContextFromWebView):
1802
1803 2018-07-23 Chris Dumez <cdumez@apple.com>
1804
1805 WebResourceLoadStatisticsStore fails to unregister itself as a MessageRe ceiver in its destructor
1806 https://bugs.webkit.org/show_bug.cgi?id=187910
1807 <rdar://problem/42356526>
1808
1809 Reviewed by Brent Fulgham.
1810
1811 Add API test coverage.
1812
1813 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1814 * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1815 (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
1816 (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
1817 (TEST):
1818 * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Adde d.
1819
1820 2018-07-23 Daniel Bates <dabates@apple.com>
1821
1822 test-webkitpy should take configuration command line options
1823 https://bugs.webkit.org/show_bug.cgi?id=187872
1824
1825 Reviewed by David Kilzer.
1826
1827 Add --debug and --release optional command line options and teach the te st bots to invoke test-webkitpy
1828 with the appropriate configuration. At the moment these options are only meaningful on Mac since they
1829 effect the configuration lldbWebKitTester is built with and we only buil d lldbWebKitTester on Mac.
1830
1831 * BuildSlaveSupport/build.webkit.org-config/steps.py:
1832 (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this w ill effect
1833 how lldbWebKitTester is built. All other ports do not make use of the sp ecified configuration.
1834 * Scripts/webkitpy/test/main.py:
1835 (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
1836 the specified configuration is None then we fall back to using the defau lt configuration (as set
1837 by script set-webkit-configuration).
1838 (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
1839 with a Debug configuration and a Release configuration, respectively
1840 (Tester._run_tests): Pass the configuration to build lldbWebKitTester th at we parsed from
1841 the command line options. It may be None if neither --debug nor --releas e were passed.
1842
1843 2018-07-23 Commit Queue <commit-queue@webkit.org>
1844
1845 Unreviewed, rolling out r233030.
1846 https://bugs.webkit.org/show_bug.cgi?id=187904
1847
1848 Broke tarball builds (Requested by mcatanzaro on #webkit).
1849
1850 Reverted changeset:
1851
1852 "run-gtk-tests (glib/common.py) cannot determine build
1853 directory when webKitBranchBuild=true"
1854 https://bugs.webkit.org/show_bug.cgi?id=185643
1855 https://trac.webkit.org/changeset/233030
1856
1857 2018-07-21 Simon Fraser <simon.fraser@apple.com>
1858
1859 Fix lldb summarizers for HashMaps and HashSets
1860 https://bugs.webkit.org/show_bug.cgi?id=187883
1861
1862 Reviewed by Dan Bates.
1863 ········
1864 HashMap and HashSet summarizers were broken in various ways.
1865 ········
1866 The 'type summary add -x' regexp needs to match at the start and end of the string
1867 to avoid finding types nested inside other templates.
1868 ········
1869 The HashTable synthetic child code incorrectly used the type of the key, rather than
1870 the value when synthesizing children.
1871 ········
1872 Add HashMap and HashSet summarizers.
1873
1874 I tried to get synthetic children working directly for HashMap and HashS et, but was unable.
1875
1876 * lldb/lldbWebKitTester/main.cpp:
1877 (testSummaryProviders):
1878 * lldb/lldb_webkit.py:
1879 (__lldb_init_module):
1880 (__lldb_init_module.lldb_webkit):
1881 (WTFHashMap_SummaryProvider):
1882 (WTFHashSet_SummaryProvider):
1883 (WebCoreColorProvider._to_string_extended):
1884 (WebCoreURLProvider.to_string):
1885 (WTFHashMapProvider):
1886 (WTFHashMapProvider.__init__):
1887 (WTFHashMapProvider.tableSize):
1888 (WTFHashMapProvider.keyCount):
1889 (WTFHashSetProvider):
1890 (WTFHashSetProvider.__init__):
1891 (WTFHashSetProvider.tableSize):
1892 (WTFHashSetProvider.keyCount):
1893 (WTFHashTableProvider.tableSize):
1894 (WTFHashTableProvider):
1895 (WTFHashTableProvider.keyCount):
1896 (WTFHashTableProvider.get_child_at_index):
1897 (WTFHashTableProvider.update):
1898 * lldb/lldb_webkit_unittest.py:
1899 (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
1900 (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capa city):
1901 (TestSummaryProviders):
1902 (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
1903 (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_si ze):
1904 (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
1905
1906 2018-07-21 Simon Fraser <simon.fraser@apple.com>
1907
1908 Add lldb formatters for WebCore geometry types
1909 https://bugs.webkit.org/show_bug.cgi?id=187884
1910
1911 Reviewed by Daniel Bates.
1912 ········
1913 Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSiz e, FloatRect
1914 and LayoutRect.
1915 ········
1916 Testing is blocked by webkit.org/b/187872.
1917
1918 * lldb/lldbWebKitTester/main.cpp:
1919 (testSummaryProviders):
1920 * lldb/lldb_webkit.py:
1921 (__lldb_init_module.lldb_webkit):
1922 (__lldb_init_module):
1923 (WebCoreLayoutRect_SummaryProvider):
1924 (WebCoreIntSize_SummaryProvider):
1925 (WebCoreIntPoint_SummaryProvider):
1926 (WebCoreFloatSize_SummaryProvider):
1927 (WebCoreFloatPoint_SummaryProvider):
1928 (WebCoreIntRect_SummaryProvider):
1929 (WebCoreFloatRect_SummaryProvider):
1930 (WebCoreLayoutRectProvider):
1931 (WebCoreLayoutRectProvider.__init__):
1932 (WebCoreLayoutRectProvider.get_x):
1933 (WebCoreLayoutRectProvider.get_y):
1934 (WebCoreLayoutRectProvider.get_width):
1935 (WebCoreLayoutRectProvider.get_height):
1936 (WebCoreIntPointProvider):
1937 (WebCoreIntPointProvider.__init__):
1938 (WebCoreIntPointProvider.get_x):
1939 (WebCoreIntPointProvider.get_y):
1940 (WebCoreIntSizeProvider):
1941 (WebCoreIntSizeProvider.__init__):
1942 (WebCoreIntSizeProvider.get_width):
1943 (WebCoreIntSizeProvider.get_height):
1944 (WebCoreIntRectProvider):
1945 (WebCoreIntRectProvider.__init__):
1946 (WebCoreIntRectProvider.get_x):
1947 (WebCoreIntRectProvider.get_y):
1948 (WebCoreIntRectProvider.get_width):
1949 (WebCoreIntRectProvider.get_height):
1950 (WebCoreFloatPointProvider):
1951 (WebCoreFloatPointProvider.__init__):
1952 (WebCoreFloatPointProvider.get_x):
1953 (WebCoreFloatPointProvider.get_y):
1954 (WebCoreFloatSizeProvider):
1955 (WebCoreFloatSizeProvider.__init__):
1956 (WebCoreFloatSizeProvider.get_width):
1957 (WebCoreFloatSizeProvider.get_height):
1958 (WebCoreFloatRectProvider):
1959 (WebCoreFloatRectProvider.__init__):
1960 (WebCoreFloatRectProvider.get_x):
1961 (WebCoreFloatRectProvider.get_y):
1962 (WebCoreFloatRectProvider.get_width):
1963 (WebCoreFloatRectProvider.get_height):
1964
1965 2018-07-20 John Wilander <wilander@apple.com>
1966
1967 Resource Load Statistics: Enable basic functionality in experimental deb ug mode
1968 https://bugs.webkit.org/show_bug.cgi?id=187835
1969 <rdar://problem/42408590>
1970
1971 Reviewed by Chris Dumez.
1972
1973 This patch makes the experimental ITP Debug Mode feature work, at least
1974 to a basic level. All of the changes to TestRunner are to support the
1975 layout tests for the functionality.
1976
1977 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1978 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1979 (WTR::InjectedBundle::didReceiveMessageToPage):
1980 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1981 (WTR::TestRunner::setStatisticsDebugMode):
1982 (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
1983 (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1984 (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallb ack):
1985 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1986 * WebKitTestRunner/TestController.cpp:
1987 (WTR::TestController::setStatisticsDebugMode):
1988 (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1989 * WebKitTestRunner/TestController.h:
1990 * WebKitTestRunner/TestInvocation.cpp:
1991 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1992 (WTR::TestInvocation::didSetStatisticsDebugMode):
1993 (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
1994 * WebKitTestRunner/TestInvocation.h:
1995
1996 2018-07-20 Ryosuke Niwa <rniwa@apple.com>
1997
1998 Picking a color from the color panel for typing attributes needs to inve rse transform through color-filter
1999 https://bugs.webkit.org/show_bug.cgi?id=187846
2000
2001 Reviewed by Simon Fraser.
2002
2003 Fixed the bug that testRunner.execCommand was using the second argument as the value.
2004
2005 The second argument, aShowDefaultUI, should always be ignored in testRun ner.execCommand,
2006 and the third argument should be used as the value. DumpRenderTree's imp lementation does this already.
2007
2008 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2009 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2010 (WTR::TestRunner::execCommand):
2011 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2012
2013 2018-07-20 Dean Jackson <dino@apple.com>
2014
2015 Accidentally checked in the wrong version of these files.
2016
2017 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
2018 * lldb/lldbWebKitTester/main.cpp:
2019 (testSummaryProviders):
2020 * lldb/lldb_webkit_unittest.py:
2021 (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capa city):
2022 (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): D eleted.
2023 (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
2024 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Delet ed.
2025 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Dele ted.
2026 (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
2027
2028 2018-07-20 Dean Jackson <dino@apple.com>
2029
2030 Provide an lldb type summary for WebCore::Color
2031 https://bugs.webkit.org/show_bug.cgi?id=187776
2032
2033 Reviewed by Dan Bates.
2034
2035 This time without the tests because we don't want to build
2036 all of WebKit just for python tests.
2037
2038 * lldb/lldb_webkit.py: Add a Color summary provider.
2039 (__lldb_init_module):
2040 (WebCoreColor_SummaryProvider):
2041 (WebCoreColorProvider):
2042 (WebCoreColorProvider.__init__):
2043 (WebCoreColorProvider._is_extended):
2044 (WebCoreColorProvider._is_valid):
2045 (WebCoreColorProvider._is_semantic):
2046 (WebCoreColorProvider._to_string_extended):
2047 (WebCoreColorProvider.to_string):
2048
2049 2018-07-20 Brady Eidson <beidson@apple.com>
2050
2051 Add WKNavigation/WKNavigationAction related SPI.
2052 https://bugs.webkit.org/show_bug.cgi?id=187826
2053
2054 Reviewed by Chris Dumez.
2055
2056 * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2057 (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
2058 (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigati onAction:decisionHandler:]):
2059 (TEST):
2060
2061 2018-07-20 Commit Queue <commit-queue@webkit.org>
2062
2063 Unreviewed, rolling out r233943, r233988, r234004, and
2064 r234012.
2065 https://bugs.webkit.org/show_bug.cgi?id=187856
2066
2067 webkitpy tests are failing to build lldbWebKitTester
2068 (Requested by ryanhaddad on #webkit).
2069
2070 Reverted changesets:
2071
2072 "Provide an lldb type summary for WebCore::Color"
2073 https://bugs.webkit.org/show_bug.cgi?id=187776
2074 https://trac.webkit.org/changeset/233943
2075
2076 "Provide an lldb type summary for WebCore::Color"
2077 https://bugs.webkit.org/show_bug.cgi?id=187776
2078 https://trac.webkit.org/changeset/233988
2079
2080 "Provide an lldb type summary for WebCore::Color"
2081 https://bugs.webkit.org/show_bug.cgi?id=187776
2082 https://trac.webkit.org/changeset/234004
2083
2084 "Provide an lldb type summary for WebCore::Color"
2085 https://bugs.webkit.org/show_bug.cgi?id=187776
2086 https://trac.webkit.org/changeset/234012
2087
2088 2018-07-20 Philippe Normand <pnormand@igalia.com>
2089
2090 [GTK][WPE] enable-media-capabilities websetting
2091 https://bugs.webkit.org/show_bug.cgi?id=187847
2092
2093 Reviewed by Carlos Garcia Campos.
2094
2095 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2096 (testWebKitSettings): Unit test for the new enable-media-capabilities se tting.
2097
2098 2018-07-19 Carlos Garcia Campos <cgarcia@igalia.com>
2099
2100 [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
2101 https://bugs.webkit.org/show_bug.cgi?id=187798
2102
2103 Reviewed by Michael Catanzaro.
2104
2105 Update test cases to the new API and use a destroy function and vtable i n the test case of calling
2106 jsc_context_evaluate_in_object() with a JSCClass.
2107
2108 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2109 (testJSCEvaluateInObject):
2110
2111 2018-07-19 Ross Kirsling <ross.kirsling@sony.com>
2112
2113 TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windo ws
2114 https://bugs.webkit.org/show_bug.cgi?id=187712
2115
2116 Reviewed by Fujii Hironori.
2117
2118 * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2119 Mark result of unsigned short test case as platform-specific,
2120 since Windows' behavior is actually *less* surprising here.
2121
2122 2018-07-19 Lucas Forschler <lforschler@apple.com>
2123
2124 Teach the AWS Lambda to use the [minified]-platforms database
2125 https://bugs.webkit.org/show_bug.cgi?id=187817
2126 ········
2127 Reviewed by David Kilzer.
2128
2129 * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
2130 (lambda_handler): Add support for the platforms.webkit.org database
2131 * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.p y:
2132 (lambda_handler): Add support for the minified-platforms.webkit.org data base
2133
2134 2018-07-19 Dean Jackson <dino@apple.com>
2135
2136 Provide an lldb type summary for WebCore::Color
2137 https://bugs.webkit.org/show_bug.cgi?id=187776
2138
2139 Dan Bates helped me with this attempted fix. Fingers crossed!
2140
2141 * Scripts/build-lldbwebkittester:
2142
2143 2018-07-19 Stephan Szabo <stephan.szabo@sony.com>
2144
2145 [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspect or
2146 https://bugs.webkit.org/show_bug.cgi?id=187786
2147
2148 Reviewed by Fujii Hironori.
2149
2150 * Scripts/webkitdirs.pm:
2151 (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
2152 for WinCairo builds.
2153
2154 2018-07-19 Dean Jackson <dino@apple.com>
2155
2156 Provide an lldb type summary for WebCore::Color
2157 https://bugs.webkit.org/show_bug.cgi?id=187776
2158
2159 Another attempted build fix for Debug.
2160
2161 * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2162 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
2163
2164 2018-07-19 Thomas Denney <tdenney@apple.com>
2165
2166 [WHLSL] The interpreter doesn't support boolean short-circuiting
2167 https://bugs.webkit.org/show_bug.cgi?id=187779
2168
2169 Reviewed by Alex Christensen.
2170
2171 * WebGPUShadingLanguageRI/Evaluator.js:
2172 (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
2173 * WebGPUShadingLanguageRI/Test.js:
2174 (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logic al expresions
2175
2176 2018-07-19 Dean Jackson <dino@apple.com>
2177
2178 Provide an lldb type summary for WebCore::Color
2179 https://bugs.webkit.org/show_bug.cgi?id=187776
2180
2181 Attempted build fix.
2182
2183 * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2184
2185 2018-07-19 Brady Eidson <beidson@apple.com>
2186
2187 Add an SPI policy action to allow clients to explicitly ask for a new pr ocess on a navigation.
2188 https://bugs.webkit.org/show_bug.cgi?id=187789
2189
2190 Reviewed by Andy Estes.
2191
2192 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2193 (-[PSONNavigationDelegate init]):
2194 (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisi onHandler:]):
2195
2196 2018-07-19 Thibault Saunier <tsaunier@igalia.com>
2197
2198 [Flatpak] Let flatpak process handle SIGINT
2199 https://bugs.webkit.org/show_bug.cgi?id=187521
2200
2201 Reviewed by Philippe Normand.
2202
2203 Ensuring that flatpak process ends properly and that the sandbox is tear d down.
2204 It also avoids showing usless backtrace to the end user and makes gdb
2205 much more usable.
2206
2207 Also make flatpakutils not verbose by default
2208
2209 * flatpak/flatpakutils.py:
2210 (disable_signals):
2211 (WebkitFlatpak.run_in_sandbox):
2212 (WebkitFlatpak.run_gdb):
2213
2214 2018-07-18 Stephan Szabo <stephan.szabo@sony.com>
2215
2216 Unreviewed. Fix contributors entry.
2217
2218 * Scripts/webkitpy/common/config/contributors.json:
2219
2220 2018-07-18 Dean Jackson <dino@apple.com>
2221
2222 Provide an lldb type summary for WebCore::Color
2223 https://bugs.webkit.org/show_bug.cgi?id=187776
2224
2225 Reviewed by Dan Bates.
2226
2227 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
2228 to get to WebCore.
2229 * lldb/lldbWebKitTester/main.cpp:
2230 (testSummaryProviders): Create some Color objects for testing.
2231
2232 * lldb/lldb_webkit.py: Add a Color summary provider.
2233 (__lldb_init_module):
2234 (WebCoreColor_SummaryProvider):
2235 (WebCoreColorProvider):
2236 (WebCoreColorProvider.__init__):
2237 (WebCoreColorProvider._is_extended):
2238 (WebCoreColorProvider._is_valid):
2239 (WebCoreColorProvider._is_semantic):
2240 (WebCoreColorProvider._to_string_extended):
2241 (WebCoreColorProvider.to_string):
2242
2243 * lldb/lldb_webkit_unittest.py: Tests.
2244 (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capa city):
2245 (TestSummaryProviders):
2246 (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
2247 (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
2248 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
2249 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
2250
2251 2018-07-18 Truitt Savell <tsavell@apple.com>
2252
2253 Unreviewed, rolling out r233934.
2254
2255 Revision caused 5 webkitpy failures on Mac and broke webkitpy
2256 testing on iOS simulator
2257
2258 Reverted changeset:
2259
2260 "Provide an lldb type summary for WebCore::Color"
2261 https://bugs.webkit.org/show_bug.cgi?id=187776
2262 https://trac.webkit.org/changeset/233934
2263
2264 2018-07-18 Chris Dumez <cdumez@apple.com>
2265
2266 REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Developme nt at com.apple.WebKit: WKBooleanGetValue + 9
2267 https://bugs.webkit.org/show_bug.cgi?id=187784
2268 <rdar://problem/42329230>
2269
2270 Reviewed by Brady Eidson.
2271
2272 When process swapping on navigation, WebPageProxy::reattachToWebProcess( ) unregisters the page as a MessageReceiver
2273 from the old WebProcessProxy and registers itself as a MessageReceiver f or the new WebProcessProxy instead. This
2274 means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
2275
2276 When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
2277 about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
2278 which would fail and would cause WKBundlePagePostSynchronousMessageForTe sting() to return a null result. WKTR
2279 would crash when dereferencing this null result. This patch addresses th is by dealing with the potential null
2280 result.
2281
2282 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2283 (WTR::InjectedBundle::shouldProcessWorkQueue const):
2284
2285 2018-07-18 Dean Jackson <dino@apple.com>
2286
2287 Provide an lldb type summary for WebCore::Color
2288 https://bugs.webkit.org/show_bug.cgi?id=187776
2289
2290 Reviewed by Dan Bates.
2291
2292 * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
2293 to get to WebCore.
2294 * lldb/lldbWebKitTester/main.cpp:
2295 (testSummaryProviders): Create some Color objects for testing.
2296
2297 * lldb/lldb_webkit.py: Add a Color summary provider.
2298 (__lldb_init_module):
2299 (WebCoreColor_SummaryProvider):
2300 (WebCoreColorProvider):
2301 (WebCoreColorProvider.__init__):
2302 (WebCoreColorProvider._is_extended):
2303 (WebCoreColorProvider._is_valid):
2304 (WebCoreColorProvider._is_semantic):
2305 (WebCoreColorProvider._to_string_extended):
2306 (WebCoreColorProvider.to_string):
2307
2308 * lldb/lldb_webkit_unittest.py: Tests.
2309 (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capa city):
2310 (TestSummaryProviders):
2311 (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
2312 (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
2313 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
2314 (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
2315
2316 2018-07-18 Stephan Szabo <stephan.szabo@sony.com>
2317
2318 Adding myself to contributors.json
2319
2320 Unreviewed contributors.json change.
2321
2322 * Scripts/webkitpy/common/config/contributors.json:
2323
2324 2018-07-18 Jer Noble <jer.noble@apple.com>
2325
2326 -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
2327 https://bugs.webkit.org/show_bug.cgi?id=187739
2328 <rdar://problem/42304518>
2329
2330 Reviewed by Tim Horton.
2331
2332 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2333 (TEST):
2334
2335 2018-07-18 Jer Noble <jer.noble@apple.com>
2336
2337 PiP from Element Fullscreen should match AVKit's behavior
2338 https://bugs.webkit.org/show_bug.cgi?id=187623
2339 <rdar://problem/41212379>
2340
2341 Reviewed by Jon Lee.
2342
2343 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2344 * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
2345 * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
2346 (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictur eDidChange:]):
2347 (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
2348 (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
2349 (TestWebKitAPI::TEST):
2350
2351 2018-07-18 Aakash Jain <aakash_jain@apple.com>
2352
2353 [ews-build] Add build step to run layout-test
2354 https://bugs.webkit.org/show_bug.cgi?id=187674
2355
2356 Reviewed by Lucas Forschler.
2357
2358 * BuildSlaveSupport/ews-build/steps.py:
2359 (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
2360 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2361 * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layo ut-test in iOSSimulatorFactory.
2362
2363 2018-07-18 Wenson Hsieh <wenson_hsieh@apple.com>
2364
2365 Add SPI to defer running async script until after document load
2366 https://bugs.webkit.org/show_bug.cgi?id=187748
2367 <rdar://problem/42317378>
2368
2369 Reviewed by Ryosuke Niwa and Tim Horton.
2370
2371 Add an API test to verify that when the deferred async script configurat ion is set, async scripts will be
2372 executed after the DOMContentLoaded event.
2373
2374 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2375 * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
2376 (TEST):
2377
2378 2018-07-18 Charlie Turner <cturner@igalia.com>
2379
2380 [WPE] Update WPEBackend in flatpak
2381 https://bugs.webkit.org/show_bug.cgi?id=187753
2382
2383 r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
2384 caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
2385 in the version guard,
2386
2387 #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2 , 0)
2388
2389 This doesn't work as intended, since the C preprocessor first expands
2390 all macro arguments in the #if expression before evaluating the
2391 expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
2392 lead to a syntax error and some head scratching.
2393
2394 A future patch should address the buggy macro check, when it is
2395 decided whether the assume the macro is always defined and bump
2396 the API requirements on WPEBackend, or to move the check into two
2397 conditionals to avoid the expansion problem.
2398
2399 Unreviewed build fix.
2400 ········
2401 * flatpak/org.webkit.WPE.yaml:
2402
2403 2018-07-18 Simon Fraser <simon.fraser@apple.com>
2404
2405 Fix the parsing of colors in attributed string tests, and make it possib le to dump the typing attributes
2406 https://bugs.webkit.org/show_bug.cgi?id=187747
2407
2408 Reviewed by Ryosuke Niwa.
2409 ········
2410 Add textInputController.attributedStringForTyping(), which returns a one -character
2411 attributed string whose attributes are the typing attributes, making it possible to
2412 test -[WebView typingAttributes].
2413 ········
2414 Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NS Dictionary,
2415 so we can't return -typingAttributes directly.
2416
2417 * DumpRenderTree/mac/TextInputControllerMac.m:
2418 (+[TextInputController isSelectorExcludedFromWebScript:]):
2419 (-[TextInputController attributedStringForTyping]):
2420
2421 2018-07-18 Carlos Garcia Campos <cgarcia@igalia.com>
2422
2423 [GLIB] Add jsc_context_check_syntax() to GLib API
2424 https://bugs.webkit.org/show_bug.cgi?id=187694
2425
2426 Reviewed by Yusuke Suzuki.
2427
2428 Add a new test case.
2429
2430 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2431 (testJSCCheckSyntax):
2432 (main):
2433
2434 2018-07-17 Sihui Liu <sihui_liu@apple.com>
2435
2436 REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPa ths is a flaky failure
2437 https://bugs.webkit.org/show_bug.cgi?id=187066
2438 <rdar://problem/41609065>
2439
2440 Reviewed by Chris Dumez.
2441
2442 In r232668 we started to do reload if web process crashes by default. As we killed the web·
2443 process explicitly in this test, if web page got reloaded, messages woul d be sent again,·
2444 and flag set in message handler could keep the test continue to evaluate the expectation·
2445 without waiting for removeDataOfTypes to finish.
2446
2447 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2448 (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDid Terminate:]):
2449 (TEST):
2450
2451 2018-07-17 Chris Dumez <cdumez@apple.com>
2452
2453 Turn on PSON in WebKitTestRunner
2454 https://bugs.webkit.org/show_bug.cgi?id=186542
2455
2456 Reviewed by Brady Eidson.
2457
2458 Turn on PSON by default in WebKitTestRunner.
2459
2460 * WebKitTestRunner/TestOptions.h:
2461
2462 2018-07-17 Wenson Hsieh <wenson_hsieh@apple.com>
2463
2464 Add an SPI hook to allow clients to yield document parsing and script ex ecution
2465 https://bugs.webkit.org/show_bug.cgi?id=187682
2466 <rdar://problem/42207453>
2467
2468 Reviewed by Ryosuke Niwa.
2469
2470 Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
2471 document load, and that doing so doesn't cause deferred `script` to exec ute in the wrong order (i.e. before
2472 synchronous script, or after "DOMContentLoaded").
2473
2474 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475 * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
2476 (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
2477 (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
2478 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCo mmitLoadForFrame:]):
2479 (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextContro ller:]):
2480 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFi nishDocumentLoadForFrame:]):
2481 (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFi nishLoadForFrame:]):
2482
2483 Add an injected bundle object that knows how to take and release multipl e document parser yield tokens.
2484
2485 * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
2486 * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
2487 (+[ParserYieldTokenTestWebView webView]):
2488 (-[ParserYieldTokenTestWebView bundle]):
2489 (-[ParserYieldTokenTestWebView schemeHandler]):
2490 (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
2491 (-[ParserYieldTokenTestWebView didFinishLoad]):
2492 (waitForDelay):
2493 (TEST):
2494 * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
2495 * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
2496 (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
2497 (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
2498 (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
2499 (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
2500 (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
2501 (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
2502
2503 Add a new test helper class to handle custom schemes via a block-based A PI.
2504
2505 * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
2506
2507 New test HTML page that contains a deferred script element, a synchronou s script element, another deferred
2508 script element, and then some text, images, and links.
2509
2510 * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
2511
2512 2018-07-17 Truitt Savell <tsavell@apple.com>
2513
2514 Adding myself to Contributors.json
2515
2516 Unreviewed
2517
2518 * Scripts/webkitpy/common/config/contributors.json:
2519
2520 2018-07-17 Aditya Keerthi <akeerthi@apple.com>
2521
2522 [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
2523 https://bugs.webkit.org/show_bug.cgi?id=187730
2524
2525 Reviewed by Jer Noble.
2526
2527 This regression was introduced by r233865. PIP can now only be initiated from a
2528 window that is on screen.
2529
2530 * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2531 (TestWebKitAPI::TEST):
2532
2533 2018-07-17 John Wilander <wilander@apple.com>
2534
2535 Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStat isticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
2536 https://bugs.webkit.org/show_bug.cgi?id=187710
2537 <rdar://problem/42252757>
2538
2539 Reviewed by Chris Dumez.
2540
2541 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2542 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2543 (WTR::InjectedBundle::didReceiveMessageToPage):
2544 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2545 (WTR::TestRunner::setStatisticsLastSeen):
2546 (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
2547 (WTR::TestRunner::setStatisticsPrevalentResource):
2548 (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
2549 (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2550 (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
2551 (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2552 (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
2553 (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
2554 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2555 * WebKitTestRunner/TestController.cpp:
2556 (WTR::TestController::setStatisticsLastSeen):
2557 (WTR::TestController::setStatisticsPrevalentResource):
2558 (WTR::TestController::setStatisticsVeryPrevalentResource):
2559 (WTR::TestController::setStatisticsHasHadUserInteraction):
2560 (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
2561 * WebKitTestRunner/TestInvocation.cpp:
2562 (WTR::TestInvocation::didSetLastSeen):
2563 (WTR::TestInvocation::didSetPrevalentResource):
2564 (WTR::TestInvocation::didSetVeryPrevalentResource):
2565 (WTR::TestInvocation::didSetHasHadUserInteraction):
2566 (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
2567 * WebKitTestRunner/TestInvocation.h:
2568
2569 2018-07-16 Jeremy Jones <jeremyj@apple.com>
2570
2571 Fix API Test failures introduced by r233865
2572 https://bugs.webkit.org/show_bug.cgi?id=187720
2573
2574 Unreviewed APITest fix after r233865.
2575
2576 Fullscreen can now only be initiated from a window that is on screen.
2577
2578 * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2579 (TestWebKitAPI::TEST):
2580 * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
2581 (TestWebKitAPI::TEST):
2582
2583 2018-07-11 Dean Jackson <dino@apple.com>
2584
2585 Allow removal of white backgrounds
2586 https://bugs.webkit.org/show_bug.cgi?id=187574
2587 <rdar://problem/41146792>
2588
2589 Reviewed by Simon Fraser.
2590
2591 Add a new menu item for punching out white backgrounds in MiniBrowser.
2592 In WebKitTestRunner, expose the new setting and hook that up to
2593 drawing a background in the WebView.
2594
2595 * MiniBrowser/mac/AppDelegate.m:
2596 (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
2597
2598 * MiniBrowser/mac/SettingsController.h: Ditto.
2599 * MiniBrowser/mac/SettingsController.m:
2600 (-[SettingsController _populateMenu]):
2601 (-[SettingsController validateMenuItem:]):
2602 (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
2603 (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
2604
2605 * MiniBrowser/mac/WK1BrowserWindowController.m:
2606 (-[WK1BrowserWindowController didChangeSettings]): Set the new preferenc e.
2607
2608 * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
2609 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
2610 (WTR::PlatformWebView::drawsBackground const):
2611 (WTR::PlatformWebView::setDrawsBackground):
2612 * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
2613 (WTR::PlatformWebView::drawsBackground const):
2614 (WTR::PlatformWebView::setDrawsBackground):
2615 * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView an d
2616 set its SPI.
2617 (WTR::PlatformWebView::drawsBackground const):
2618 (WTR::PlatformWebView::setDrawsBackground):
2619 * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
2620 (WTR::PlatformWebView::drawsBackground const):
2621 (WTR::PlatformWebView::setDrawsBackground):
2622
2623 * WebKitTestRunner/TestController.cpp: Reset and copy the new preference .
2624 (WTR::TestController::resetPreferencesToConsistentValues):
2625 (WTR::updateTestOptionsFromTestHeader):
2626 * WebKitTestRunner/TestOptions.h:
2627 (WTR::TestOptions::hasSameInitializationOptions const):
2628
2629 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2630 (WTR::TestController::platformCreateWebView): If the option for punching
2631 out the background was set, tell the WebView to not draw its background.
2632
2633 2018-07-16 Aditya Keerthi <akeerthi@apple.com>
2634
2635 [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
2636 https://bugs.webkit.org/show_bug.cgi?id=186531
2637
2638 Reviewed by Tim Horton.
2639
2640 Added isShowingDatalistSuggestions testing hook in order to enable testi ng of the
2641 visibility of the suggestions view.
2642
2643 * DumpRenderTree/mac/UIScriptControllerMac.mm:
2644 (WTR::UIScriptController::isShowingDataListSuggestions const):
2645 * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2646 * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2647 (WTR::UIScriptController::isShowingDataListSuggestions const):
2648 * TestRunnerShared/UIScriptContext/UIScriptController.h:
2649 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2650 (WTR::UIScriptController::isShowingDataListSuggestions const):
2651
2652 2018-07-16 Yusuke Suzuki <utatane.tea@gmail.com>
2653
2654 Add --target-path option to dump-class-layout
2655 https://bugs.webkit.org/show_bug.cgi?id=187687
2656
2657 Reviewed by Simon Fraser.
2658
2659 We add an escape hatch to dump-class-layout for specifying target path d irectly.
2660 This `--target-path` allows us to use dump-class-layout in the other por ts
2661 like JSCOnly.
2662
2663 We can dump class layout if we build the target with clang by using the following command.
2664
2665 Tools/Scripts/dump-class-layout \
2666 --architecture=x86_64 \
2667 --target-path=path/to/libJavaScriptCore.so \
2668 JavaScriptCore \
2669 ScopeNode
2670
2671 * Scripts/dump-class-layout:
2672 (main):
2673
2674 2018-07-16 Sihui Liu <sihui_liu@apple.com>
2675
2676 IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
2677 https://bugs.webkit.org/show_bug.cgi?id=187631
2678 <rdar://problem/42164227>
2679
2680 Reviewed by Brady Eidson.
2681
2682 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2683 (TEST):
2684
2685 2018-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
2686
2687 [GLIB] Add API to evaluate code using a given object to store global sym bols
2688 https://bugs.webkit.org/show_bug.cgi?id=187639
2689
2690 Reviewed by Michael Catanzaro.
2691
2692 Add a new test case.
2693
2694 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2695 (testJSCEvaluateInObject):
2696 (testJSCExceptions):
2697 (main):
2698
2699 2018-07-15 Zan Dobersek <zdobersek@igalia.com>
2700
2701 [webkitpy] run-web-platform-tests should allow specifying custom WPT met adata directories
2702 https://bugs.webkit.org/show_bug.cgi?id=187353
2703
2704 Reviewed by Youenn Fablet.
2705
2706 When using run-web-platform-tests, allow specifying custom WPT metadata
2707 directory. This will avoid generating such metadata-filled directory
2708 from the port-specific JSON expectations file, and instead will search
2709 for the metadata files and the include manifest inside the specified
2710 directory. The MANIFEST.json file will also be generated under there.
2711
2712 Rationale for this change is prototyping using custom metadata
2713 directories and avoiding generating all this content from a JSON file.
2714 Using this by default in the future would avoid sporradic changes in how
2715 WPT handles metadata .ini files and releases us from the obligation of
2716 adjusting the generator for every such change. This would also allow
2717 managing this metadata content in a separate repository, avoiding
2718 polluting the main webkit.org repository with thousands of .ini files.
2719
2720 If this turns out to be the preferable way of managing the metadata
2721 content, the JSON files under WebPlatformTests/ and the related code in
2722 wpt_runner.py would be removed.
2723
2724 * Scripts/webkitpy/w3c/wpt_runner.py:
2725 (parse_args):
2726 (WPTRunner._wpt_run_paths):
2727 (WPTRunner.run):
2728 * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
2729 (WPTRunnerTest.test_run_with_specified_options):
2730
2731 2018-07-13 Ross Kirsling <ross.kirsling@sony.com>
2732
2733 [WinCairo] run-api-tests is timing out for almost all test cases
2734 https://bugs.webkit.org/show_bug.cgi?id=187547
2735
2736 Reviewed by Fujii Hironori.
2737
2738 * Scripts/webkitpy/port/server_process.py:
2739 (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2740 Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
2741
2742 * Scripts/webkitpy/port/server_process_unittest.py:
2743 (TestServerProcess.test_read_after_process_exits):
2744 Add test case.
2745
2746 2018-07-13 Ryan Haddad <ryanhaddad@apple.com>
2747
2748 Add TestExpectations and baselines for iOS 12
2749 https://bugs.webkit.org/show_bug.cgi?id=187628
2750
2751 Reviewed by Alexey Proskuryakov.
2752
2753 * Scripts/webkitpy/port/ios.py:
2754 (IOSPort): Bump current version to 12.
2755
2756 2018-07-13 Ryan Haddad <ryanhaddad@apple.com>
2757
2758 Add TestExpectations and baselines for Mojave.
2759 https://bugs.webkit.org/show_bug.cgi?id=187620
2760
2761 Reviewed by Alexey Proskuryakov.
2762
2763 * Scripts/webkitpy/port/mac.py:
2764 (MacPort): Bump current version to 10.14.
2765
2766 2018-07-13 Timothy Hatcher <timothy@apple.com>
2767
2768 Add _drawsBackground to WKWebViewConfiguration.
2769 https://bugs.webkit.org/show_bug.cgi?id=187665
2770 rdar://problem/42182268
2771
2772 Reviewed by Tim Horton.
2773
2774 * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2775 (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
2776
2777 2018-07-13 Chris Dumez <cdumez@apple.com>
2778
2779 Add a FrameLoaderClient willInjectUserScriptForFrame callback
2780 https://bugs.webkit.org/show_bug.cgi?id=187565
2781 <rdar://problem/42095701>
2782
2783 Unreviewed WKTR fix after r233782.
2784
2785 * WebKitTestRunner/TestInvocation.cpp:
2786 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2787
2788 2018-07-13 Chris Dumez <cdumez@apple.com>
2789
2790 Reduce size of WebCore::URL
2791 https://bugs.webkit.org/show_bug.cgi?id=186820
2792 <rdar://problem/42087508>
2793
2794 Unreviewed, re-generates Service worker registrations database used by A PI tests after r233789.
2795
2796 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2797 * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sql ite3: Removed.
2798 * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sql ite3-shm: Removed.
2799 * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sql ite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegi strations-2.sqlite3-wal.
2800 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2801 (TEST):
2802
2803 2018-07-12 Wenson Hsieh <wenson_hsieh@apple.com>
2804
2805 Make it easier to hit the significant rendered text layout milestone on pages with main article elements
2806 https://bugs.webkit.org/show_bug.cgi?id=187578
2807 <rdar://problem/42104637>
2808
2809 Reviewed by Ryosuke Niwa.
2810
2811 Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
2812 page with an article element that is clearly the "main" content on the p age (i.e. much taller than all other
2813 articles).
2814
2815 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816 * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.htm l: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone. html.
2817 * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
2818 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2819 (TEST):
2820
2821 2018-07-12 Fujii Hironori <Hironori.Fujii@sony.com>
2822
2823 Change my status to be a WebKit reviewer.
2824
2825 Unreviewed status update.
2826
2827 * Scripts/webkitpy/common/config/contributors.json:
2828
2829 2018-07-12 Fujii Hironori <Hironori.Fujii@sony.com>
2830
2831 Unreviewed contributors.json update
2832
2833 Just run "validate-committer-lists -c" to canonicalize the style.
2834
2835 * Scripts/webkitpy/common/config/contributors.json:
2836
2837 2018-07-12 Alex Christensen <achristensen@webkit.org>
2838
2839 Reduce size of WebCore::URL
2840 https://bugs.webkit.org/show_bug.cgi?id=186820
2841
2842 Reviewed by Yusuke Suzuki and Youenn Fablet.
2843
2844 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2845 (TestWebKitAPI::TEST_F):
2846
2847 2018-07-12 Brady Eidson <beidson@apple.com>
2848
2849 Make process-swap-on-navigation an experimental feature.
2850 <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=18 7558
2851
2852 Reviewed by Chris Dumez.
2853
2854 Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
2855
2856 * WebKitTestRunner/TestController.cpp:
2857 (WTR::TestController::createWebViewWithOptions):
2858 (WTR::TestController::resetPreferencesToConsistentValues):
2859
2860 * WebKitTestRunner/TestOptions.h:
2861 (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
2862
2863 2018-07-12 Youenn Fablet <youenn@apple.com>
2864
2865 Add a FrameLoaderClient willInjectUserScriptForFrame callback
2866 https://bugs.webkit.org/show_bug.cgi?id=187565
2867
2868 Reviewed by Alex Christensen.
2869
2870 Added new test runner API to check for willInjectUserScriptForFrame call back.
2871
2872 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2873 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2874 (WTR::InjectedBundle::resetUserScriptInjectedCount):
2875 (WTR::InjectedBundle::increaseUserScriptInjectedCount):
2876 (WTR::InjectedBundle::userScriptInjectedCount const):
2877 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2878 (WTR::InjectedBundlePage::InjectedBundlePage):
2879 (WTR::InjectedBundlePage::resetAfterTest):
2880 (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
2881 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2882 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2883 (WTR::TestRunner::userScriptInjectedCount const):
2884 (WTR::TestRunner::injectUserScript):
2885 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2886 * WebKitTestRunner/TestController.cpp:
2887 (WTR::TestController::injectUserScript):
2888 * WebKitTestRunner/TestController.h:
2889 * WebKitTestRunner/TestInvocation.cpp:
2890 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2891 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2892 (WTR::TestController::injectUserScript):
2893
2894 2018-07-12 Sihui Liu <sihui_liu@apple.com>
2895
2896 IndexedDB: database file of subframe cannot be removed
2897 https://bugs.webkit.org/show_bug.cgi?id=187564
2898
2899 Reviewed by Youenn Fablet.
2900
2901 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2902 * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2903 (TEST):
2904
2905 2018-07-12 Timothy Hatcher <timothy@apple.com>
2906
2907 Make WebKit.LinkColorWithSystemAppearance work across system versions.
2908 https://bugs.webkit.org/show_bug.cgi?id=187573
2909
2910 Reviewed by Wenson Hsieh.
2911
2912 * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2913 (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically genera te the expected string.
2914
2915 2018-07-11 Carlos Garcia Campos <cgarcia@igalia.com>
2916
2917 [WPE] Pass the backend library name as command line parameter to the web process
2918 https://bugs.webkit.org/show_bug.cgi?id=186841
2919
2920 Reviewed by Žan Doberšek.
2921
2922 * MiniBrowser/wpe/main.cpp:
2923 (main): Stop using WPE_BACKEND_LIBRARY env var.
2924 * Scripts/run-wpe-tests:
2925 (WPETestRunner.__init__): Ditto.
2926 * Scripts/webkitpy/port/wpe.py:
2927 (WPEPort.setup_environ_for_server): Ditto.
2928 * wpe/backends/ViewBackend.cpp:
2929 (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() t o ensure WPEBackend-fdo is used.
2930 * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
2931
2932 2018-07-11 Carlos Garcia Campos <cgarcia@igalia.com>
2933
2934 [GLIB] Add API to allow creating variadic functions
2935 https://bugs.webkit.org/show_bug.cgi?id=187517
2936
2937 Reviewed by Michael Catanzaro.
2938
2939 Add test cases.
2940
2941 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2942 (testJSCFunction):
2943 (fooCreateWithFooV):
2944 (multiplyFooV):
2945
2946 2018-07-11 Carlos Garcia Campos <cgarcia@igalia.com>
2947
2948 [GLIB] Add jsc_context_get_global_object() to GLib API
2949 https://bugs.webkit.org/show_bug.cgi?id=187515
2950
2951 Reviewed by Michael Catanzaro.
2952
2953 Add test cases.
2954
2955 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2956 (testJSCGlobalObject):
2957 (main):
2958
2959 2018-07-11 Carlos Garcia Campos <cgarcia@igalia.com>
2960
2961 [GLIB] Handle G_TYPE_STRV in glib API
2962 https://bugs.webkit.org/show_bug.cgi?id=187512
2963
2964 Reviewed by Michael Catanzaro.
2965
2966 Add test cases.
2967
2968 * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2969 (testJSCTypes):
2970 (joinFunction):
2971 (testJSCFunction):
2972
2973 2018-07-11 Aakash Jain <aakash_jain@apple.com>
2974
2975 [ews-build] EWS should unapply patch and re-run jsc tests when patch fai ls jsc tests
2976 https://bugs.webkit.org/show_bug.cgi?id=187549
2977
2978 Reviewed by Alexey Proskuryakov.
2979
2980 * BuildSlaveSupport/ews-build/factories.py:
2981 (JSCTestsFactory.__init__):
2982 * BuildSlaveSupport/ews-build/steps.py:
2983 (CompileJSCOnlyToT): Build ToT without patch.
2984 (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to buil d.
2985 (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests proper ty appropriately.
2986 (ReRunJavaScriptCoreTests): Re-runs JSC tests.
2987 (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
2988 (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests prop erty appropriately.
2989 (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
2990 (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
2991 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2992
2993 2018-07-11 Commit Queue <commit-queue@webkit.org>
2994
2995 Unreviewed, rolling out r233742.
2996 https://bugs.webkit.org/show_bug.cgi?id=187577
2997
2998 Binary incompatible change with respect to Service Worker
2999 registration map (Requested by dydz on #webkit).
3000
3001 Reverted changeset:
3002
3003 "Reduce size of WebCore::URL"
3004 https://bugs.webkit.org/show_bug.cgi?id=186820
3005 https://trac.webkit.org/changeset/233742
3006
3007 2018-07-11 Aditya Keerthi <akeerthi@apple.com>
3008
3009 REGRESSION (231276): Attempting to copy an image fails
3010 https://bugs.webkit.org/show_bug.cgi?id=187212
3011
3012 Reviewed by Ryosuke Niwa.
3013 <rdar://problem/41540074>
3014
3015 Augmented test to include a URL where the lastPathComponent looks simila r to a
3016 file URL.
3017
3018 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
3019 * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3020 (TestWebKitAPI::TEST):
3021
3022 2018-07-11 Alex Christensen <achristensen@webkit.org>
3023
3024 Add SPI for immediate injection of user scripts
3025 https://bugs.webkit.org/show_bug.cgi?id=173342
3026 <rdar://problem/29202285>
3027
3028 Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
3029
3030 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3031 (waitForMessage):
3032 (TEST):
3033
3034 2018-07-11 Myles C. Maxfield <mmaxfield@apple.com>
3035
3036 Move WHLSL spec work to the W3C GPUWeb GitHub repository
3037
3038 See https://github.com/gpuweb/WHLSL
3039
3040 * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
3041 * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
3042 * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
3043 * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
3044 * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
3045
3046 2018-07-11 Dean Jackson <dino@apple.com>
3047
3048 Force WKTR to use the light appearance
3049 https://bugs.webkit.org/show_bug.cgi?id=187572
3050 <rdar://problem/42097805>
3051
3052 Reviewed by Simon Fraser.
3053
3054 Set the NSAppearance on the NSWindow to light mode.
3055
3056 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3057 (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
3058
3059 2018-07-11 Alex Christensen <achristensen@webkit.org>
3060
3061 Reduce size of WebCore::URL
3062 https://bugs.webkit.org/show_bug.cgi?id=186820
3063
3064 Reviewed by Yusuke Suzuki.
3065
3066 * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3067 (TestWebKitAPI::TEST_F):
3068
3069 2018-07-11 Youenn Fablet <youenn@apple.com>
3070
3071 Fix remaining Cross-Origin-Resource-Policy failures, if any
3072 https://bugs.webkit.org/show_bug.cgi?id=186761
3073 <rdar://problem/41209829>
3074
3075 Reviewed by Alex Christensen.
3076
3077 * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
3078 (TestWebKitAPI::TEST):
3079
3080 2018-07-11 Aakash Jain <aakash_jain@apple.com>
3081 ·
3082 [ews-build] EWS should unapply the patch and build ToT when patch fails to build
3083 https://bugs.webkit.org/show_bug.cgi?id=187358
3084 ·
3085 Reviewed by Alexey Proskuryakov.
3086 ·
3087 * BuildSlaveSupport/ews-build/factories.py:
3088 (BuildFactory.__init__):
3089 * BuildSlaveSupport/ews-build/steps.py:
3090 (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g .: un-apply patch, compile ToT).
3091 (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
3092 (CompileWebKitToT): Build ToT without patch.
3093 (CompileWebKitToT.doStepIf): Run this step only if patch failed to build .
3094 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
3095
3096 2018-07-11 Robin Morisset <rmorisset@apple.com>
3097
3098 [WSL] WIP, more of the spec
3099 https://bugs.webkit.org/show_bug.cgi?id=186310
3100
3101 Rubberstamped by Filip Pizlo.
3102
3103 Fixed a few issues with the formal rules (such as adding the restriction s on pointers for compilation to SpirV),
3104 and started writing some of the english in the spec.
3105
3106 * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
3107 * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
3108
3109 2018-07-10 Aakash Jain <aakash_jain@apple.com>
3110
3111 [ews-build] Add build step to UnApply patch
3112 https://bugs.webkit.org/show_bug.cgi?id=187357
3113
3114 Reviewed by Alexey Proskuryakov.
3115
3116 * BuildSlaveSupport/ews-build/steps.py:
3117 (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in ord er to unapply the patch.
3118 (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
3119 properties will be set by build-steps for build and test.
3120 (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
3121
3122 2018-07-10 Dewei Zhu <dewei_zhu@apple.com>
3123
3124 Update ARES-6.patch file accordingly for r233631.
3125 https://bugs.webkit.org/show_bug.cgi?id=187534
3126
3127 Reviewed by Saam Barati.
3128
3129 Update ARES-6.patch file acoordingly after ARES-6 plan file change to
3130 avoid warning while applying the patch.
3131
3132 * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
3133
3134 2018-07-10 Tim Horton <timothy_horton@apple.com>
3135
3136 doAfterNextPresentationUpdate should not be called while content is hidd en due to animated resize
3137 https://bugs.webkit.org/show_bug.cgi?id=187500
3138 <rdar://problem/41294139>
3139
3140 Reviewed by Simon Fraser.
3141
3142 * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3143 (-[AnimatedResizeWebView _endAnimatedResize]):
3144 Set didEndAnimatedResize before calling super, because it makes the
3145 new test easier and doesn't affect any of the existing ones.
3146
3147 (AnimatedResizeBlocksViewportFitChanges):
3148 This doAfterNextPresentationUpdate is always called during animated resi ze,
3149 and then synchronously waited for, so it /must/ use
3150 _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting .
3151 ········
3152 (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
3153 Add a test ensuring that doAfterNextPresentationUpdate is deferred
3154 until endAnimatedResize is called.
3155
3156 * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3157 (-[WKWebView _test_waitForDidFinishNavigation]):
3158 _test_waitForDidFinishNavigation is sometimes called during animated res ize,
3159 and synchronously waits for a doAfterNextPresentationUpdate, so
3160 it cannot wait for the animated resize to complete.
3161
3162 2018-07-10 Fujii Hironori <Hironori.Fujii@sony.com>
3163
3164 [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
3165 https://bugs.webkit.org/show_bug.cgi?id=184441
3166
3167 Reviewed by Michael Catanzaro.
3168
3169 All executables of TestWebKitAPI need the forwarding headers of
3170 WebCore and PAL because config.h includes
3171 <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
3172
3173 The forwarding headers of WebCore are generated by
3174 generate-forwarding-headers.pl in GTK and WPE ports. The
3175 forwarding headers of PAL are generated by
3176 WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
3177
3178 * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
3179 ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
3180 ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
3181 * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3182
3183 2018-07-10 Stephan Szabo <stephan.szabo@sony.com>
3184
3185 [WinCairo] Support display of webinspector ui on non-legacy minibrowser
3186 https://bugs.webkit.org/show_bug.cgi?id=187415
3187
3188 Reviewed by Brian Burg.
3189
3190 * MiniBrowser/win/WebKitBrowserWindow.cpp:
3191 (WebKitBrowserWindow::WebKitBrowserWindow):
3192
3193 2018-07-10 John Wilander <wilander@apple.com>
3194
3195 Resource Load Statistics: Make testRunner.statisticsResetToConsistentSta te() take a completion handler
3196 https://bugs.webkit.org/show_bug.cgi?id=187499
3197 <rdar://problem/41999431>
3198
3199 Reviewed by Chris Dumez.
3200
3201 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3202 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3203 (WTR::InjectedBundle::didReceiveMessageToPage):
3204 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3205 (WTR::TestRunner::statisticsResetToConsistentState):
3206 (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
3207 * WebKitTestRunner/InjectedBundle/TestRunner.h:
3208 * WebKitTestRunner/TestController.cpp:
3209 (WTR::TestController::statisticsResetToConsistentState):
3210 * WebKitTestRunner/TestInvocation.cpp:
3211 (WTR::TestInvocation::didResetStatisticsToConsistentState):
3212 * WebKitTestRunner/TestInvocation.h:
3213
3214 2018-07-10 Ryosuke Niwa <rniwa@webkit.org>
3215
3216 Disable cross-origin-window-policy by default
3217 https://bugs.webkit.org/show_bug.cgi?id=187509
3218
3219 Reviewed by Chris Dumez.
3220
3221 Enable the feature for testing purposes. DumpRenderTree does this alread y in enableExperimentalFeatures.
3222
3223 * WebKitTestRunner/TestController.cpp:
3224 (WTR::TestController::resetPreferencesToConsistentValues):
3225
3226 2018-07-10 Thibault Saunier <tsaunier@igalia.com>
3227
3228 [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
3229 https://bugs.webkit.org/show_bug.cgi?id=187470
3230
3231 Reviewed by Philippe Normand.
3232
3233 Never force building, the user is responsible to make that decision and the workflow is
3234 now based on external scripts so it doesn't make sense anymore. Doing th at leads
3235 to ignoring the options the user passed in.
3236
3237 * flatpak/flatpakutils.py:
3238 (WebkitFlatpak.setup_dev_env):
3239
3240 2018-07-10 Thibault Saunier <tsaunier@igalia.com>
3241
3242 [Flatpak] Fix running wpt tests inside flatpak
3243 https://bugs.webkit.org/show_bug.cgi?id=187490
3244
3245 Reviewed by Philippe Normand.
3246
3247 Still not *all* passing but a big majority do.
3248
3249 * Scripts/webkitpy/w3c/wpt_runner.py:
3250 (main): Generate the /etc/hosts and mount it in flatpak as required.
3251 (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout W PT code before generating /etc/hosts.
3252 (WPTRunner._prepare_wpt_checkout): Deleted.
3253 * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
3254 added a way to pass extra env to flatpak itself (so we can mount /etc/ho sts).
3255 Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
3256 * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as requir ed by wpt.
3257
3258 2018-07-10 Thibault Saunier <tsaunier@igalia.com>
3259
3260 [Flatpak] Use logging to print debug information
3261 https://bugs.webkit.org/show_bug.cgi?id=187496
3262
3263 Reviewed by Philippe Normand.
3264
3265 * flatpak/flatpakutils.py:
3266 (WebkitFlatpak.load_from_args):
3267 (WebkitFlatpak.clean_args):
3268 (WebkitFlatpak.run_in_sandbox):
3269
3270 2018-07-09 Timothy Hatcher <timothy@apple.com>
3271
3272 Semantic colors don't update when accessibility Increase Contrast mode i s enabled.
3273 https://bugs.webkit.org/show_bug.cgi?id=187425
3274 rdar://problem/39948240
3275 rdar://problem/41796865
3276
3277 Reviewed by Tim Horton.
3278
3279 * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
3280 (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color valu e.
3281
3282 2018-07-09 Simon Fraser <simon.fraser@apple.com>
3283
3284 Fix dump-class-layout to show bit padding, and fix issues with padding o ffsets
3285 https://bugs.webkit.org/show_bug.cgi?id=187442
3286
3287 Reviewed by Daniel Bates.
3288 ········
3289 Synthetic padding members were shown with the wrong offset because they used the
3290 absolute offset rather than the class-relative offset. This didn't chang e the padding
3291 math, but made the output confusing.
3292 ········
3293 Also add support for showing empty bits in bitfields, and fix computatio n of padding
3294 after bitfields. Empty bits are computed by inserting a bit padding memb er after
3295 a bitfield that is not followed by another bitfield (making the assumpti on that bit
3296 padding will fill to the next byte boundary).
3297 ········
3298 The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
3299 just reports the size of the type without the bitfield modifier (e.g. fo r "unsigned : 2" it returned 4).
3300 Fix by setting the byte size for bitfield fields to the number of bits r ounded up to the next byte;
3301 this allows byte padding following the bitfield to be computed correctly .
3302 ········
3303 Add or modify test to cover these issues.
3304
3305 * lldb/dump_class_layout_unittest.py:
3306 (serial_test_ClassWithPaddedBitfields):
3307 (serial_test_MemberHasBitfieldPadding):
3308 (serial_test_InheritsFromClassWithPaddedBitfields):
3309 * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3310 (avoidClassDeadStripping):
3311 * lldb/lldb_dump_class_layout.py:
3312 (ClassLayoutBase):
3313 (ClassLayoutBase._to_string_recursive):
3314 (ClassLayout._parse):
3315 (ClassLayout._compute_padding_recursive):
3316
3317 2018-07-09 Youenn Fablet <youenn@apple.com>
3318
3319 StringView operator==(char*) should check the length of the string
3320 https://bugs.webkit.org/show_bug.cgi?id=187422
3321
3322 Reviewed by Chris Dumez.
3323
3324 * TestWebKitAPI/Tests/WTF/StringView.cpp:
3325 (TestWebKitAPI::equal2):
3326 (TestWebKitAPI::TEST):
3327
3328 2018-07-09 Ross Kirsling <rkirsling@gmail.com>
3329
3330 [WinCairo] httpd service install needs to precede server start
3331 https://bugs.webkit.org/show_bug.cgi?id=187283
3332
3333 Reviewed by Daniel Bates.
3334
3335 * Scripts/webkitpy/port/base.py:
3336 (Port.check_build):
3337 Remove unused parameter `needs_http`.
3338 ········
3339 (Port.check_sys_deps):
3340 (Port.start_http_server):
3341 Move `check_httpd` call.
3342
3343 * Scripts/webkitpy/port/win.py:
3344 (WinPort.check_httpd): Added.
3345 (WinCairoPort.check_httpd): Deleted.
3346 Move `httpd -k install` logic to common Windows location.
3347
3348 * Scripts/webkitpy/layout_tests/controllers/manager.py:
3349 (Manager._set_up_run):
3350 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3351 * Scripts/webkitpy/port/gtk.py:
3352 (GtkPort.check_sys_deps):
3353 * Scripts/webkitpy/port/ios_simulator.py:
3354 (IOSSimulatorPort.check_sys_deps):
3355 * Scripts/webkitpy/port/mock_drt.py:
3356 (MockDRTPort.check_build):
3357 (MockDRTPort.check_sys_deps):
3358 * Scripts/webkitpy/port/port_testcase.py:
3359 (PortTestCase.integration_test_check_sys_deps):
3360 (test_check_build):
3361 * Scripts/webkitpy/port/test.py:
3362 * Scripts/webkitpy/port/wpe.py:
3363 (WPEPort.check_sys_deps):
3364 * Scripts/webkitpy/tool/commands/perfalizer.py:
3365 (PerfalizerTask.run):
3366 Remove `needs_http` arguments.
3367
3368 2018-07-09 Philippe Normand <pnormand@igalia.com>
3369
3370 [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
3371 ········
3372 * flatpak/org.webkit.WebKit.yaml:
3373
3374 2018-07-09 Thibault Saunier <tsaunier@igalia.com>
3375
3376 [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
3377 https://bugs.webkit.org/show_bug.cgi?id=187384
3378
3379 Reviewed by Philippe Normand.
3380
3381 And make it usable inside the sandbox even when
3382 perl is launched "tainted" (as the PERL5LIB won't
3383 work otherwise).
3384
3385 * flatpak/flatpakutils.py:
3386 (WebkitFlatpak.run_in_sandbox):
3387 * flatpak/org.webkit.WebKit.yaml:
3388
3389 2018-07-09 Thibault Saunier <tsaunier@igalia.com>
3390
3391 [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
3392 https://bugs.webkit.org/show_bug.cgi?id=187400
3393
3394 Reviewed by Philippe Normand.
3395
3396 This is where it is expected to be when it is a symlink,
3397 without mounting it the websocket python server can't work
3398 inside the sandbox.
3399
3400 * flatpak/flatpakutils.py:
3401 (WebkitFlatpak.run_in_sandbox):
3402
3403 2018-07-08 Filip Pizlo <fpizlo@apple.com>
3404
3405 run-benchmark should run ARES-6 1.0.1
3406 https://bugs.webkit.org/show_bug.cgi?id=187452
3407
3408 Reviewed by Sam Weinig.
3409 ········
3410 We forgot to update this when we released 1.0.1!
3411
3412 * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
3413
3414 2018-07-07 Youenn Fablet <youenn@apple.com>
3415
3416 WPT importer should create dummy HTML files for *.window.js script files
3417 https://bugs.webkit.org/show_bug.cgi?id=187426
3418
3419 Reviewed by Ryosuke Niwa.
3420
3421 Some WPT tests use *.window.js tests, which should be accessed as *.wind ow.html.
3422 Do the same strategy as done for worker.js/any.js files.
3423
3424 * Scripts/webkitpy/w3c/test_importer.py:
3425 (TestImporter.write_html_files_for_templated_js_tests):
3426
3427 2018-07-07 Wenson Hsieh <wenson_hsieh@apple.com>
3428
3429 Introduce a layout milestone to track when the document contains a large number of rendered characters
3430 https://bugs.webkit.org/show_bug.cgi?id=187412
3431 <rdar://problem/41744338>
3432
3433 Reviewed by Ryosuke Niwa.
3434
3435 Add a new API test to check that we observe the new rendering milestone in an article-like document.
3436
3437 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3438 * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added .
3439 * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
3440 (TEST):
3441
3442 2018-06-30 Simon Fraser <simon.fraser@apple.com>
3443
3444 dump-class-layout reports wrong padding in many cases
3445 https://bugs.webkit.org/show_bug.cgi?id=185801
3446
3447 Reviewed by Dan Bates.
3448 ········
3449 Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
3450 the patch from bug 187141.
3451 ········
3452 Move the code that uses lldb to fetch the class layout to its own module ,
3453 lldb_dump_class_layout.py, so it can be unit tested. Change this code
3454 to build up a data structure for the class. This is necessary since corr ect
3455 padding computation is easier with second traversal over the data struct ure.
3456 ········
3457 Try to deal with the empty base class optimization, which is necessary t o report
3458 correct padding in classes using std::unique_ptr, and correctly handle v irtual base classes.
3459 ········
3460 The ClassLayoutBase class knows how to test for equality and generate a string
3461 or string list representation of itself. The derived ClassLayout class k nows
3462 how to build up the class layout using the lldb Python bindings.
3463 ········
3464 Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so th at we don't
3465 have to make a new one for each unit test. The tests have to run seriall y.
3466 ········
3467 Add to lldbWebKitTester a .cpp file that contains a set of C++ classes t o unit-test
3468 dump-class-layout.
3469
3470 * Scripts/dump-class-layout:
3471 (main):
3472 * lldb/dump_class_layout_unittest.py:
3473 (destroy_cached_debug_session):
3474 (TestDumpClassLayout):
3475 (TestDumpClassLayout.setUpClass):
3476 (TestDumpClassLayout.setUp):
3477 (TestDumpClassLayout.serial_test_BasicClassLayout):
3478 (serial_test_PaddingBetweenClassMembers):
3479 (serial_test_BoolPaddingClass):
3480 (serial_test_ClassWithEmptyClassMembers):
3481 (serial_test_SimpleVirtualClass):
3482 (serial_test_SimpleVirtualClassWithNonVirtualBase):
3483 (serial_test_InterleavedVirtualNonVirtual):
3484 (serial_test_ClassWithTwoVirtualBaseClasses):
3485 (serial_test_ClassWithClassMembers):
3486 (serial_test_ClassWithBitfields):
3487 (serial_test_ClassWithUniquePtrs):
3488 (serial_test_ClassWithOptionals):
3489 (TestDumpClassLayout.test_BasicClassLayout): Deleted.
3490 * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
3491 (EmptyClass::doStuff):
3492 (VirtualBaseClass::~VirtualBaseClass):
3493 (VirtualBaseClass2::~VirtualBaseClass2):
3494 (SimpleVirtualClass::~SimpleVirtualClass):
3495 (SimpleVirtualClass::doStuff):
3496 (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtual Base):
3497 (SimpleVirtualClassWithNonVirtualBase::doStuff):
3498 (avoidClassDeadStripping):
3499 * lldb/lldb_dump_class_layout.py:
3500 (ansi_colors):
3501 (ClassLayoutBase):
3502 (ClassLayoutBase.__init__):
3503 (ClassLayoutBase.__ne__):
3504 (ClassLayoutBase.__eq__):
3505 (ClassLayoutBase._to_string_recursive):
3506 (ClassLayoutBase.as_string_list):
3507 (ClassLayoutBase.as_string):
3508 (ClassLayoutBase.dump):
3509 (ClassLayoutExpected):
3510 (ClassLayoutExpected.__init__):
3511 (ClassLayout):
3512 (ClassLayout.__init__):
3513 (ClassLayout._has_polymorphic_base_class):
3514 (ClassLayout._parse):
3515 (ClassLayout._probably_has_empty_base_class_optimization):
3516 (ClassLayout._compute_padding_recursive):
3517 (ClassLayout._compute_padding):
3518 (LLDBDebuggerInstance):
3519 (LLDBDebuggerInstance.__init__):
3520 (LLDBDebuggerInstance.__del__):
3521 (LLDBDebuggerInstance._get_first_file_architecture):
3522 (LLDBDebuggerInstance.layout_for_classname):
3523 (ClassLayoutDumper): Deleted.
3524 (ClassLayoutDumper.__init__): Deleted.
3525 (ClassLayoutDumper._get_first_file_architecture): Deleted.
3526 (ClassLayoutDumper.verify_type): Deleted.
3527 (ClassLayoutDumper.verify_type_recursive): Deleted.
3528 (ClassLayoutDumper._class_layout_as_string): Deleted.
3529 (ClassLayoutDumper.dump_to_string): Deleted.
3530 (ClassLayoutDumper.dump): Deleted.
3531
3532 2018-07-06 Christopher Reid <chris.reid@sony.com>
3533
3534 [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to cer tain URLs
3535 https://bugs.webkit.org/show_bug.cgi?id=187167
3536
3537 Reviewed by Alex Christensen.
3538
3539 A null byte was written past the end of the buffer causing the crash.
3540 Some of the heap allocated buffers were also not getting deleted.
3541
3542 * MiniBrowser/win/WebKitBrowserWindow.cpp:
3543
3544 2018-07-06 Thibault Saunier <tsaunier@igalia.com>
3545
3546 [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
3547 https://bugs.webkit.org/show_bug.cgi?id=187401
3548
3549 Reviewed by Philippe Normand.
3550
3551 * flatpak/org.webkit.WebKit.yaml:
3552
3553 2018-07-06 Aakash Jain <aakash_jain@apple.com>
3554
3555 [ews-build] EWS should run javascriptcore tests
3556 https://bugs.webkit.org/show_bug.cgi?id=187365
3557
3558 Reviewed by David Kilzer.
3559
3560 * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCore Tests.
3561 * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3562 * BuildSlaveSupport/ews-build/factories.py:
3563
3564 2018-07-06 Carlos Garcia Campos <cgarcia@igalia.com>
3565
3566 [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/sc ript-message-received fails
3567 https://bugs.webkit.org/show_bug.cgi?id=187383
3568
3569 Reviewed by Žan Doberšek.
3570
3571 This is actually a problem in the test itself. The problem is that we ru n js, connect to message-received and
3572 quite the main loop when the message is received, which happens before t he run js operation has been
3573 completed. The test finishes early and since r233111 an IPC message is s till pending (I guess the run js
3574 callback) and the web page is still protected. Just adding a run loop op eration before finishing the test would
3575 fix it. We should wait for the js run to complete, instead of the messag e.
3576
3577 * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3578 (UserScriptMessageTest::scriptMessageReceived):
3579 (UserScriptMessageTest::waitUntilMessageReceived):
3580 (UserScriptMessageTest::runJavaScriptFinished):
3581 (UserScriptMessageTest::postMessageAndWaitUntilReceived):
3582
3583 2018-07-05 Youenn Fablet <youenn@apple.com>
3584
3585 REGRESSION (r230843): Flash doesn't work; Produces blue box on page
3586 https://bugs.webkit.org/show_bug.cgi?id=187346
3587 <rdar://problem/41773974>
3588
3589 Reviewed by Ryosuke Niwa.
3590
3591 * WebKitTestRunner/TestController.cpp:
3592 (WTR::TestController::resetStateToConsistentValues):
3593 (WTR::TestController::setBlockAllPlugins):
3594 When not blocked, set the load policy to allow once.
3595 * WebKitTestRunner/TestController.h:
3596
3597 2018-07-05 Aakash Jain <aakash_jain@apple.com>
3598
3599 [ews-build] Bindings-tests-EWS should output result in json
3600 https://bugs.webkit.org/show_bug.cgi?id=187330
3601
3602 Reviewed by David Kilzer.
3603
3604 * BuildSlaveSupport/ews-build/steps.py:
3605 (RunBindingsTests): Passed --json-output parameter to run-bindings-test s.
3606 * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3607
3608 2018-07-05 Aakash Jain <aakash_jain@apple.com>
3609
3610 [ews-build] WebKitPy-Tests-EWS should output result in json
3611 https://bugs.webkit.org/show_bug.cgi?id=187331
3612
3613 Follow-up fix to r233527. Extracting jsonFileName as a variable and re-u sing it.
3614
3615 2018-07-05 Aakash Jain <aakash_jain@apple.com>
3616
3617 [ews-build] WebKitPy-Tests-EWS should output result in json
3618 https://bugs.webkit.org/show_bug.cgi?id=187331
3619
3620 Reviewed by David Kilzer.
3621
3622 * BuildSlaveSupport/ews-build/steps.py:
3623 (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
3624 * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3625
3626 2018-07-05 Philippe Normand <pnormand@igalia.com>
3627
3628 [Flatpak] Add gst-libav to dependencies
3629 https://bugs.webkit.org/show_bug.cgi?id=187340
3630
3631 Reviewed by Žan Doberšek.
3632
3633 * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
3634 clones because the FFMPeg git server doesn't support shallow
3635 clones.
3636
3637 2018-07-05 Thibault Saunier <tsaunier@igalia.com>
3638
3639 [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFacto ry expects
3640 https://bugs.webkit.org/show_bug.cgi?id=187322
3641
3642 Reviewed by Žan Doberšek.
3643
3644 * flatpak/flatpakutils.py:
3645 (WebkitFlatpak.__init__):
3646
3647 2018-07-05 Zan Dobersek <zdobersek@igalia.com>
3648
3649 Unreviewed, rolling out r233511.
3650
3651 Proper fix provided in bug #187322
3652
3653 Reverted changeset:
3654
3655 "Unreviewed. Fixing a call in flatpakutils.py to
3656 PortFactory.get(),"
3657 https://trac.webkit.org/changeset/233511
3658
3659 2018-07-04 Zan Dobersek <zdobersek@igalia.com>
3660
3661 Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
3662 enforcing the passed platform argument to always be lowercase, as is
3663 expected from the PortFactory code.
3664
3665 * flatpak/flatpakutils.py:
3666 (WebkitFlatpak.clean_args):
12 3667
13 2018-07-04 Tim Horton <timothy_horton@apple.com> 3668 2018-07-04 Tim Horton <timothy_horton@apple.com>
14 3669
15 Introduce PLATFORM(IOSMAC) 3670 Introduce PLATFORM(IOSMAC)
16 https://bugs.webkit.org/show_bug.cgi?id=187315 3671 https://bugs.webkit.org/show_bug.cgi?id=187315
17 3672
18 Reviewed by Dan Bernstein. 3673 Reviewed by Dan Bernstein.
19 3674
20 * TestWebKitAPI/Configurations/Base.xcconfig: 3675 * TestWebKitAPI/Configurations/Base.xcconfig:
21 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: 3676 * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
(...skipping 17537 matching lines...) Expand 10 before | Expand all | Expand 10 after
17559 Test two forms of storage to be sure we are using a different WebsiteDat aStore: cookies and sessionStorage. 21214 Test two forms of storage to be sure we are using a different WebsiteDat aStore: cookies and sessionStorage.
17560 21215
17561 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: 21216 * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
17562 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]): 21217 (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavig ationAction:decisionHandler:]):
17563 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]) : 21218 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]) :
17564 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan elWithMessage:initiatedByFrame:completionHandler:]): 21219 (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPan elWithMessage:initiatedByFrame:completionHandler:]):
17565 (websiteDataStoreTestWebView): 21220 (websiteDataStoreTestWebView):
17566 (TEST): 21221 (TEST):
17567 21222
17568 == Rolled over to ChangeLog-2018-01-01 == 21223 == Rolled over to ChangeLog-2018-01-01 ==
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b