Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 339330043: [plaso] Remove inconsistent return values from Plaso module #1748 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by onager
Modified:
6 years, 1 month ago
Reviewers:
romaing
CC:
Joachim Metz, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Remove inconsistent return values from Plaso module #1748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -112 lines) Patch
M .pylintrc View 1 chunk +1 line, -0 lines 0 comments Download
M plaso/analysis/browser_search.py View 7 chunks +18 lines, -16 lines 0 comments Download
M plaso/analysis/chrome_extension.py View 3 chunks +3 lines, -3 lines 0 comments Download
M plaso/cli/pinfo_tool.py View 4 chunks +4 lines, -4 lines 0 comments Download
M plaso/cli/status_view.py View 2 chunks +4 lines, -0 lines 0 comments Download
M plaso/cli/storage_media_tool.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/cli/time_slices.py View 1 chunk +4 lines, -0 lines 0 comments Download
M plaso/dependencies.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/engine/knowledge_base.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/engine/path_helper.py View 3 chunks +3 lines, -3 lines 0 comments Download
M plaso/engine/process_info.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/filters/file_entry.py View 5 chunks +5 lines, -5 lines 0 comments Download
M plaso/filters/filter_list.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/filters/interface.py View 2 chunks +3 lines, -1 line 0 comments Download
M plaso/filters/manager.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/filters/path_filter.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/formatters/mediator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/formatters/winevt_rc.py View 8 chunks +10 lines, -10 lines 0 comments Download
M plaso/lib/bufferlib.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/lib/lexer.py View 3 chunks +3 lines, -1 line 0 comments Download
M plaso/lib/objectfilter.py View 2 chunks +3 lines, -0 lines 0 comments Download
M plaso/lib/pfilter.py View 2 chunks +4 lines, -0 lines 0 comments Download
M plaso/lib/plist.py View 1 chunk +3 lines, -3 lines 0 comments Download
M plaso/multi_processing/plaso_xmlrpc.py View 2 chunks +3 lines, -3 lines 0 comments Download
M plaso/multi_processing/psort.py View 2 chunks +4 lines, -3 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 2 chunks +3 lines, -3 lines 0 comments Download
M plaso/multi_processing/task_manager.py View 5 chunks +7 lines, -4 lines 0 comments Download
M plaso/output/l2t_csv.py View 2 chunks +3 lines, -2 lines 0 comments Download
M plaso/output/manager.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/output/mediator.py View 3 chunks +3 lines, -3 lines 0 comments Download
M plaso/output/shared_4n6time.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/bsm.py View 5 chunks +6 lines, -4 lines 0 comments Download
M plaso/parsers/esedb_plugins/interface.py View 5 chunks +9 lines, -1 line 0 comments Download
M plaso/parsers/esedb_plugins/srum.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/parsers/interface.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/parsers/mac_keychain.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/mactime.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/manager.py View 2 chunks +3 lines, -0 lines 0 comments Download
M plaso/parsers/mediator.py View 7 chunks +7 lines, -7 lines 0 comments Download
M plaso/parsers/pe.py View 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/parsers/recycler.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/parsers/shared/shell_items.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/sqlite.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome.py View 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/parsers/winreg_plugins/appcompatcache.py View 2 chunks +4 lines, -2 lines 0 comments Download
M plaso/parsers/winreg_plugins/services.py View 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/parsers/zsh_extended_history.py View 1 chunk +1 line, -0 lines 0 comments Download
M plaso/preprocessors/manager.py View 3 chunks +5 lines, -5 lines 0 comments Download
M plaso/serializer/json_serializer.py View 2 chunks +4 lines, -0 lines 0 comments Download
M plaso/storage/event_tag_index.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/storage/factory.py View 5 chunks +10 lines, -0 lines 0 comments Download
M plaso/storage/fake/writer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/storage/identifiers.py View 3 chunks +8 lines, -2 lines 0 comments Download
M plaso/storage/interface.py View 4 chunks +5 lines, -3 lines 0 comments Download
M plaso/storage/sqlite/sqlite_file.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
onager
6 years, 1 month ago (2018-03-12 11:52:59 UTC) #1
romaing
On 2018/03/12 11:52:59, onager wrote: LGTM
6 years, 1 month ago (2018-03-13 13:05:48 UTC) #2
onager
6 years, 1 month ago (2018-03-21 10:58:03 UTC) #3 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close fix_inconsistent_returns
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b