Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2336)

Unified Diff: plaso/lib/pfilter.py

Issue 339330043: [plaso] Remove inconsistent return values from Plaso module #1748 (Closed)
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « plaso/lib/objectfilter.py ('k') | plaso/lib/plist.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plaso/lib/pfilter.py
diff --git a/plaso/lib/pfilter.py b/plaso/lib/pfilter.py
index 502ebd52c650a7a949dccc3f99c1023d2c628000..c1498404ff7b9bd925a5bec310f4bd54656895d7 100644
--- a/plaso/lib/pfilter.py
+++ b/plaso/lib/pfilter.py
@@ -79,6 +79,8 @@ class DictObject(object):
if test in self._dict_translated:
return self._dict_translated.get(test)
+ return None
+
class PlasoValueExpander(objectfilter.AttributeValueExpander):
"""An expander that gives values based on object attribute names."""
@@ -146,6 +148,8 @@ class PlasoValueExpander(objectfilter.AttributeValueExpander):
_, source_long = self._GetSources(obj)
return source_long
+ return None
+
def _GetAttributeName(self, path):
return path[0].lower()
« no previous file with comments | « plaso/lib/objectfilter.py ('k') | plaso/lib/plist.py » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b