Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(677)

Unified Diff: plaso/multi_processing/task_engine.py

Issue 339330043: [plaso] Remove inconsistent return values from Plaso module #1748 (Closed)
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « plaso/multi_processing/psort.py ('k') | plaso/multi_processing/task_manager.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plaso/multi_processing/task_engine.py
diff --git a/plaso/multi_processing/task_engine.py b/plaso/multi_processing/task_engine.py
index 54af03ff907692ffd615512e1c14d6251d3579f2..5f94172492298734be4809719850e8fe767b1a1c 100644
--- a/plaso/multi_processing/task_engine.py
+++ b/plaso/multi_processing/task_engine.py
@@ -45,13 +45,13 @@ class _EventSourceHeap(object):
"""Pops an event source from the heap.
Returns:
- EventSource: event source.
+ EventSource: event source or None on error.
"""
try:
_, event_source = heapq.heappop(self._heap)
except IndexError:
- return
+ return None
return event_source
@@ -504,7 +504,7 @@ class TaskMultiProcessEngine(engine.MultiProcessEngine):
process_name, pid, exception))
self._TerminateProcess(process)
- return
+ return None
self._RegisterProcess(process)
« no previous file with comments | « plaso/multi_processing/psort.py ('k') | plaso/multi_processing/task_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b