Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(811)

Unified Diff: plaso/multi_processing/plaso_xmlrpc.py

Issue 339330043: [plaso] Remove inconsistent return values from Plaso module #1748 (Closed)
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « plaso/lib/plist.py ('k') | plaso/multi_processing/psort.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plaso/multi_processing/plaso_xmlrpc.py
diff --git a/plaso/multi_processing/plaso_xmlrpc.py b/plaso/multi_processing/plaso_xmlrpc.py
index 6c5be245b4fed22b1beb23c994a9120d0b1e9adb..caa7c5be72ca1c81d93768d7edba468b88ab1745 100644
--- a/plaso/multi_processing/plaso_xmlrpc.py
+++ b/plaso/multi_processing/plaso_xmlrpc.py
@@ -36,11 +36,11 @@ class XMLRPCClient(rpc.RPCClient):
def CallFunction(self):
"""Calls the function via RPC."""
if self._xmlrpc_proxy is None:
- return
+ return None
rpc_call = getattr(self._xmlrpc_proxy, self._RPC_FUNCTION_NAME, None)
if rpc_call is None:
- return
+ return None
try:
return rpc_call()
@@ -48,7 +48,7 @@ class XMLRPCClient(rpc.RPCClient):
expat.ExpatError, SocketServer.socket.error,
xmlrpclib.Fault) as exception:
logging.warning('Error while making RPC call: {0:s}'.format(exception))
- return
+ return None
def Close(self):
"""Closes the RPC communication channel to the server."""
« no previous file with comments | « plaso/lib/plist.py ('k') | plaso/multi_processing/psort.py » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b