Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 86100043: Make the GUI server redirect to the default icon.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by frankban
Modified:
8 years, 4 months ago
Reviewers:
bac, mp+214985
Visibility:
Public.

Description

Make the GUI server redirect to the default icon. Create a specialized proxy handler for handling Juju HTTP API requests. In this subclass, handle the case a request is for a local charm icon that cannot be found on the Juju server. Tests: `make unittest`. QA: - `juju bootstrap`; - from the branch root, run `make deploy`; - wait for the GUI service to be ready; - switch to the trunk branch: `juju set juju-gui juju-gui-source=develop` - wait for the GUI to be ready; - deploy local charms including an icon: you should see the icons are correctly displayed in the service blocks and inspector header; - deploy a local charm not including an icon: you should see the fallback icon displayed both in the service block and the inspector; - destroy the environment, done. https://code.launchpad.net/~frankban/charms/precise/juju-gui/support-default-charm-icon/+merge/214985 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Make the GUI server redirect to the default icon. #

Patch Set 3 : Make the GUI server redirect to the default icon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -21 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/apps.py View 1 chunk +6 lines, -2 lines 0 comments Download
M server/guiserver/handlers.py View 1 6 chunks +78 lines, -15 lines 0 comments Download
M server/guiserver/tests/test_handlers.py View 5 chunks +60 lines, -2 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
8 years, 4 months ago (2014-04-09 16:02:49 UTC) #1
bac
Code LGTM https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py File server/guiserver/handlers.py (right): https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode255 server/guiserver/handlers.py:255: # Handle POST requests the same way ...
8 years, 4 months ago (2014-04-09 16:32:41 UTC) #2
frankban
Please take a look. https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py File server/guiserver/handlers.py (right): https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode255 server/guiserver/handlers.py:255: # Handle POST requests the ...
8 years, 4 months ago (2014-04-09 16:49:06 UTC) #3
bac
QA OK too
8 years, 4 months ago (2014-04-09 17:13:42 UTC) #4
frankban
*** Submitted: Make the GUI server redirect to the default icon. Create a specialized proxy ...
8 years, 4 months ago (2014-04-09 18:04:33 UTC) #5
frankban
8 years, 4 months ago (2014-04-09 18:05:50 UTC) #6
Thank you Brad.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b