DescriptionMake the GUI server redirect to the default icon.
Create a specialized proxy handler for handling
Juju HTTP API requests. In this subclass, handle
the case a request is for a local charm icon
that cannot be found on the Juju server.
Tests: `make unittest`.
QA:
- `juju bootstrap`;
- from the branch root, run `make deploy`;
- wait for the GUI service to be ready;
- switch to the trunk branch:
`juju set juju-gui juju-gui-source=develop`
- wait for the GUI to be ready;
- deploy local charms including an icon:
you should see the icons are correctly displayed in the
service blocks and inspector header;
- deploy a local charm not including an icon:
you should see the fallback icon displayed both in
the service block and the inspector;
- destroy the environment, done.
https://code.launchpad.net/~frankban/charms/precise/juju-gui/support-default-charm-icon/+merge/214985
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 4
Patch Set 2 : Make the GUI server redirect to the default icon. #Patch Set 3 : Make the GUI server redirect to the default icon. #
MessagesTotal messages: 6
|