Code review - Issue 86100043: Make the GUI server redirect to the default icon.https://codereview.appspot.com/2014-04-09T18:05:50+00:00rietveld
Message from unknown
2014-04-09T16:02:44+00:00frankbanurn:md5:9393b270558e0fbddba8e9f246d8d0ff
Message from francesco.banconi@canonical.com
2014-04-09T16:02:49+00:00frankbanurn:md5:dfe192365703f78009de452c5eee192d
Please take a look.
Message from bac@canonical.com
2014-04-09T16:32:41+00:00bacurn:md5:4f6c53391d176cb4ec78fa8ee7404b01
Code LGTM
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py
File server/guiserver/handlers.py (right):
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode255
server/guiserver/handlers.py:255: # Handle POST requests the same way GET ones are handled.
s/ones/requests/ -- just reads better.
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode320
server/guiserver/handlers.py:320: Override to handle the case a when a charm icon is not found.
s/a when/when/ or /for when/?
Message from unknown
2014-04-09T16:49:04+00:00frankbanurn:md5:a7c9fa2aa8742a72a53a77ef05b16135
Message from francesco.banconi@canonical.com
2014-04-09T16:49:06+00:00frankbanurn:md5:dd88f3fcc5f6549021c864d05a3e4416
Please take a look.
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py
File server/guiserver/handlers.py (right):
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode255
server/guiserver/handlers.py:255: # Handle POST requests the same way GET ones are handled.
On 2014/04/09 16:32:42, bac wrote:
> s/ones/requests/ -- just reads better.
Done.
https://codereview.appspot.com/86100043/diff/1/server/guiserver/handlers.py#newcode320
server/guiserver/handlers.py:320: Override to handle the case a when a charm icon is not found.
On 2014/04/09 16:32:42, bac wrote:
> s/a when/when/ or /for when/?
Done.
Message from bac@canonical.com
2014-04-09T17:13:42+00:00bacurn:md5:9a2d581cb4fd84900453baea84ddfe5f
QA OK too
Message from unknown
2014-04-09T18:01:33+00:00frankbanurn:md5:822c5184f071603ac0fd2fe63da96a2f
Message from francesco.banconi@canonical.com
2014-04-09T18:04:33+00:00frankbanurn:md5:52040da2baec5fd8b9e2be5b4bb201d5
*** Submitted:
Make the GUI server redirect to the default icon.
Create a specialized proxy handler for handling
Juju HTTP API requests. In this subclass, handle
the case a request is for a local charm icon
that cannot be found on the Juju server.
Tests: `make unittest`.
QA:
- `juju bootstrap`;
- from the branch root, run `make deploy`;
- wait for the GUI service to be ready;
- switch to the trunk branch:
`juju set juju-gui juju-gui-source=develop`
- wait for the GUI to be ready;
- deploy local charms including an icon:
you should see the icons are correctly displayed in the
service blocks and inspector header;
- deploy a local charm not including an icon:
you should see the fallback icon displayed both in
the service block and the inspector;
- destroy the environment, done.
R=bac
CC=
https://codereview.appspot.com/86100043
Message from francesco.banconi@canonical.com
2014-04-09T18:05:50+00:00frankbanurn:md5:6a5acb9548e8b73c1f24eb5f86b6961c
Thank you Brad.