code review 83880043: net: drop unnecessary indirection from PacketConn tests

net: drop unnecessary indirection from PacketConn tests

[mikio, 2014-04-03 08:39:59]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-03 23:14:51]

This indirection was introduced in https://codereview.appspot.com/7778043 to
avoid crashing the test program on Windows.  Is that no longer necessary?

[mikio, 2014-04-03 23:36:15]

On 2014/04/03 23:14:51, iant wrote:
> This indirection was introduced in https://codereview.appspot.com/7778043 to
> avoid crashing the test program on Windows.  Is that no longer necessary?

Yup, the root cause of the crash was... not using ioutil.TempFile appropriately
and was fixed in CL 83390043.

--- a/src/pkg/net/protoconn_test.go
+++ b/src/pkg/net/protoconn_test.go
@@ -19,7 +19,7 @@
 // also uses /tmp directory in case it is prohibited to create UNIX
 // sockets in TMPDIR.
 func testUnixAddr() string {
-	f, err := ioutil.TempFile("/tmp", "nettest")
+	f, err := ioutil.TempFile("", "nettest")

[iant, 2014-04-04 00:01:38]

How about connTests in conn_test.go?

In fact maybe just exactly reverse https://codereview.appspot.com/7778043.

[mikio, 2014-04-04 00:05:21]

On Fri, Apr 4, 2014 at 9:01 AM,  <iant@golang.org> wrote:

> How about connTests in conn_test.go?

https://codereview.appspot.com/83390043 ?

[iant, 2014-04-04 01:57:35]

LGTM

Sorry about that.

[mikio, 2014-04-04 02:46:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=4f9de7749827 ***

net: drop unnecessary indirection from PacketConn tests

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/83880043

[gobot, 2014-04-04 02:54:10]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/304e580ce81dfcde29f1f81f410ad19e180eca58