Issue 83390043: code review 83390043: net: enable unixpacket test on available platforms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83390043: code review 83390043: net: enable unixpacket test on available platforms (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by mikio

Modified:
11 years, 2 months ago

Reviewers:
dave

CC:
golang-codereviews, dave_cheney.net

Visibility:
Public.

Description

net: enable unixpacket test on available platforms DragonFlyBSD, FreeBSD 9 and beyond, NetBSD 6 and beyond, and Solaris (illumos) support AF_UNIX+SOCK_SEQPACKET socket.

Patch Set 1 : diff -r dbf809235908 https://code.google.com/p/go #

Total comments: 2

Patch Set 2 : diff -r d78036c3351f https://code.google.com/p/go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -53 lines)			Patch
M	src/pkg/net/conn_test.go	View		3 chunks	+13 lines, -10 lines	0 comments	Download
M	src/pkg/net/protoconn_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/server_test.go	View	1	8 chunks	+42 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 2 months ago (2014-04-02 03:25:42 UTC) #1

dave_cheney.net

LGTM. Thank you, please wait for a second opinion before commiting. https://codereview.appspot.com/83390043/diff/60001/src/pkg/net/server_test.go File src/pkg/net/server_test.go (right): ...

11 years, 2 months ago (2014-04-02 08:20:02 UTC) #2

mikio

11 years, 2 months ago (2014-04-02 10:43:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=23cb4547ef55 ***

net: enable unixpacket test on available platforms

DragonFlyBSD, FreeBSD 9 and beyond, NetBSD 6 and beyond, and
Solaris (illumos) support AF_UNIX+SOCK_SEQPACKET socket.

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/83390043

https://codereview.appspot.com/83390043/diff/60001/src/pkg/net/server_test.go
File src/pkg/net/server_test.go (right):

https://codereview.appspot.com/83390043/diff/60001/src/pkg/net/server_test.go...
src/pkg/net/server_test.go:140: {net: "unixpacket", saddr: "@gotest4/net",
caddr: "@gotest4/net.local", linux: true},
On 2014/04/02 08:20:03, dfc wrote:
> this field has a strange name, especially when linux is always true. 
> 
> Maybe the field should be called 
> 
>     linuxOnly bool // only run this test on linux platforms.

Done.

Expand All Messages | Collapse All Messages