Issue 7778043: code review 7778043: net: fix windows and plan9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7778043: code review 7778043: net: fix windows and plan9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, brainman

Visibility:
Public.

Description

net: fix windows and plan9 build Don't call unix-only function in test init.

Patch Set 2 : diff -r f3ca7d5b1b0b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f3ca7d5b1b0b https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r dfbaf2b999a6 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
	M	src/pkg/net/conn_test.go	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
	M	src/pkg/net/packetconn_test.go	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2013-03-13 00:58:42 UTC) #1

brainman

https://codereview.appspot.com/7778043/diff/3/src/pkg/net/conn_test.go File src/pkg/net/conn_test.go (right): https://codereview.appspot.com/7778043/diff/3/src/pkg/net/conn_test.go#newcode44 src/pkg/net/conn_test.go:44: addr := tt.addr() I think testUnixAddr will always panic ...

12 years, 2 months ago (2013-03-13 02:28:32 UTC) #2

bradfitz

12 years, 2 months ago (2013-03-13 04:36:29 UTC) #3

bradfitz

12 years, 2 months ago (2013-03-13 14:42:59 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=732bbe584d15 ***

net: fix windows and plan9 build

Don't call unix-only function in test init.

R=golang-dev, alex.brainman
CC=golang-dev
https://codereview.appspot.com/7778043

Expand All Messages | Collapse All Messages