Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(879)

Issue 7324051: code review 7324051: database/sql: add currently-disabled broken test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by bradfitz
Modified:
7 years, 11 months ago
Reviewers:
CC:
golang-dev, brainman, ioe
Visibility:
Public.

Description

database/sql: add currently-disabled broken test Update issue 3865

Patch Set 1 #

Patch Set 2 : diff -r da26671f086a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r da26671f086a https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r da26671f086a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r aceba1ebb946 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/pkg/database/sql/sql_test.go View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bradfitz
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 11 months ago (2013-02-13 19:05:04 UTC) #1
ioe
https://code.google.com/p/go/issues/detail?id=3865 instead of https://code.google.com/p/go/issues/detail?id=386 https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go File src/pkg/database/sql/sql_test.go (right): https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go#newcode452 src/pkg/database/sql/sql_test.go:452: t.Skip("known broken test; golang.org/issue/386") t.Skip("known ...
7 years, 11 months ago (2013-02-13 19:38:28 UTC) #2
bradfitz
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, nightlyone@googlemail.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 11 months ago (2013-02-13 19:55:09 UTC) #3
bradfitz
whoops, thanks. On Wed, Feb 13, 2013 at 11:38 AM, <nightlyone@googlemail.com> wrote: > https://code.google.com/p/go/**issues/detail?id=3865<https://code.google.com/p/go/issues/detail?id=3865> > ...
7 years, 11 months ago (2013-02-13 19:55:14 UTC) #4
ioe
LGTM On 2013/02/13 19:55:14, bradfitz wrote: > whoops, thanks. > > On Wed, Feb 13, ...
7 years, 11 months ago (2013-02-13 19:57:41 UTC) #5
bradfitz
7 years, 11 months ago (2013-02-13 20:04:39 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=a535c198d1cc ***

database/sql: add currently-disabled broken test

Update issue 3865

R=golang-dev, alex.brainman, nightlyone
CC=golang-dev
https://codereview.appspot.com/7324051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b