Code review - Issue 7324051: code review 7324051: database/sql: add currently-disabled broken testhttps://codereview.appspot.com/2013-02-13T20:04:39+00:00rietveld
Message from unknown
2013-02-13T19:04:18+00:00bradfitzurn:md5:260cb31ffd001d80b8b415294ed03955
Message from unknown
2013-02-13T19:04:22+00:00bradfitzurn:md5:84a621fb2fe9f9e69dd04e00bc3cfb16
Message from unknown
2013-02-13T19:05:00+00:00bradfitzurn:md5:4ee43fa4e92ce3bee0657dd911a6db9b
Message from bradfitz@golang.org
2013-02-13T19:05:04+00:00bradfitzurn:md5:8025b74c256042bdad6a98824b3ea279
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from nightlyone@googlemail.com
2013-02-13T19:38:28+00:00ioeurn:md5:c59a7890f8ddee709d5e73dcff4edacf
https://code.google.com/p/go/issues/detail?id=3865
instead of https://code.google.com/p/go/issues/detail?id=386
https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go
File src/pkg/database/sql/sql_test.go (right):
https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go#newcode452
src/pkg/database/sql/sql_test.go:452: t.Skip("known broken test; golang.org/issue/386")
t.Skip("known broken test; golang.org/issue/3865")
A digit (5) is missing.
Message from unknown
2013-02-13T19:55:06+00:00bradfitzurn:md5:79d4a652fcb72a23ca9c4445603f1ec8
Message from bradfitz@golang.org
2013-02-13T19:55:09+00:00bradfitzurn:md5:e907bc3cfc87728c5cc9c22459917c7a
Hello golang-dev@googlegroups.com, alex.brainman@gmail.com, nightlyone@googlemail.com (cc: golang-dev@googlegroups.com),
Please take another look.
Message from bradfitz@golang.org
2013-02-13T19:55:14+00:00bradfitzurn:md5:7928b715ec138e09534bcd7b2f9d0311
whoops, thanks.
On Wed, Feb 13, 2013 at 11:38 AM, <nightlyone@googlemail.com> wrote:
> https://code.google.com/p/go/**issues/detail?id=3865<https://code.google.com/p/go/issues/detail?id=3865>
> instead of https://code.google.com/p/go/**issues/detail?id=386<https://code.google.com/p/go/issues/detail?id=386>
>
>
> https://codereview.appspot.**com/7324051/diff/5001/src/pkg/**
> database/sql/sql_test.go<https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go>
> File src/pkg/database/sql/sql_test.**go (right):
>
> https://codereview.appspot.**com/7324051/diff/5001/src/pkg/**
> database/sql/sql_test.go#**newcode452<https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go#newcode452>
> src/pkg/database/sql/sql_test.**go:452: t.Skip("known broken test;
> golang.org/issue/386")
> t.Skip("known broken test; golang.org/issue/3865")
>
> A digit (5) is missing.
>
> https://codereview.appspot.**com/7324051/<https://codereview.appspot.com/7324051/>
>
Message from nightlyone@googlemail.com
2013-02-13T19:57:41+00:00ioeurn:md5:07846c62466601ea1eebd16d9e020a29
LGTM
On 2013/02/13 19:55:14, bradfitz wrote:
> whoops, thanks.
>
> On Wed, Feb 13, 2013 at 11:38 AM, <mailto:nightlyone@googlemail.com> wrote:
>
> >
> https://code.google.com/p/go/**issues/detail?id=3865%3Chttps://code.google.com/p/go/issues/detail?id=3865>
> > instead of
> https://code.google.com/p/go/**issues/detail?id=386%3Chttps://code.google.com/p/go/issues/detail?id=386>
> >
> >
> > https://codereview.appspot.**com/7324051/diff/5001/src/pkg/**
> >
> database/sql/sql_test.go<https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go>
> > File src/pkg/database/sql/sql_test.**go (right):
> >
> > https://codereview.appspot.**com/7324051/diff/5001/src/pkg/**
> >
> database/sql/sql_test.go#**newcode452<https://codereview.appspot.com/7324051/diff/5001/src/pkg/database/sql/sql_test.go#newcode452>
> > src/pkg/database/sql/sql_test.**go:452: t.Skip("known broken test;
> > golang.org/issue/386")
> > t.Skip("known broken test; golang.org/issue/3865")
> >
> > A digit (5) is missing.
> >
> >
> https://codereview.appspot.**com/7324051/%3Chttps://codereview.appspot.com/7324051/>
> >
Message from unknown
2013-02-13T19:59:59+00:00bradfitzurn:md5:d67d3d19b77d6684e47c95d990c21390
Message from bradfitz@golang.org
2013-02-13T20:04:39+00:00bradfitzurn:md5:90fa59b2f09659645d0ca5d8cc896767
*** Submitted as https://code.google.com/p/go/source/detail?r=a535c198d1cc ***
database/sql: add currently-disabled broken test
Update issue 3865
R=golang-dev, alex.brainman, nightlyone
CC=golang-dev
https://codereview.appspot.com/7324051