Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Delta Between Two Patch Sets: src/pkg/database/sql/sql_test.go

Issue 7324051: code review 7324051: database/sql: add currently-disabled broken test (Closed)
Left Patch Set: diff -r da26671f086a https://go.googlecode.com/hg/ Created 11 years, 1 month ago
Right Patch Set: diff -r aceba1ebb946 https://go.googlecode.com/hg/ Created 11 years, 1 month ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // Copyright 2011 The Go Authors. All rights reserved. 1 // Copyright 2011 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style 2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file. 3 // license that can be found in the LICENSE file.
4 4
5 package sql 5 package sql
6 6
7 import ( 7 import (
8 "database/sql/driver" 8 "database/sql/driver"
9 "fmt" 9 "fmt"
10 "reflect" 10 "reflect"
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 closeDB(t, db) 442 closeDB(t, db)
443 for i := 0; i < 2; i++ { 443 for i := 0; i < 2; i++ {
444 _, err := db.Query("SELECT|people|age,name|") 444 _, err := db.Query("SELECT|people|age,name|")
445 if err == nil { 445 if err == nil {
446 t.Fatalf("expected error") 446 t.Fatalf("expected error")
447 } 447 }
448 } 448 }
449 } 449 }
450 450
451 func TestCloseStmtBeforeRows(t *testing.T) { 451 func TestCloseStmtBeforeRows(t *testing.T) {
452 » t.Skip("known broken test; golang.org/issue/386") 452 » t.Skip("known broken test; golang.org/issue/3865")
ioe 2013/02/13 19:38:28 t.Skip("known broken test; golang.org/issue/3865")
453 return 453 return
454 454
455 db := newTestDB(t, "people") 455 db := newTestDB(t, "people")
456 defer closeDB(t, db) 456 defer closeDB(t, db)
457 457
458 s, err := db.Prepare("SELECT|people|name|") 458 s, err := db.Prepare("SELECT|people|name|")
459 if err != nil { 459 if err != nil {
460 t.Fatal(err) 460 t.Fatal(err)
461 } 461 }
462 462
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 if !reflect.DeepEqual(bindValDeref, spec.rows[i].scanNullVal) { 664 if !reflect.DeepEqual(bindValDeref, spec.rows[i].scanNullVal) {
665 t.Errorf("id=%d got %#v, want %#v", id, bindValDeref, sp ec.rows[i].scanNullVal) 665 t.Errorf("id=%d got %#v, want %#v", id, bindValDeref, sp ec.rows[i].scanNullVal)
666 } 666 }
667 } 667 }
668 } 668 }
669 669
670 func stack() string { 670 func stack() string {
671 buf := make([]byte, 1024) 671 buf := make([]byte, 1024)
672 return string(buf[:runtime.Stack(buf, false)]) 672 return string(buf[:runtime.Stack(buf, false)])
673 } 673 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b