Issue 6868046: code review 6868046: cmd/dist: support building on debian/kFreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6868046: code review 6868046: cmd/dist: support building on debian/kFreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dave

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

cmd/dist: support building on debian/kFreeBSD The debian/kFreeBSD project uses the FreeBSD kernel and the debian userspace. From our point of view, this is freebsd not linux as GOOS talks about the kernel syscall interface, not the userspace (although cgo alters that). As debian/kFreeBSD is experimental at this time, I do not think it is worth the effort of duplicating all the freebsd specific code so this is proposal represents a reasonable workaround. Currently cgo is not supported, make.bash will detect this and disable cgo automatically during the build. dfc@debian:~/go/src$ uname -a GNU/kFreeBSD debian 8.1-1-686 #0 Sat Jul 21 17:02:04 UTC 2012 i686 i386 Intel(R) Core(TM) i5-2415M CPU @ 2.30GHz GNU/kFreeBSD dfc@debian:~/go/src$ ../bin/go version go version devel +d05272f402ec Sat Dec 01 15:15:14 2012 -0800 Tested with GOOS=freebsd GOARCH=386

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	src/cmd/dist/unix.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/make.bash	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-12-02 08:16:17 UTC) #1

dave_cheney.net

On 2012/12/02 08:16:17, dfc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

11 years, 4 months ago (2012-12-03 19:46:58 UTC) #2

dave_cheney.net

11 years, 4 months ago (2012-12-03 21:27:47 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=56b8a0a3ca74 ***

cmd/dist: support building on debian/kFreeBSD

The debian/kFreeBSD project uses the FreeBSD kernel and the debian userspace.
From our point of view, this is freebsd not linux as GOOS talks about the kernel
syscall interface, not the userspace (although cgo alters that). As
debian/kFreeBSD is experimental at this time, I do not think it is worth the
effort of duplicating all the freebsd specific code so this is proposal
represents a reasonable workaround.

Currently cgo is not supported, make.bash will detect this and disable cgo
automatically during the build.

dfc@debian:~/go/src$ uname -a
GNU/kFreeBSD debian 8.1-1-686 #0 Sat Jul 21 17:02:04 UTC 2012 i686 i386 Intel(R)
Core(TM) i5-2415M CPU @ 2.30GHz GNU/kFreeBSD
dfc@debian:~/go/src$ ../bin/go version
go version devel +d05272f402ec Sat Dec 01 15:15:14 2012 -0800

Tested with GOOS=freebsd GOARCH=386

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6868046

Expand All Messages | Collapse All Messages