Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 6868046: code review 6868046: cmd/dist: support building on debian/kFreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dfc
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

cmd/dist: support building on debian/kFreeBSD The debian/kFreeBSD project uses the FreeBSD kernel and the debian userspace. From our point of view, this is freebsd not linux as GOOS talks about the kernel syscall interface, not the userspace (although cgo alters that). As debian/kFreeBSD is experimental at this time, I do not think it is worth the effort of duplicating all the freebsd specific code so this is proposal represents a reasonable workaround. Currently cgo is not supported, make.bash will detect this and disable cgo automatically during the build. dfc@debian:~/go/src$ uname -a GNU/kFreeBSD debian 8.1-1-686 #0 Sat Jul 21 17:02:04 UTC 2012 i686 i386 Intel(R) Core(TM) i5-2415M CPU @ 2.30GHz GNU/kFreeBSD dfc@debian:~/go/src$ ../bin/go version go version devel +d05272f402ec Sat Dec 01 15:15:14 2012 -0800 Tested with GOOS=freebsd GOARCH=386

Patch Set 1 #

Patch Set 2 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d05272f402ec https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 1f3ebf9a7548 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/cmd/dist/unix.c View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/make.bash View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2012-12-02 08:16:17 UTC) #1
dfc
On 2012/12/02 08:16:17, dfc wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
9 years, 7 months ago (2012-12-03 19:46:58 UTC) #2
dfc
9 years, 7 months ago (2012-12-03 21:27:47 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=56b8a0a3ca74 ***

cmd/dist: support building on debian/kFreeBSD

The debian/kFreeBSD project uses the FreeBSD kernel and the debian userspace.
From our point of view, this is freebsd not linux as GOOS talks about the kernel
syscall interface, not the userspace (although cgo alters that). As
debian/kFreeBSD is experimental at this time, I do not think it is worth the
effort of duplicating all the freebsd specific code so this is proposal
represents a reasonable workaround.

Currently cgo is not supported, make.bash will detect this and disable cgo
automatically during the build.

dfc@debian:~/go/src$ uname -a
GNU/kFreeBSD debian 8.1-1-686 #0 Sat Jul 21 17:02:04 UTC 2012 i686 i386 Intel(R)
Core(TM) i5-2415M CPU @ 2.30GHz GNU/kFreeBSD
dfc@debian:~/go/src$ ../bin/go version
go version devel +d05272f402ec Sat Dec 01 15:15:14 2012 -0800

Tested with GOOS=freebsd GOARCH=386

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6868046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b