Code review - Issue 6868046: code review 6868046: cmd/dist: support building on debian/kFreeBSDhttps://codereview.appspot.com/2012-12-03T21:27:47+00:00rietveld
Message from unknown
2012-12-02T07:54:39+00:00dfcurn:md5:bde6fd15f4926d04c3ef158c13fc8ff1
Message from unknown
2012-12-02T07:54:47+00:00dfcurn:md5:b249fa43f045801ff25a17ea99103d23
Message from unknown
2012-12-02T08:16:06+00:00dfcurn:md5:60226998f4c1f4ae2dda10ecb9b55254
Message from dave@cheney.net
2012-12-02T08:16:17+00:00dfcurn:md5:c095f40dad04b0bdd1ed934d5b135bad
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from unknown
2012-12-03T19:45:01+00:00dfcurn:md5:6672dadcd0da46be4810895a9ee79230
Message from dave@cheney.net
2012-12-03T19:46:58+00:00dfcurn:md5:1a08a9be2de17c7480ada0ab1c5358af
On 2012/12/02 08:16:17, dfc wrote:
> Hello mailto:golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
PTAL. Detecting debian/kFreeBSD from uname -s was straight forward so I've added the logic into make.bash to disable cgo there.
Message from unknown
2012-12-03T21:27:18+00:00dfcurn:md5:e1841af690d61fffefbf9adf36aadec2
Message from dave@cheney.net
2012-12-03T21:27:47+00:00dfcurn:md5:a298f259dec52a09ba96de08b2676133
*** Submitted as https://code.google.com/p/go/source/detail?r=56b8a0a3ca74 ***
cmd/dist: support building on debian/kFreeBSD
The debian/kFreeBSD project uses the FreeBSD kernel and the debian userspace. From our point of view, this is freebsd not linux as GOOS talks about the kernel syscall interface, not the userspace (although cgo alters that). As debian/kFreeBSD is experimental at this time, I do not think it is worth the effort of duplicating all the freebsd specific code so this is proposal represents a reasonable workaround.
Currently cgo is not supported, make.bash will detect this and disable cgo automatically during the build.
dfc@debian:~/go/src$ uname -a
GNU/kFreeBSD debian 8.1-1-686 #0 Sat Jul 21 17:02:04 UTC 2012 i686 i386 Intel(R) Core(TM) i5-2415M CPU @ 2.30GHz GNU/kFreeBSD
dfc@debian:~/go/src$ ../bin/go version
go version devel +d05272f402ec Sat Dec 01 15:15:14 2012 -0800
Tested with GOOS=freebsd GOARCH=386
R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6868046