code review 6781053: go.net/spdy: disallow stream id 0

go.net/spdy: disallow stream id 0

Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.

[jmhodges, 2012-10-27 00:12:38]

Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[jmhodges, 2012-10-29 17:08:46]

Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),

Please take another look.

[jmhodges, 2012-10-29 17:10:38]

Fixed up the conflict that arose around importing encoding/base64 after
https://codereview.appspot.com/6786055/ shipped.

[bradfitz, 2012-10-29 17:18:40]

LGTM

https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go
File spdy/spdy_test.go (right):

https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go#newcode584
spdy/spdy_test.go:584: reader, err := NewFramer(buf, buf)
reading and writing to the same place?  seems sketchy.

this seems more clear: NewFramer(buf, bytes.NewReader(b))

or even:

NewFramer(ioutil.Discard, bytes.NewReader(b))

.. since you don't seem to use buf later anyway?

[jmhodges, 2012-10-29 17:31:49]

Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[jmhodges, 2012-10-29 17:32:09]

>
> NewFramer(ioutil.Discard, bytes.NewReader(b))
> 
> .. since you don't seem to use buf later anyway?

This is much better.  Done.

[mikio, 2012-10-30 06:18:16]

LGTM

please change the CL description to go.net/spdy, thx.

[jmhodges, 2012-10-30 06:29:12]

Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org,
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2012-10-30 07:13:03]

*** Submitted as
http://code.google.com/p/go/source/detail?r=c6c20fbea877&repo=net ***

go.net/spdy: disallow stream id 0

Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.

R=mikioh.mikioh, bradfitz
CC=adg, golang-dev
http://codereview.appspot.com/6781053

Committer: Mikio Hara <mikioh.mikioh@gmail.com>