Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(543)

Issue 6781053: code review 6781053: go.net/spdy: disallow stream id 0

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by jmhodges
Modified:
9 years, 3 months ago
Reviewers:
mikio, bradfitz
CC:
mikio, bradfitz, adg, golang-dev
Visibility:
Public.

Description

go.net/spdy: disallow stream id 0 Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.

Patch Set 1 #

Patch Set 2 : diff -r af69687727e7 https://code.google.com/p/go.net #

Patch Set 3 : diff -r af69687727e7 https://code.google.com/p/go.net #

Patch Set 4 : code review 6781053: net/spdy: disallow stream id 0 #

Patch Set 5 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 6 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Total comments: 1

Patch Set 7 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 8 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 9 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M spdy/read.go View 1 2 3 4 6 chunks +18 lines, -0 lines 0 comments Download
M spdy/spdy_test.go View 1 2 3 4 5 6 7 9 chunks +70 lines, -1 line 0 comments Download
M spdy/types.go View 1 4 1 chunk +1 line, -0 lines 0 comments Download
M spdy/write.go View 1 4 5 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9
jmhodges
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
9 years, 3 months ago (2012-10-27 00:12:38 UTC) #1
jmhodges
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
9 years, 3 months ago (2012-10-29 17:08:46 UTC) #2
jmhodges
Fixed up the conflict that arose around importing encoding/base64 after https://codereview.appspot.com/6786055/ shipped.
9 years, 3 months ago (2012-10-29 17:10:38 UTC) #3
bradfitz
LGTM https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go File spdy/spdy_test.go (right): https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go#newcode584 spdy/spdy_test.go:584: reader, err := NewFramer(buf, buf) reading and writing ...
9 years, 3 months ago (2012-10-29 17:18:40 UTC) #4
jmhodges
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
9 years, 3 months ago (2012-10-29 17:31:49 UTC) #5
jmhodges
> > NewFramer(ioutil.Discard, bytes.NewReader(b)) > > .. since you don't seem to use buf later ...
9 years, 3 months ago (2012-10-29 17:32:09 UTC) #6
mikio
LGTM please change the CL description to go.net/spdy, thx.
9 years, 3 months ago (2012-10-30 06:18:16 UTC) #7
jmhodges
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
9 years, 3 months ago (2012-10-30 06:29:12 UTC) #8
mikio
9 years, 3 months ago (2012-10-30 07:13:03 UTC) #9
*** Submitted as
http://code.google.com/p/go/source/detail?r=c6c20fbea877&repo=net ***

go.net/spdy: disallow stream id 0

Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.

R=mikioh.mikioh, bradfitz
CC=adg, golang-dev
http://codereview.appspot.com/6781053

Committer: Mikio Hara <mikioh.mikioh@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b