Code review - Issue 6781053: code review 6781053: go.net/spdy: disallow stream id 0https://codereview.appspot.com/2012-10-30T07:13:03+00:00rietveld
Message from unknown
2012-10-27T00:11:34+00:00jmhodgesurn:md5:ac81803a08dd56dac9fb7c4d4ce55ee9
Message from unknown
2012-10-27T00:11:38+00:00jmhodgesurn:md5:850b29fb82fb694d9b0dd00e5a16e70a
Message from unknown
2012-10-27T00:12:27+00:00jmhodgesurn:md5:97b73ded6eafec1d9d97e46f4c4e6d7a
Message from jeff@somethingsimilar.com
2012-10-27T00:12:38+00:00jmhodgesurn:md5:f15ccf0363bccc2d036a153c94b1193d
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go.net
Message from unknown
2012-10-29T17:05:40+00:00jmhodgesurn:md5:9dcf9a993b1a43df96cdf5202619b807
Message from unknown
2012-10-29T17:06:20+00:00jmhodgesurn:md5:c632c4862e1caf1fbba44bb1ac17e595
Message from unknown
2012-10-29T17:08:41+00:00jmhodgesurn:md5:4d753bbff740eee5e2ad54d8961f539d
Message from jeff@somethingsimilar.com
2012-10-29T17:08:46+00:00jmhodgesurn:md5:cf913b57043b4a114c2852af9062f07a
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),
Please take another look.
Message from jeff@somethingsimilar.com
2012-10-29T17:10:38+00:00jmhodgesurn:md5:7ec214364f42bc499e5027cc5014f710
Fixed up the conflict that arose around importing encoding/base64 after https://codereview.appspot.com/6786055/ shipped.
Message from bradfitz@golang.org
2012-10-29T17:18:40+00:00bradfitzurn:md5:9ee9c59353b0fa2edb31403d24da3ad0
LGTM
https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go
File spdy/spdy_test.go (right):
https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go#newcode584
spdy/spdy_test.go:584: reader, err := NewFramer(buf, buf)
reading and writing to the same place? seems sketchy.
this seems more clear: NewFramer(buf, bytes.NewReader(b))
or even:
NewFramer(ioutil.Discard, bytes.NewReader(b))
.. since you don't seem to use buf later anyway?
Message from unknown
2012-10-29T17:31:22+00:00jmhodgesurn:md5:36ee4dbfc3e822a0b878be3f0a363496
Message from unknown
2012-10-29T17:31:39+00:00jmhodgesurn:md5:e823e95b568873769ad8f6fc74d7a7b5
Message from jeff@somethingsimilar.com
2012-10-29T17:31:49+00:00jmhodgesurn:md5:ee05a6908ed8e422d355d9be2c677aea
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com),
Please take another look.
Message from jeff@somethingsimilar.com
2012-10-29T17:32:09+00:00jmhodgesurn:md5:041e99a7e7b6931b37533720eee87fd6
>
> NewFramer(ioutil.Discard, bytes.NewReader(b))
>
> .. since you don't seem to use buf later anyway?
This is much better. Done.
Message from mikioh.mikioh@gmail.com
2012-10-30T06:18:16+00:00mikiourn:md5:66ff0207d6483c63a3c1f19b1c3b8a94
LGTM
please change the CL description to go.net/spdy, thx.
Message from unknown
2012-10-30T06:29:08+00:00jmhodgesurn:md5:4b6dfcea1dc07cbeba450bdbc680c729
Message from jeff@somethingsimilar.com
2012-10-30T06:29:12+00:00jmhodgesurn:md5:3ecde4c218b5af83846d8cfab7e17fd9
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com),
Please take another look.
Message from mikioh.mikioh@gmail.com
2012-10-30T07:13:03+00:00mikiourn:md5:b5aa79cfec958cf2b56d400d672772f6
*** Submitted as http://code.google.com/p/go/source/detail?r=c6c20fbea877&repo=net ***
go.net/spdy: disallow stream id 0
Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.
R=mikioh.mikioh, bradfitz
CC=adg, golang-dev
http://codereview.appspot.com/6781053
Committer: Mikio Hara <mikioh.mikioh@gmail.com>