Issue 6786055: code review 6786055: net/spdy: handle corrupted zlib data on read

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6786055: code review 6786055: net/spdy: handle corrupted zlib data on read

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jmhodges

Modified:
10 years, 9 months ago

Reviewers:
mikio

CC:
golang-dev, rsc

Visibility:
Public.

Description

net/spdy: handle corrupted zlib data on read

Patch Set 1 #

Patch Set 2 : diff -r af69687727e7 https://code.google.com/p/go.net #

Patch Set 3 : diff -r af69687727e7 https://code.google.com/p/go.net #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
	M	spdy/read.go	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
	M	spdy/spdy_test.go	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jmhodges

Hello mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 6 months ago (2012-10-27 19:38:50 UTC) #1

jmhodges

This patch conflicts with the one in https://codereview.appspot.com/6781053/ a little, but it seemed preferable to ...

11 years, 6 months ago (2012-10-27 19:41:19 UTC) #2

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=3fefc1da6aa9&repo=net *** net/spdy: handle corrupted zlib data on read R=mikioh.mikioh CC=golang-dev, rsc ...

11 years, 6 months ago (2012-10-29 14:23:24 UTC) #3

R=close

Expand All Messages | Collapse All Messages