Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1296)

Issue 6114046: code review 6114046: runtime, reflect, ld, gc: garbage collection precision ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by atom
Modified:
8 years, 9 months ago
CC:
golang-dev
Visibility:
Public.

Description

runtime, reflect, ld, gc: garbage collection precision improvements

Patch Set 1 #

Patch Set 2 : diff -r cc8a35781b5e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cc8a35781b5e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2eec2501961c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4a18b0e071b1 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 4a18b0e071b1 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r d063a7844d48 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 95456588a8e1 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 95456588a8e1 https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 9182664c616f https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r 9e5ed0741dc8 https://go.googlecode.com/hg/ #

Total comments: 53

Patch Set 12 : diff -r 5eb6fe483779 https://go.googlecode.com/hg/ #

Patch Set 13 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 14 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 15 : diff -r 645947213cac https://go.googlecode.com/hg/ #

Patch Set 16 : diff -r d8bd45866999 https://go.googlecode.com/hg/ #

Patch Set 17 : diff -r 7cbb8aa08f8e https://go.googlecode.com/hg/ #

Patch Set 18 : diff -r dfb1b5655e21 https://go.googlecode.com/hg/ #

Patch Set 19 : diff -r 8d919bfe75d3 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 20 : diff -r 9d15015fc6e2 https://go.googlecode.com/hg/ #

Patch Set 21 : diff -r aa5d9f234a8e https://go.googlecode.com/hg/ #

Patch Set 22 : diff -r e8cfa948baf2 https://go.googlecode.com/hg/ #

Patch Set 23 : diff -r ecab7a7e7c7e https://go.googlecode.com/hg/ #

Patch Set 24 : diff -r e4df7915ab89 https://go.googlecode.com/hg/ #

Patch Set 25 : diff -r 49d533bb7cd3 https://go.googlecode.com/hg/ #

Patch Set 26 : diff -r 8d4bd93dcd41 https://go.googlecode.com/hg/ #

Patch Set 27 : diff -r 8f9b0fbf4c15 https://go.googlecode.com/hg/ #

Patch Set 28 : diff -r 85d759cdb33d https://go.googlecode.com/hg/ #

Patch Set 29 : diff -r f3e8dfc67e45 https://go.googlecode.com/hg/ #

Patch Set 30 : diff -r a565c143b41b https://code.google.com/p/go/ #

Patch Set 31 : diff -r f545866390ab https://code.google.com/p/go/ #

Patch Set 32 : diff -r fed789ce8072 https://code.google.com/p/go/ #

Patch Set 33 : diff -r dcb835ff82e0 https://code.google.com/p/go/ #

Patch Set 34 : diff -r dcb835ff82e0 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 35 : diff -r 5957d9d08900 https://code.google.com/p/go/ #

Patch Set 36 : diff -r 1f90b5850ae2 https://code.google.com/p/go/ #

Patch Set 37 : diff -r d6e06d0f3c29 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -19 lines) Patch
M src/pkg/runtime/malloc.goc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 18 chunks +254 lines, -17 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 63
atom
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2012-04-24 09:05:50 UTC) #1
dsymonds
You're not in the A+C files yet, but I see you've filled in the CLA. ...
10 years, 7 months ago (2012-04-24 12:12:25 UTC) #2
atom
If possible I would like somebody to apply this patch on a 64-bit machine and ...
10 years, 7 months ago (2012-04-25 11:44:54 UTC) #3
mpimenov
> > If possible I would like somebody to apply this patch on a 64-bit ...
10 years, 7 months ago (2012-04-25 12:02:13 UTC) #4
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-04-25 16:14:43 UTC) #5
dho
On 2012/04/25 16:14:43, atom wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:dsymonds@golang.org, mailto:mpimenov@google.com (cc: > mailto:golang-dev@googlegroups.com), > > ...
10 years, 7 months ago (2012-04-25 16:18:59 UTC) #6
aam
linux/amd64: all tests passed darwin/amd64: hung on testing go/printer (spining) the first attempt, then i ...
10 years, 7 months ago (2012-04-25 16:42:18 UTC) #7
atom
On 2012/04/25 16:42:18, aam wrote: > darwin/amd64: hung on testing go/printer (spining) the first attempt, ...
10 years, 7 months ago (2012-04-25 17:08:46 UTC) #8
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-04-26 18:06:22 UTC) #9
atom
Patch set 5: - Fixes a potential race condition when setting typeinfo in MSpan. - ...
10 years, 7 months ago (2012-04-26 18:13:57 UTC) #10
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-04-29 09:57:29 UTC) #11
atom
Patch set 6: - Add support for cases such as: type S struct {a,b,c T} ...
10 years, 7 months ago (2012-04-29 10:06:01 UTC) #12
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-05-01 16:59:13 UTC) #13
atom
Patch set 7: - add a mini buffer in scanblock(), and consequently do not use ...
10 years, 7 months ago (2012-05-01 17:04:27 UTC) #14
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-05-07 08:00:57 UTC) #15
atom
Patch set 8 is the last major patch set in this code review. There will ...
10 years, 7 months ago (2012-05-07 08:19:47 UTC) #16
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-05-07 10:04:41 UTC) #17
rsc
On Mon, May 7, 2012 at 4:19 AM, <0xE2.0x9A.0x9B@gmail.com> wrote: > * I would like ...
10 years, 7 months ago (2012-05-07 13:39:49 UTC) #18
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 7 months ago (2012-05-09 12:04:45 UTC) #19
atom
... some files were missing from the patches because I forgot to update the file ...
10 years, 7 months ago (2012-05-09 12:44:05 UTC) #20
rsc
Thanks for working on this. I understand that this code is primarily about adding precise ...
10 years, 7 months ago (2012-05-10 18:57:18 UTC) #21
0xe2.0x9a.0x9b_gmail.com
On Thu, May 10, 2012 at 8:56 PM, Russ Cox <rsc@golang.org> wrote: > Thanks for ...
10 years, 7 months ago (2012-05-10 20:00:26 UTC) #22
rsc
I believe these are the relevant CLs by Dmitry: http://codereview.appspot.com/5986054/ http://codereview.appspot.com/5534044/ This was the original ...
10 years, 7 months ago (2012-05-10 20:04:32 UTC) #23
atom
Just a note: The more precise GC can handle the i386 build issue that started ...
10 years, 7 months ago (2012-05-15 12:43:33 UTC) #24
atom
Hello golang-dev@googlegroups.com, dsymonds@golang.org, mpimenov@google.com, devon.odell@gmail.com, mirtchovski@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2012-05-23 16:52:11 UTC) #25
rsc
I made a first pass through for style-related things. I know it's annoying and avoids ...
10 years, 6 months ago (2012-05-24 16:36:45 UTC) #26
rsc
Let's make a separate CL that does nothing but add the (unused for now) gc ...
10 years, 6 months ago (2012-05-24 17:00:33 UTC) #27
atom
http://codereview.appspot.com/6114046/diff/42001/src/pkg/runtime/symtab.c File src/pkg/runtime/symtab.c (right): http://codereview.appspot.com/6114046/diff/42001/src/pkg/runtime/symtab.c#newcode223 src/pkg/runtime/symtab.c:223: if(!writestr) { On 2012/05/24 16:36:45, rsc wrote: > This ...
10 years, 6 months ago (2012-05-27 19:44:07 UTC) #28
atom
Hello dvyukov@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2012-06-01 16:45:18 UTC) #29
atom
http://codereview.appspot.com/6114046/diff/42001/src/cmd/ld/data.c File src/cmd/ld/data.c (right): http://codereview.appspot.com/6114046/diff/42001/src/cmd/ld/data.c#newcode631 src/cmd/ld/data.c:631: setuintxx(Sym *s, vlong r, uint64 v, int wid) On ...
10 years, 6 months ago (2012-06-01 16:45:47 UTC) #30
atom
Hello dvyukov@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 5 months ago (2012-06-24 16:00:22 UTC) #31
atom
Patch set 13: - a couple of bugfixes - support for slices - support for ...
10 years, 5 months ago (2012-06-24 16:06:04 UTC) #32
dvyukov
On 2012/06/24 16:06:04, atom wrote: > Patch set 13: > > - a couple of ...
10 years, 5 months ago (2012-06-25 07:04:52 UTC) #33
dvyukov
On 2012/06/25 07:04:52, dvyukov wrote: > On 2012/06/24 16:06:04, atom wrote: > > Patch set ...
10 years, 5 months ago (2012-06-25 07:08:24 UTC) #34
atom
Hello dvyukov@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 5 months ago (2012-06-25 07:53:45 UTC) #35
atom
On 2012/06/25 07:04:52, dvyukov wrote: > It seems that you hit the same issue as ...
10 years, 5 months ago (2012-06-25 08:00:10 UTC) #36
dvyukov
On 2012/06/25 08:00:10, atom wrote: > On 2012/06/25 07:04:52, dvyukov wrote: > > It seems ...
10 years, 5 months ago (2012-06-25 08:05:46 UTC) #37
atom
Hello dvyukov@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 5 months ago (2012-06-25 08:24:22 UTC) #38
dfc
Hello. This CL does not apply cleanly after d8bd45866999, could you please re mail it, ...
10 years, 5 months ago (2012-06-27 01:58:30 UTC) #39
atom
Hello dvyukov@google.com, rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 5 months ago (2012-06-27 07:40:53 UTC) #40
dfc
Some intersting results on linux/arm benchmark old ns/op new ns/op delta BenchmarkBinaryTree17 37367981000 53971314000 +44.43% ...
10 years, 5 months ago (2012-06-28 22:48:36 UTC) #41
atom
On 2012/06/28 22:48:36, dfc wrote: > Some intersting results on linux/arm > > benchmark old ...
10 years, 5 months ago (2012-06-30 17:07:47 UTC) #42
atom
On 2012/06/28 22:48:36, dfc wrote: > Some intersting results on linux/arm > > benchmark old ...
10 years, 5 months ago (2012-06-30 17:07:48 UTC) #43
atom
Hello dvyukov@google.com, rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-09-20 12:04:47 UTC) #44
atom
Patchset 17: - sync with the current tip of Go repository - fixes a bug ...
10 years, 2 months ago (2012-09-20 12:10:52 UTC) #45
minux1
Hi atom, could you please hg sync and upload a new Patch Set against current ...
10 years, 2 months ago (2012-10-04 08:55:08 UTC) #46
atom
Hello dvyukov@google.com, rsc@golang.org, dave@cheney.net, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-10-04 10:13:43 UTC) #47
minux1
Hi atom, I just applied Patch Set 18 to tip, and ./make.bash failed when it ...
10 years, 2 months ago (2012-10-05 09:24:57 UTC) #48
remyoudompheng
Hello atom, Is it possible to update the patchset now that CL6569057 has been submitted? ...
10 years, 1 month ago (2012-10-23 05:31:56 UTC) #49
atom
Hello dvyukov@google.com, rsc@golang.org, dave@cheney.net, minux.ma@gmail.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 1 month ago (2012-10-23 06:59:25 UTC) #50
remyoudompheng
http://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): http://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c#newcode516 src/pkg/runtime/mgc0.c:516: // Nearly the same code as the single-threaded version. ...
10 years, 1 month ago (2012-10-26 07:01:14 UTC) #51
remyoudompheng
http://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): http://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c#newcode1930 src/pkg/runtime/mgc0.c:1930: runtime·memorydump(void) Is it possible to send a separate review ...
10 years, 1 month ago (2012-10-27 08:48:43 UTC) #52
atom
https://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c#newcode516 src/pkg/runtime/mgc0.c:516: // Nearly the same code as the single-threaded version. ...
10 years, 1 month ago (2012-10-27 10:33:51 UTC) #53
atom
https://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/6114046/diff/113001/src/pkg/runtime/mgc0.c#newcode1930 src/pkg/runtime/mgc0.c:1930: runtime·memorydump(void) On 2012/10/27 08:48:43, remyoudompheng wrote: > Is it ...
10 years, 1 month ago (2012-10-27 10:40:48 UTC) #54
rsc
How do you suggest to proceed with the remaining 1500 lines of diffs? It is ...
10 years, 1 month ago (2012-11-01 18:48:51 UTC) #55
atom
On 2012/11/01 18:48:51, rsc wrote: > How do you suggest to proceed with the remaining ...
10 years, 1 month ago (2012-11-03 11:02:28 UTC) #56
remyoudompheng
On 2012/11/03 11:02:28, atom wrote: > 1. CL1: Add moreframesize_minalloc to struct M and use ...
10 years ago (2012-11-11 22:06:57 UTC) #57
minux1
Hi atom, after applying the latest patch set (20), and update to rev 7ea16cd2859c, encoding/xml ...
9 years, 11 months ago (2012-12-23 19:26:27 UTC) #58
atom
On 2012/12/23 19:26:27, minux wrote: > Hi atom, > after applying the latest patch set ...
9 years, 11 months ago (2012-12-23 20:08:12 UTC) #59
minux1
On Mon, Dec 24, 2012 at 4:08 AM, <0xE2.0x9A.0x9B@gmail.com> wrote: > If it also fails ...
9 years, 11 months ago (2012-12-25 07:17:16 UTC) #60
atom
On 2012/12/25 07:17:16, minux wrote: > On Mon, Dec 24, 2012 at 4:08 AM, <mailto:0xE2.0x9A.0x9B@gmail.com> ...
9 years, 11 months ago (2012-12-25 08:14:24 UTC) #61
atom
On 2012/12/23 19:26:27, minux wrote: > Hi atom, > after applying the latest patch set ...
9 years, 11 months ago (2012-12-26 12:19:55 UTC) #62
rsc
8 years, 11 months ago (2013-12-18 04:08:18 UTC) #63
R=close

I believe this CL turned into multiple other CLs, already submitted.

https://codereview.appspot.com/6114046/diff/201001/src/pkg/runtime/malloc.goc
File src/pkg/runtime/malloc.goc (right):

https://codereview.appspot.com/6114046/diff/201001/src/pkg/runtime/malloc.goc...
src/pkg/runtime/malloc.goc:493: if(false) *buf = 0;
What's this?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b