Issue 6339051: code review 6339051: runtime: fix potential GC deadlock

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6339051: code review 6339051: runtime: fix potential GC deadlock (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by dvyukov

Modified:
11 years, 10 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

runtime: fix potential GC deadlock The issue seems to not be triggered right now, but I've seen the deadlock after some other legal modifications to runtime. So I think we are safer this way.

Patch Set 1 #

Patch Set 2 : diff -r 645947213cac https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 645947213cac https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r f99b9475b914 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 10 months ago (2012-06-24 11:18:58 UTC) #1

rsc

I like to avoid SysAlloc unless necessary. It doesn't seem strictly necessary here. Russ

11 years, 10 months ago (2012-06-24 23:16:18 UTC) #3

dvyukov

11 years, 10 months ago (2012-06-25 07:03:41 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=631ba1cdd9fa ***

runtime: fix potential GC deadlock
The issue seems to not be triggered right now,
but I've seen the deadlock after some other legal
modifications to runtime.
So I think we are safer this way.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/6339051

Expand All Messages | Collapse All Messages