Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1317)

Issue 7000059: code review 7000059: reflect: declare slice as *[]unsafe.Pointer instead of ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by atom
Modified:
11 years, 3 months ago
Reviewers:
CC:
dvyukov, rsc, dfc, minux1, remyoudompheng, iant, golang-dev
Visibility:
Public.

Description

reflect: declare slice as *[]unsafe.Pointer instead of *[]byte The new garbage collector (CL 6114046) may find the fake *[]byte value and interpret its contents as bytes rather than as potential pointers. This may lead the garbage collector to free memory blocks that shouldn't be freed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/reflect/value.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
atom
Hello dvyukov, rsc, dfc, minux, remyoudompheng (cc: golang-dev@googlegroups.com), I'd like you to review this change ...
11 years, 3 months ago (2012-12-26 12:18:29 UTC) #1
minux1
LGTM. I've run xml.test on darwin/amd64 continuously for more than 1000 times, no more test ...
11 years, 3 months ago (2012-12-26 19:19:13 UTC) #2
iant
LGTM
11 years, 3 months ago (2012-12-27 00:07:33 UTC) #3
minux1
11 years, 3 months ago (2012-12-27 18:36:12 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=5105f3c015f4 ***

reflect: declare slice as *[]unsafe.Pointer instead of *[]byte

The new garbage collector (CL 6114046) may find the fake *[]byte value
and interpret its contents as bytes rather than as potential pointers.
This may lead the garbage collector to free memory blocks that
shouldn't be freed.

R=dvyukov, rsc, dave, minux.ma, remyoudompheng, iant
CC=golang-dev
https://codereview.appspot.com/7000059

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b