Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 583510045: axis-group-interface: avoid some cast warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by hanwenn
Modified:
1 month, 1 week ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

axis-group-interface: avoid some cast warnings

Patch Set 1 #

Total comments: 1

Patch Set 2 : dan's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M flower/include/interval.hh View 1 2 chunks +5 lines, -1 line 0 comments Download
M lily/axis-group-interface.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM
1 month, 2 weeks ago (2020-02-16 11:46:27 UTC) #1
Dan Eble
https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc#newcode277 lily/axis-group-interface.cc:277: Interval_t<vsize> rank_span (rank_span_int[LEFT], rank_span_int[RIGHT]); A constructor would clean this ...
1 month, 2 weeks ago (2020-02-16 13:17:53 UTC) #2
hanwenn
dan's suggestion
1 month, 2 weeks ago (2020-02-16 17:55:12 UTC) #3
hanwenn
1 month, 1 week ago (2020-02-26 22:34:35 UTC) #4
commit de02798e05dcfb08858f9041bdf2a8297a27f9be
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Thu Feb 13 14:44:01 2020 +0100

    axis-group-interface: avoid some cast warnings
    
    https://sourceforge.net/p/testlilyissues/issues/5769
    http://codereview.appspot.com/583510045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b