Code review - Issue 583510045: axis-group-interface: avoid some cast warningshttps://codereview.appspot.com/2020-02-26T22:34:35+00:00rietveld
Message from unknown
2020-02-16T11:19:23+00:00hanwennurn:md5:efcd44c041ad94635608cf430bf41f56
Message from lemzwerg@googlemail.com
2020-02-16T11:46:27+00:00lemzwergurn:md5:1f32a81a398bd9a73baffecd92c2dbdc
LGTM
Message from nine.fierce.ballads@gmail.com
2020-02-16T13:17:53+00:00Dan Ebleurn:md5:8ad90c4076349634e277c37b73a9e812
https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc#newcode277
lily/axis-group-interface.cc:277: Interval_t<vsize> rank_span (rank_span_int[LEFT], rank_span_int[RIGHT]);
A constructor would clean this up. I tried this:
template <typename T2>
Interval_t (Interval_t<T2> const &src) : Interval_t (src[LEFT], src[RIGHT])
{
}
Having that, both of the following compiled:
Interval_t<vsize> rank_span (g->spanned_rank_interval ());
Interval_t<vsize> rank_span = g->spanned_rank_interval ();
I also tested Interval_t<unsigned char> and the compiler still properly warns about conversions.
Message from unknown
2020-02-16T17:55:10+00:00hanwennurn:md5:e5c1e15273e3357e33abb4c4cdc05c65
Message from hanwenn@gmail.com
2020-02-16T17:55:12+00:00hanwennurn:md5:22d8a494f637f4924dc8f93d82ead248
dan's suggestion
Message from hanwenn@gmail.com
2020-02-26T22:34:35+00:00hanwennurn:md5:6c1b0c4ebd05ed29c5a3bc84162696d5
commit de02798e05dcfb08858f9041bdf2a8297a27f9be
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date: Thu Feb 13 14:44:01 2020 +0100
axis-group-interface: avoid some cast warnings
https://sourceforge.net/p/testlilyissues/issues/5769
http://codereview.appspot.com/583510045