Issue 583510045: axis-group-interface: avoid some cast warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 583510045: axis-group-interface: avoid some cast warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 2 months ago by hanwenn

Modified:
5 years, 2 months ago

Reviewers:
Dan Eble, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

axis-group-interface: avoid some cast warnings

Patch Set 2 : dan's suggestion #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	flower/include/interval.hh	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
	M	lily/axis-group-interface.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Dan Eble

https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/583510045/diff/559490043/lily/axis-group-interface.cc#newcode277 lily/axis-group-interface.cc:277: Interval_t<vsize> rank_span (rank_span_int[LEFT], rank_span_int[RIGHT]); A constructor would clean this ...

5 years, 2 months ago (2020-02-16 13:17:53 UTC) #2

hanwenn

5 years, 2 months ago (2020-02-26 22:34:35 UTC) #4

commit de02798e05dcfb08858f9041bdf2a8297a27f9be
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Thu Feb 13 14:44:01 2020 +0100

    axis-group-interface: avoid some cast warnings
    
    https://sourceforge.net/p/testlilyissues/issues/5769
    http://codereview.appspot.com/583510045

Expand All Messages | Collapse All Messages