Issue 342250043: Builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 342250043: Builds

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 7 months ago by ajuma

Modified:
5 years, 7 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Builds WIP BUG=

Patch Set 1 #

Patch Set 2 : Fix more bugs #

Patch Set 3 : FIx bug and clean up the should-apply-clip logic #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+340 lines, -138 lines)			Patch
M	Source/WebCore/ChangeLog	View	1 2	1 chunk	+90 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/FloatRect.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/FloatRect.cpp	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/LayoutRect.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/WebCore/platform/graphics/LayoutRect.cpp	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/WebCore/rendering/RenderBox.h	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	Source/WebCore/rendering/RenderBox.cpp	View	1 2	7 chunks	+62 lines, -60 lines	0 comments	Download
M	Source/WebCore/rendering/RenderInline.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderInline.cpp	View	1 2	3 chunks	+32 lines, -23 lines	0 comments	Download
M	Source/WebCore/rendering/RenderObject.h	View	1 2	2 chunks	+22 lines, -6 lines	0 comments	Download
M	Source/WebCore/rendering/RenderObject.cpp	View	1 2	2 chunks	+33 lines, -6 lines	0 comments	Download
M	Source/WebCore/rendering/RenderTableCell.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderTableCell.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/WebCore/rendering/RenderView.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderView.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGForeignObject.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGInline.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGInline.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGModelObject.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGModelObject.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGRoot.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGRoot.cpp	View	1	2 chunks	+13 lines, -5 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGText.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGText.cpp	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	Source/WebCore/rendering/svg/SVGRenderSupport.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/SVGRenderSupport.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download