Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(445)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 342250043: Builds
Patch Set: FIx bug and clean up the should-apply-clip logic Created 5 years, 6 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/FloatRect.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2018-09-21 Ali Juma <ajuma@chromium.org>
2
3 [IntersectionObserver] Factor out rect mapping and clipping logic from c omputeRectForRepaint
4 https://bugs.webkit.org/show_bug.cgi?id=189833
5
6 Reviewed by NOBODY (OOPS!).
7
8 Factor out the rect mapping and clipping logic from computeRectForRepain t to a new
9 computeVisibleRectInContainer method that computeRectForRepaint now call s. Make
10 computeVisibleRectInContainer take a VisibleRectContext with options to use
11 edge-inclusive intersection and to apply all clips and scrolls rather th an only
12 the clips and scrolls that are currently applied by the repaint logic. T hese
13 options will be used by IntersectionObserver in a future patch.
14
15 No new tests, no change in behavior.
16
17 * platform/graphics/FloatRect.cpp:
18 (WebCore::FloatRect::edgeInclusiveIntersect):
19 * platform/graphics/FloatRect.h:
20 * platform/graphics/LayoutRect.cpp:
21 (WebCore::LayoutRect::edgeInclusiveIntersect):
22 * platform/graphics/LayoutRect.h:
23 * rendering/RenderBox.cpp:
24 (WebCore::RenderBox::applyCachedClipAndScrollPosition const):
25 (WebCore::RenderBox::computeAbsoluteVisibleRectUsingPaintOffsetCache con st):
26 (WebCore::RenderBox::computeVisibleRectInContainer const):
27 (WebCore::RenderBox::applyCachedClipAndScrollPositionForRepaint const): Deleted.
28 (WebCore::RenderBox::shouldApplyClipAndScrollPositionForRepaint const): Deleted.
29 The iOS-specific logic in this method has moved to RenderObject::shouldA pplyClipsAndScrollsForRepaint.
30 ················································································
31 (WebCore::RenderBox::computeRectForRepaint const): Deleted.
32 * rendering/RenderBox.h:
33 (WebCore::RenderBox::computeRectForRepaint): Deleted.
34 * rendering/RenderInline.cpp:
35 (WebCore::RenderInline::clippedOverflowRectForRepaint const):
36 (WebCore::RenderInline::computeAbsoluteVisibleRectUsingPaintOffsetCache const):
37 (WebCore::RenderInline::computeVisibleRectInContainer const):
38 (WebCore::RenderInline::computeRectForRepaint const): Deleted.
39 * rendering/RenderInline.h:
40 (WebCore::RenderInline::computeRectForRepaint): Deleted.
41 * rendering/RenderObject.cpp:
42 (WebCore::RenderObject::shouldApplyClipsAndScrollsForRepaint):
43 (WebCore::RenderObject::visibleRectContextForRepaint):
44 (WebCore::RenderObject::computeRectForRepaint const):
45 (WebCore::RenderObject::computeFloatRectForRepaint const):
46 (WebCore::RenderObject::computeVisibleRectInContainer const):
47 (WebCore::RenderObject::computeFloatVisibleRectInContainer const):
48 * rendering/RenderObject.h:
49 (WebCore::RenderObject::computeAbsoluteRepaintRect const):
50 (WebCore::RenderObject::VisibleRectContext::VisibleRectContext):
51 (WebCore::RenderObject::RepaintContext::RepaintContext): Deleted.
52 (WebCore::RenderObject::computeRectForRepaint): Deleted.
53 * rendering/RenderTableCell.cpp:
54 (WebCore::RenderTableCell::computeVisibleRectInContainer const):
55 (WebCore::RenderTableCell::computeRectForRepaint const): Deleted.
56 * rendering/RenderTableCell.h:
57 * rendering/RenderView.cpp:
58 (WebCore::RenderView::computeVisibleRectInContainer const):
59 (WebCore::RenderView::computeRectForRepaint const): Deleted.
60 * rendering/RenderView.h:
61 * rendering/svg/RenderSVGForeignObject.cpp:
62 (WebCore::RenderSVGForeignObject::computeFloatVisibleRectInContainer con st):
63 (WebCore::RenderSVGForeignObject::computeVisibleRectInContainer const):
64 (WebCore::RenderSVGForeignObject::computeFloatRectForRepaint const): Del eted.
65 (WebCore::RenderSVGForeignObject::computeRectForRepaint const): Deleted.
66 * rendering/svg/RenderSVGForeignObject.h:
67 * rendering/svg/RenderSVGInline.cpp:
68 (WebCore::RenderSVGInline::computeFloatVisibleRectInContainer const):
69 (WebCore::RenderSVGInline::computeFloatRectForRepaint const): Deleted.
70 * rendering/svg/RenderSVGInline.h:
71 * rendering/svg/RenderSVGModelObject.cpp:
72 (WebCore::RenderSVGModelObject::computeFloatVisibleRectInContainer const ):
73 (WebCore::RenderSVGModelObject::computeFloatRectForRepaint const): Delet ed.
74 * rendering/svg/RenderSVGModelObject.h:
75 * rendering/svg/RenderSVGRoot.cpp:
76 (WebCore::RenderSVGRoot::computeFloatVisibleRectInContainer const):
77 (WebCore::RenderSVGRoot::computeFloatRectForRepaint const): Deleted.
78 * rendering/svg/RenderSVGRoot.h:
79 * rendering/svg/RenderSVGText.cpp:
80 (WebCore::RenderSVGText::computeVisibleRectInContainer const):
81 (WebCore::RenderSVGText::computeFloatVisibleRectInContainer const):
82 (WebCore::RenderSVGText::computeRectForRepaint const): Deleted.
83 (WebCore::RenderSVGText::computeFloatRectForRepaint const): Deleted.
84 * rendering/svg/RenderSVGText.h:
85 * rendering/svg/SVGRenderSupport.cpp:
86 (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
87 (WebCore::SVGRenderSupport::computeFloatVisibleRectInContainer):
88 (WebCore::SVGRenderSupport::computeFloatRectForRepaint): Deleted.
89 * rendering/svg/SVGRenderSupport.h:
90
1 2018-09-18 Basuke Suzuki <Basuke.Suzuki@sony.com> 91 2018-09-18 Basuke Suzuki <Basuke.Suzuki@sony.com>
2 92
3 [Curl] Limit capturing extra metrics for Web Inspector when not required . 93 [Curl] Limit capturing extra metrics for Web Inspector when not required .
4 https://bugs.webkit.org/show_bug.cgi?id=189520 94 https://bugs.webkit.org/show_bug.cgi?id=189520
5 95
6 Reviewed by Alex Christensen. 96 Reviewed by Alex Christensen.
7 97
8 Respect the value of NetworkDataTask::shouldCaptureExtraNetworkLoadMetri cs() to reduce the process 98 Respect the value of NetworkDataTask::shouldCaptureExtraNetworkLoadMetri cs() to reduce the process
9 time when they are not needed. 99 time when they are not needed.
10 100
(...skipping 2459 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 Refactor filter list checking code 2560 Refactor filter list checking code
2471 https://bugs.webkit.org/show_bug.cgi?id=185087 2561 https://bugs.webkit.org/show_bug.cgi?id=185087
2472 2562
2473 Reviewed by Antonio Gomes. 2563 Reviewed by Antonio Gomes.
2474 2564
2475 No new tests, behavior unchanged. 2565 No new tests, behavior unchanged.
2476 2566
2477 * page/animation/KeyframeAnimation.h: Add missing forward-declaration Fi lterOperations. 2567 * page/animation/KeyframeAnimation.h: Add missing forward-declaration Fi lterOperations.
2478 2568
2479 == Rolled over to ChangeLog-2018-09-11 == 2569 == Rolled over to ChangeLog-2018-09-11 ==
OLDNEW
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/FloatRect.h » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b