Issue 134590043: code review 134590043: Let COMPILE_ASSERT use static_assert if available.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 134590043: code review 134590043: Let COMPILE_ASSERT use static_assert if available. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by thakis

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

Let COMPILE_ASSERT use static_assert if available. The motivation is that gcc 4.8+ and clang trunk warn on unused local typedefs, which COMPILE_ASSERT adds. After this change, the warning will be happy at least in C++11 builds. static_assert also produces a slighly nicer diagnostic than the typedef method. While here, merge https://codereview.appspot.com/57500045 and https://codereview.appspot.com/13112043 so that the steps on https://code.google.com/p/re2/wiki/Contribute work again.

Patch Set 1 #

Patch Set 2 : diff -r b92ce81f1e25 https://re2.googlecode.com/hg #

Patch Set 3 : diff -r b92ce81f1e25 https://re2.googlecode.com/hg #

Patch Set 4 : diff -r b92ce81f1e25 https://re2.googlecode.com/hg #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	lib/codereview/codereview.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	util/util.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thakis

Hello rsc@golang.org (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg

10 years, 10 months ago (2014-09-06 23:21:21 UTC) #1

rsc

LGTM You have commit access now. Feel free to hg submit. See swtch.com/~rsc/gohg.html if you ...

10 years, 10 months ago (2014-09-07 01:11:51 UTC) #2

thakis

*** Submitted as https://code.google.com/p/re2/source/detail?r=2225f94df8ec *** Let COMPILE_ASSERT use static_assert if available. The motivation is that ...

10 years, 10 months ago (2014-09-07 02:38:05 UTC) #3

thakis

10 years, 10 months ago (2014-09-07 02:38:25 UTC) #4

Thanks!!

On Sat, Sep 6, 2014 at 7:38 PM, <thakis@chromium.org> wrote:

> *** Submitted as
> https://code.google.com/p/re2/source/detail?r=2225f94df8ec ***
>
> Let COMPILE_ASSERT use static_assert if available.
>
> The motivation is that gcc 4.8+ and clang trunk warn on unused local
> typedefs, which COMPILE_ASSERT adds. After this change, the warning
> will be happy at least in C++11 builds. static_assert also produces a
> slighly nicer diagnostic than the typedef method.
>
> While here, merge https://codereview.appspot.com/57500045 and
> https://codereview.appspot.com/13112043 so that the steps on
> https://code.google.com/p/re2/wiki/Contribute work again.
>
> R=rsc
> CC=re2-dev
> https://codereview.appspot.com/134590043
>
>
> https://codereview.appspot.com/134590043/
>

Expand All Messages | Collapse All Messages