Issue 57500045: code review 57500045: codereview: fix for Mercurial 2.9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 57500045: code review 57500045: codereview: fix for Mercurial 2.9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by ality

Modified:
11 years, 4 months ago

Reviewers:
r, gobot, fss

CC:
golang-codereviews, fss, r

Visibility:
Public.

Description

codereview: fix for Mercurial 2.9 The branchtags method was removed but we should've been using branchmap all along. http://selenic.com/hg/rev/4274eda143cb

Patch Set 1 #

Patch Set 2 : diff -r 1fda0c956e3f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1fda0c956e3f https://code.google.com/p/go/ #

Patch Set 4 : diff -r e567ba9899fb https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/codereview/codereview.py	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ality

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2014-02-04 04:31:32 UTC) #1

ality

On 2014/02/05 04:52:06, fss wrote: > LGTM, tested with Mercurial 2.6, 2.7, 2.8 and 2.9. ...

11 years, 4 months ago (2014-02-10 09:10:59 UTC) #3

ality

*** Submitted as https://code.google.com/p/go/source/detail?r=763f52c7e5ff *** codereview: fix for Mercurial 2.9 The branchtags method was removed ...

11 years, 4 months ago (2014-02-14 23:57:16 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.

Expand All Messages | Collapse All Messages